From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99E7CC4338F for ; Mon, 2 Aug 2021 10:21:13 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0550060F51 for ; Mon, 2 Aug 2021 10:21:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0550060F51 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E22E9832E4; Mon, 2 Aug 2021 12:21:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id DCCFD833B1; Mon, 2 Aug 2021 12:21:08 +0200 (CEST) Received: from ATCSQR.andestech.com (atcsqr.andestech.com [60.248.187.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 90E8C83167 for ; Mon, 2 Aug 2021 12:21:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (atcpcs16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id 172AKnJD061428; Mon, 2 Aug 2021 18:20:49 +0800 (GMT-8) (envelope-from ycliang@andestech.com) Received: from andestech.com (10.0.15.65) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Mon, 2 Aug 2021 18:20:49 +0800 Date: Mon, 2 Aug 2021 18:20:47 +0800 From: Leo Liang To: Bin Meng CC: Subject: Re: [PATCH 1/1] doc: riscv: flashing SiFive boards Message-ID: <20210802102047.GA19335@andestech.com> References: <20210728090301.79193-1-xypron.glpk@gmx.de> <20210802085041.GC3588@andestech.com> <20210802091704.GA22233@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.0.15.65] X-DNSRBL: X-MAIL: ATCSQR.andestech.com 172AKnJD061428 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Bin, On Mon, Aug 02, 2021 at 05:48:49PM +0800, Bin Meng wrote: > Hi Leo, > > On Mon, Aug 2, 2021 at 5:17 PM Leo Liang wrote: > > > > Hi Bin, > > On Mon, Aug 02, 2021 at 05:01:07PM +0800, Bin Meng wrote: > > > Hi Leo, > > > > > > On Mon, Aug 2, 2021 at 4:50 PM Leo Liang wrote: > > > > > > > > Hi Bin, > > > > > > > > On Wed, Jul 28, 2021 at 05:18:59PM +0800, Bin Meng wrote: > > > > > On Wed, Jul 28, 2021 at 5:03 PM Heinrich Schuchardt wrote: > > > > > > > > > > > > > > > > nits: missing > > > > > > > > Could you explain what is missing here? > > > > I did not quite catch the point, thanks! > > > > > > > > > > Missing the 2nd line I mentioned in my previous email: > > > > Do you mean that there is supposed to be a sentence but it is missing now? > > If so then got it, let's wait for Heinrich's comment. > > This patch is missing the following line: > > From: Heinrich Schuchardt > > Which makes this commit's author does NOT match to SoB. > Got it! Thanks for the explanation! Then let's wait for Heinrich's 2nd patch. Best regards, Leo > > > > > > > > From: Heinrich Schuchardt > > > > > > > > > > > > > From: Heinrich Schuchardt > > > > > > > > > > > We should not use /dev/sda and /dev/sdb in our examples. Users might > > > > > > inadvertently mess up their workstation. Use /dev/sdX instead. > > > > > > > > > > > > Remove console output like '# ' and '> ' which makes copying hard. > > > > > > > > > > > > Set example language to bash for correct syntax-highlighting. > > > > > > > > > > > > Signed-off-by: Heinrich Schuchardt > > > > > > --- > > > > > > doc/board/sifive/unleashed.rst | 20 ++++++++++---------- > > > > > > doc/board/sifive/unmatched.rst | 30 +++++++++++++++--------------- > > > > > > 2 files changed, 25 insertions(+), 25 deletions(-) > > > > > > > > > > > > > > > > Otherwise > > > > > Reviewed-by: Bin Meng > > > > > Regards, > Bin