Re: [PATCH 3/5] ARM: dts: at91: sama5d2: Add memory node in devicetree

Eugen.Hristev
2021-08-03T08:58:34Z

On 8/2/21 3:39 PM, Clément Léger wrote:
> sama5d2 support from DRAM will be modified to use device tree instead of
> hardcoded addresses. In order to prepare that, add the memory node to
> sama5d2.dtsi file since the boards supported by U-Boot with sama5d2 all
> contains 512Mb of DDR.
>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>
> ---
> arch/arm/dts/sama5d2.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi
> index 6fb2cb25f9..299aefc496 100644
> --- a/arch/arm/dts/sama5d2.dtsi
> +++ b/arch/arm/dts/sama5d2.dtsi
> @@ -4,6 +4,10 @@
> model = "Atmel SAMA5D2 family SoC";
> compatible = "atmel,sama5d2";
>
> + memory {
> + reg = <0x20000000 0x20000000>;
> + };

Hi,

Memory is external to the SoC. You have to move this node to the board
specific DTS.

Even if all current boards have 512 MB of DRAM , this does not belong here.

And by the way this is not true, since this SoC can work in a SiP with
only 256 or 128 MB of DRAM for example and this is true for certain
boards ( wlsom1_ek comes to my mind now).

Eugen

> +
> aliases {
> spi0 = &spi0;
> spi1 = &qspi0;
> --
> 2.32.0
>