Re: [PATCH 11/11] Remove including timestamp.h in version.h

Simon Glass
2021-08-02T19:22:20Z

Hi Pali,

On Mon, 2 Aug 2021 at 07:20, Pali Rohár <pali@kernel.org> wrote:
>
> Header file version.h does not use anything from timestamp.h. Including of
> timestamp.h has side effect which cause recompiling object file at every
> make run because timestamp.h changes at every run.
>
> So remove timestamp.h from version.h and include timestamp.h in files
> which needs it.
>
> This change reduce recompilation time of final U-Boot binary when U-Boot
> source files were not changed as less source files needs to be recompiled.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> ---
> arch/arm/mach-rockchip/tpl.c | 4 ++++
> board/work-microwave/work_92105/work_92105_display.c | 1 +
> cmd/version.c | 1 +
> common/spl/spl.c | 4 ++++
> drivers/rtc/emul_rtc.c | 2 +-
> include/version.h | 2 --
> 6 files changed, 11 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

I assume we do actually want to regenerate the timestamp when U-Boot
builds, even if nothing has changed. Is that right? It could be
confusing otherwise, as people cannot 'update' the banner without
making a trivial change.

Regards,
SImon