Re: [PATCH 00/11] Reduce usage of timestamp macros

Tom Rini
2021-09-01T21:17:21Z

[-- Attachment #1: Type: text/plain, Size: 2583 bytes --]

On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Rohár wrote:
> On Wednesday 01 September 2021 16:59:09 Tom Rini wrote:
> > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote:
> >
> > > Including timestamp.h (either directly or transitionally) cause build
> > > system to recompile binaries at every 'make' run. This has disadvantage
> > > in U-Boot development as for every small change 'make' recompiles lot of
> > > other irrelevant files which were not touched / changed.
> > >
> > > This patch series eliminate transitional / indirect usage of
> > > timestamp.h by removing unneeded inclusion of header files, moving
> > > timestamp values from macros to global variables, etc...
> > >
> > > After these patches, U-Boot tools are not recompiled by every 'make' run,
> > > which decrease time for incremental U-Boot recompilation.
> > >
> > > Please test these patches, specially m68k and powerpc parts as I do not
> > > have any of these boards.
> > >
> > > Patch series depend on this patch (now marked as accepted):
> > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-pali@kernel.org/
> > >
> > > Pali Rohár (11):
> > > Remove #include <timestamp.h> from files which do not need it
> > > Remove #include <version.h> from files which do not need it
> > > efi_loader: Use directly version_string variable
> > > version: Move version_string[] from version.h to version_string.h
> > > m68k: mcf: Remove overloading version_string
> > > version: Put version_string[] variable into section
> > > .text_version_string
> > > powerpc: mpc: Put U-Boot version string at correct place by linker
> > > script
> > > version: Do not make version_string[] variable as a weak
> > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log
> > > version: Remove global macro U_BOOT_VERSION_STRING from version.h
> > > Remove including timestamp.h in version.h
> >
> > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948
> > this fails to build for at least qemu-ppce500 and xtfpga. Over in
> > doc/develop/ci_testing.rst we document how to run a world build. Please
> > fix these build errors and re-submit, thanks.
>
> Already happened about month ago
> https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-pali@kernel.org/
>
> As stated, following build command now passes:
> make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin

OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC...

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]