Re: [PATCH] xtensa: Put U-Boot version string at correct place by linker script

Francesco Dolcini
2021-09-16T19:50:45Z

On Thu, Sep 16, 2021 at 03:42:20PM -0400, Tom Rini wrote:
> On Thu, Sep 16, 2021 at 09:38:19PM +0200, Francesco Dolcini wrote:
> > On Thu, Sep 16, 2021 at 01:30:21PM -0400, Tom Rini wrote:
> > > *(.literal .text) \
> > > + *(.literal .text_version_string) \
> >
> > Isn't ".litteral" a duplication? Even if I'm pretty sure it will not cause any difference
> > in the generated binary I would remove it.
>
> Honestly, I don't know xtensa. We also don't have qemu support for it
> currently, and I'm a bit worried in general about the state of the
> platform (it's on my TODO list to poke some people now). So, I hesitate
> to make any change that's not basically copy/paste of the existing
> lines.

I have no experience on xtensa either, but this is just the section
name, and you are just telling to put ".literal" there 2 times.

Francesco