From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF57C4338F for ; Mon, 2 Aug 2021 17:51:29 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9ED656101D for ; Mon, 2 Aug 2021 17:51:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9ED656101D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2858882916; Mon, 2 Aug 2021 19:51:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="f5g2EUJ7"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0E7D882903; Mon, 2 Aug 2021 19:51:25 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E582282903 for ; Mon, 2 Aug 2021 19:51:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id x3so17388857qkl.6 for ; Mon, 02 Aug 2021 10:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fj9TL7pUP/sPKno+OUMOijUpuTWlhJE5M5KmuJ45g5U=; b=f5g2EUJ742xAmrn94jQC9TVcTjjRS78Au8SY8vdbvhsrZoRu/BvXAH4yBravIW90gV qQffCo82CmXnGTvy9q/OwY+qq2l6c8/aiHjCn1J4Dg9JfidySyygG8ItIgHk47oAJXla 7aIvopgfLsTWBsCKZcBQ9mFHs4aEq1B9GPnLI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fj9TL7pUP/sPKno+OUMOijUpuTWlhJE5M5KmuJ45g5U=; b=IjzbAGl1hYt44iQHcOofGvTXJ6w7A2gRVecyfZAAU6Hsg2+M5m+8fpmd1Ub+hv2hXv kmdPx/pcqp4H767J+qEJI/wRyhaorTQfc+Z+pCm8sevbccpfDE21lZGORjkq3d4KuVJI K39RcecThE3iE89RmGLzEbk/iEUNrMI9XRy+mXaIcY0VKgqhBvv6stXI5mi2jecgEg6K P5yAabdpkabBdIAG4QNti7/ExZc27tpB3rC0vF/knN/o4okTF2rh/KyLp4vmvBjmsNJo lRlYHtGEj+n5mppARpDZ9urhRdCJQhNGu2K64cCV/lv56gb0tCBm4LS1G08DQ23qneyg MH6g== X-Gm-Message-State: AOAM531kgixd/PwNPxxVK1BORNR8fOR3OuFORTAf6b4R7AoeqPAxzzvN syu0KQki9Q9yLOaWW17YPcu+cA== X-Google-Smtp-Source: ABdhPJzREh3Db1oMhUiWYkFos4OrgY61ry+rmwMbqEeOqanZ5Jk1IUMCgYFiccrSyPkigCSA6WMEig== X-Received: by 2002:a37:a3c5:: with SMTP id m188mr11230877qke.307.1627926680722; Mon, 02 Aug 2021 10:51:20 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a0a3-ef76-0712-405d.res6.spectrum.com. [2603:6081:7b01:cbda:a0a3:ef76:712:405d]) by smtp.gmail.com with ESMTPSA id k7sm6214767qkj.79.2021.08.02.10.51.18 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Aug 2021 10:51:18 -0700 (PDT) Date: Mon, 2 Aug 2021 13:51:16 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , "Jonathan A . Kollasch" , Marek Vasut , Heinrich Schuchardt , Marek =?iso-8859-1?Q?Beh=FAn?= , Eugeniu Rosca , Roland Gaudig , Stefan Herbrechtsmeier , Sean Anderson , Joe Hershberger Subject: Re: [PATCH v2 01/14] hash: Ensure verification hex pairs are terminated Message-ID: <20210802175116.GP9379@bill-the-cat> References: <20210724150341.243074-1-sjg@chromium.org> <20210724150341.243074-2-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EjzMHt9S0ayEzO8E" Content-Disposition: inline In-Reply-To: <20210724150341.243074-2-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --EjzMHt9S0ayEzO8E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jul 24, 2021 at 09:03:28AM -0600, Simon Glass wrote: > This function seems to assume that the chr[] variable contains zeros at > the start, which is not always true. Use strlcpy() to be safe. >=20 > Signed-off-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --EjzMHt9S0ayEzO8E Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEIMJEACgkQFHw5/5Y0 tyxcWwwAlhCacQEWGL8yzLq3BA9XMPgzTIbMc0Hp4xBieDrfCVZ2nSwv6W1LaZy0 /fjHFZBmGjMTnAjF2puIaNAH7KfMiMKVVFsK8wvR4flEhYzyYERcNUn4GrSXTvnc 7RnGMDR8XqVFPx7ckFAygVa75Ua2OSyq3e2fkQVjv9CLEO1oP/JyLGkgLyn330KP x1+WWnzt5OpUtariYyFUCjUZLdMATHy0m/j2YcHYRcvosX+kFOjr62x9nBh2GSIX Xo+N4yv8FlOLA2JwrkTbEvHLJwwWkv8NojU0E45LbJbP1jrUVQFl1hCAHA7ZpdgP 5O/FiBx4mV8jjfq6mo53i+YOHKshqJZUF2y55pVY26t7qFjrRDNMJNFlsxv3Li3/ qtR2Yf/HEPrlXV1sSkgPWqjraRUmtmIsy/qpvgmwnc9X24NiEvrtNum6Diw7pozW BvN46FvW7O+I+fryeTJoT44yhs5JktV/pxuJOV7FldoXQ1rz/r6NcPOQe6D//mZ+ I9Vo0VYU =s11B -----END PGP SIGNATURE----- --EjzMHt9S0ayEzO8E--