From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 482F3C4338F for ; Tue, 3 Aug 2021 00:21:49 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65FA46023E for ; Tue, 3 Aug 2021 00:21:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 65FA46023E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1770682D92; Tue, 3 Aug 2021 02:21:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="sE2doB2K"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 00F1682D9B; Tue, 3 Aug 2021 02:21:44 +0200 (CEST) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7A24082D7E for ; Tue, 3 Aug 2021 02:21:40 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pj1-x1033.google.com with SMTP id j1so27455776pjv.3 for ; Mon, 02 Aug 2021 17:21:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=IzMGjqDF51pfZV+aAa1Z/wkULkV3rywmQRj7q1nhmN8=; b=sE2doB2KmreERRIJwWDYnKLRlrQREFHkRVfEbHFLxDf4zcjthcH3YijEPBhiKQQxU2 /Fa20lncJvj5mAA9HnQVGOYKh2Abo0e243mHVv79LFbaagTXLbmA3FzoOqWZUIkB1Z/H aSATDe0wXM4TMyann+VZBFvPw5elGpi3h28J/9907dAvNv+TEZ7zITinsa6MVzv8nRiI oW0nd2F+aazbnBpJJ0lAvhyu4CmIon0LqwOBOtv9Ucx5w0R0KblZbqE+WSZhYIo8ucm7 QOPBDG/RaMuyV6gTPeKqSBLz4qLZxjL2XSkchKhHVXMZ5vT5XNFPnkTo+AH5QCoi8mmQ GIsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=IzMGjqDF51pfZV+aAa1Z/wkULkV3rywmQRj7q1nhmN8=; b=SOEKeqXFfoRLfSNN0XcfDRfDYfRJW2ewpzz24feKuWNMDp7As8co3YPmWQJOqce15y LRRLQCHnJ0HrNM532AidsnJDm825UvmFncnOvvyMY3uRX5ylnFpEIxB+GwnGmaUt1IyO 9bOUbfa3WSn9vF/+z0qCQDbZfeQ/HQt4NCGhszPqV39UDcMywZqspawpWZGsZZyJO206 yS7knF+y7pRyigHR8S/aAvEy5GZeDmqchXndrRyJsBGIXJesdVn7u4qON90/hk3SFH4h CGrCrKx/gtSVOFE1PFtTiVAjuirKmWpTIPrnwdvRoPGAf+R7Lx71nY7JN+SkVsq8ljvd EAIw== X-Gm-Message-State: AOAM531ZOYYSAbwJihDbXzRjx5mRslWw3DBWpod56KLM4GMGHUG4Q2pS CxaUlDT6zdQEBkA05PgZr5rUaw== X-Google-Smtp-Source: ABdhPJxDkOmnX0DarmPnZdWMtCb+12MwgBduEHtBJ20HOOAxlQkcAYp8ZbOwQ3aQ0UtS2KRLad3RXA== X-Received: by 2002:a17:90a:af88:: with SMTP id w8mr2730168pjq.104.1627950098648; Mon, 02 Aug 2021 17:21:38 -0700 (PDT) Received: from laputa (pdb6272b1.tkyea130.ap.so-net.ne.jp. [219.98.114.177]) by smtp.gmail.com with ESMTPSA id a12sm2072220pfo.175.2021.08.02.17.21.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Aug 2021 17:21:38 -0700 (PDT) Date: Tue, 3 Aug 2021 09:21:33 +0900 From: KASHI Takahiro To: Simon Glass Cc: Ilias Apalodimas , U-Boot Mailing List , Heinrich Schuchardt , Alexander Graf , Masami Hiramatsu , Sughosh Ganu Subject: Re: [PATCH] Revert "efi_capsule: Move signature from DTB to .rodata" Message-ID: <20210803002133.GA44851@laputa> Mail-Followup-To: KASHI Takahiro , Simon Glass , Ilias Apalodimas , U-Boot Mailing List , Heinrich Schuchardt , Alexander Graf , Masami Hiramatsu , Sughosh Ganu References: <20210802014621.2280899-1-sjg@chromium.org> <20210802071500.GG7965@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, Aug 02, 2021 at 08:44:41AM -0600, Simon Glass wrote: > Hi, > > On Mon, 2 Aug 2021 at 01:15, KASHI Takahiro wrote: > > > > On Sun, Aug 01, 2021 at 08:47:15PM -0600, Simon Glass wrote: > > > Hi Ilias, > > > > > > On Sun, 1 Aug 2021 at 20:28, Ilias Apalodimas > > > wrote: > > > > > > > > Hi Simon, > > > > > > > > On Sun, Aug 01, 2021 at 07:46:21PM -0600, Simon Glass wrote: > > > > > This was unfortunately applied despite much discussion about it being > > > > > the wrong way to implement this feature. > > > > > > > > No this was applied *before* the discussion, not despite. > > > > > > Oh sorry...I didn't notice either way. Normally there is an email on > > > the patch saying it was applied. Perhaps I missed it. > > > > > > > > > > > > > > > > > Revert it before too many other things are built on top of it. > > > > > > > > I don't really mind if this gets reverted but there's things that haven't > > > > been answered on that discussion [1] and my concern is what happens if > > > > CONFIG_OF_EMBED is not selected. > > > > > > Can we start a new discussion perhaps? Or use one of the contributor > > > calls to talk about it? > > > > > > We should not be using OF_EMBED except for testing. > > > > > > > > > > > Also you need to revert the entire series, not just one of the patches, > > > > as it changes the QEMU documentation for enabling authenticated capsule > > > > updates, as well as the mkeficapsule app. > > > > > > Heinrich, do you have any thoughts on this? > > > > # I'm not Heinrich :) > > Perhaps you could impersonate him :-) I ask because he had been doing > a lot of EFI work. I know. I was just kidding :) > > > > As far as the authentication logic itself is concerned, > > it is utterly generic except how and from where a public key is > > retrieved. (It can potentially be platform-specific.) > > Moreover, mkeficapsule really doesn't care where the key is. > > > > So I don't think we need revert all those changes. > > I agree. Having another look, I think perhaps three patches is enough. > I will try again. > > > > > For testing, we can run a test on sandbox by having sandbox-specific > > efi_get_public_key_data() function, i.e. we may want to contain > > the key in a file on ESP or just in a specific flash partition. > > > > Obviously, it's not safe, but it's just a test to verify that the logic > > is sane. > > > > If the discussion goes on for an unexpected spell of time, > > I would like to take this workaround for now. > > I think this effort should go back to before the change to putting > things in rodata. That was when things went really off the rails. > > With things back in the DT, you should be able to write a test with > the existing sandbox build without any special-case code. Well, that is the way I have adopted in my v1 patch[1]. I hope that the discussion be settled first. -Takahiro Akashi [1] https://lists.denx.de/pipermail/u-boot/2021-May/449575.html > [..] > > Regards, > Simon