Re: [PATCH v2 0/3] efi: Minimal revert to rodata change

Tom Rini
2021-08-09T16:01:33Z

[-- Attachment #1: Type: text/plain, Size: 1543 bytes --]

On Thu, Aug 05, 2021 at 09:46:07AM -0600, Simon Glass wrote:

> Hi Heinrich,
>
> On Thu, 5 Aug 2021 at 09:29, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> >
> >
> >
> > On 02.08.21 16:44, Simon Glass wrote:
> > > The changes to move from devicetree to rodata take things in the wrong
> > > direction for various reasons:
> > >
> > > - devicetree is where config should be stored
> >
> > We are not talking about configuration here at all.
>
> I thought we were talking about the public key. That is run-time
> config in my book, just like the devicetree itself, which controls all
> the devices.
>
> >
> > > - it provides no memory production in any case, particularly when U-Boot
> >
> > No clue what you mean by "memory production".
>
> memory protection. But it turns out this is pointless anyway. We
> discussed it at length in the contributor call. We came down to one
> issue with the way the firmware is packaged by users (with U-Boot
> coming from one place and TF-A another). I think Ilias is going to
> write something up to help get to the bottom of it.
>
> >
> > > is relocated
> > > - testing becomes harder, with the suggestion of adding an entire new
> > > sandbox build just for this
> >
> > Having an extra config is not required when putting the certificate into
> > .rodata.
>
> The certificate should not go in rodata, period. Please just fix it.
> It use to be fine a few weeks ago so it should not be hard.

Where are we at here, Heinrich? Thanks.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]