Re: [PATCH v2 0/3] efi: Minimal revert to rodata change

Simon Glass
2021-08-03T15:27:50Z

HI Ilias,

On Mon, 2 Aug 2021 at 23:43, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> On Mon, Aug 02, 2021 at 02:02:56PM -0600, Simon Glass wrote:
> > Hi Ilias,
> >
> > On Mon, 2 Aug 2021 at 09:37, Ilias Apalodimas
> > <ilias.apalodimas@linaro.org> wrote:
> > >
> > > Hi Simon,
> > >
> > > On Mon, Aug 02, 2021 at 08:44:28AM -0600, Simon Glass wrote:
> > > > The changes to move from devicetree to rodata take things in the wrong
> > > > direction for various reasons:
> > > >
> > >
> > > As I said on the previous thread, I think this should remain as is for a
> > > number of reasons (and mainly because it only works with 1/3 valid
> > > CONFIG_OF_XXX U-Boot provides), but I'll let Heinrich decide.
> >
> > Do you mean OF_EMBED and OF_HOSTFILE?
> >
> > We happily use OF_HOSTFILE in the sandbox vboot tests. I don't see any
> > issue there.
> >
> > OF_EMBED should not be used in production code. It is for debugging only.
>
> No I mean CONFIG_OF_SEPARATE and CONFIG_OF_PRIOR_STAGE (apart from
> CONFIG_OF_BOARD)

Well OF_SEPARATE works fine.

OF_PRIOR_STAGE is no different, as I understand it. I just means that
the prior stage (whatever that is) needs to have the public key.

Regards,
Simon