From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC54EC4338F for ; Tue, 3 Aug 2021 09:05:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D36D960F8F for ; Tue, 3 Aug 2021 09:05:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D36D960F8F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4CD8D82BE5; Tue, 3 Aug 2021 11:05:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id F1A2D82D9C; Tue, 3 Aug 2021 11:05:13 +0200 (CEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4A68E80C58 for ; Tue, 3 Aug 2021 11:05:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clement.leger@bootlin.com Received: (Authenticated sender: clement.leger@bootlin.com) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id 7C1CB1BF20D; Tue, 3 Aug 2021 09:05:09 +0000 (UTC) Date: Tue, 3 Aug 2021 11:05:08 +0200 From: =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= To: Cc: , , Subject: Re: [PATCH 3/5] ARM: dts: at91: sama5d2: Add memory node in devicetree Message-ID: <20210803110508.7f9d7c31@fixe.home> In-Reply-To: <51d58398-3442-e208-b8d9-ec2dc8d53d4f@microchip.com> References: <20210802123952.36826-1-clement.leger@bootlin.com> <20210802123952.36826-4-clement.leger@bootlin.com> <51d58398-3442-e208-b8d9-ec2dc8d53d4f@microchip.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Le Tue, 3 Aug 2021 08:58:17 +0000, a =C3=A9crit : > On 8/2/21 3:39 PM, Cl=C3=A9ment L=C3=A9ger wrote: > > sama5d2 support from DRAM will be modified to use device tree > > instead of hardcoded addresses. In order to prepare that, add the > > memory node to sama5d2.dtsi file since the boards supported by > > U-Boot with sama5d2 all contains 512Mb of DDR. > >=20 > > Signed-off-by: Cl=C3=A9ment L=C3=A9ger > > --- > > arch/arm/dts/sama5d2.dtsi | 4 ++++ > > 1 file changed, 4 insertions(+) > >=20 > > diff --git a/arch/arm/dts/sama5d2.dtsi b/arch/arm/dts/sama5d2.dtsi > > index 6fb2cb25f9..299aefc496 100644 > > --- a/arch/arm/dts/sama5d2.dtsi > > +++ b/arch/arm/dts/sama5d2.dtsi > > @@ -4,6 +4,10 @@ > > model =3D "Atmel SAMA5D2 family SoC"; > > compatible =3D "atmel,sama5d2"; > >=20 > > + memory { > > + reg =3D <0x20000000 0x20000000>; > > + }; =20 >=20 > Hi, >=20 > Memory is external to the SoC. You have to move this node to the > board specific DTS. Ok, I'll move this to sama5d2_xplained only since this series has been made and tested on sama5d2_xplained/sama5d27_som1_ek. Cl=C3=A9ment >=20 > Even if all current boards have 512 MB of DRAM , this does not belong > here. >=20 > And by the way this is not true, since this SoC can work in a SiP > with only 256 or 128 MB of DRAM for example and this is true for > certain boards ( wlsom1_ek comes to my mind now). >=20 > Eugen >=20 > > + > > aliases { > > spi0 =3D &spi0; > > spi1 =3D &qspi0; > > -- > > 2.32.0 > > =20 >=20 --=20 Cl=C3=A9ment L=C3=A9ger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com