From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59B05C4338F for ; Wed, 4 Aug 2021 12:44:27 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44F69601FD for ; Wed, 4 Aug 2021 12:44:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 44F69601FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C33C882EA6; Wed, 4 Aug 2021 14:44:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qczDEk/3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B08FF82EB9; Wed, 4 Aug 2021 14:44:21 +0200 (CEST) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 731CF82E1E for ; Wed, 4 Aug 2021 14:44:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf34.google.com with SMTP id s11so994753qvz.7 for ; Wed, 04 Aug 2021 05:44:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ircmym0p0mMvzfCbFtQVdd9EkGsLANSCHykEurfxKZk=; b=qczDEk/3zLBrtc60vyNyNpesIn5X7g9SG95JVv+Ih2jF23SsHi5WD5Rhn55OSfORRT vAtBIIa3kvqaifzxVZP2CRnO7evhEltPXZdSzqgVbWGIgSn6PJQ6pUtdWbiqLvMuser6 e9FoDcNZ1VlEBRvBQKVsLwMljF0c3PYaWgtpE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ircmym0p0mMvzfCbFtQVdd9EkGsLANSCHykEurfxKZk=; b=ucvrdz6QDczCf+7Rufb1SKJYFYmH2qEcb4kA4hvqBYH4IN6+bQqcZLL8mpeD9Mb7sJ 1iUxOZuukXqYKYdvPE72XzZ9N9LqdISXvZSWOBUl9qhnDmrVSzrtIgJ8LR25pWVVbWfn AIIIMpJmzgvcq4QZ1WCbVvlgQOoAl5fSIvLzD05Y70s1ZRi8By2vJeVSXImcTVW04vOg Zgn2GnCoXGBJRTlPlbCDOn2KNYXb/DqcZCGVW79ScagZjhdRblHGWbNm0Pa5QSuhq7rr POM1hGUhME5PuALRpStS2jo6boe9jBAGIn+hYDwELcoDmaDSI4wsbESjqRcvQMtMrVeR gKrQ== X-Gm-Message-State: AOAM533DQzj9zNv5BSRbizXYigJkoUG2x/VVVCNO9UX1jg4tdUT37WVd rDi6TKOSOLGlTTBbMH1tSgZVLg== X-Google-Smtp-Source: ABdhPJyFyPQNbcImo+w8nJJ6eJdBssvbD8d58qHrDUBqaTj3jI1CVghmz79HKfsEZs8RFsi8z0Vh0A== X-Received: by 2002:a0c:be8e:: with SMTP id n14mr26412975qvi.16.1628081057233; Wed, 04 Aug 2021 05:44:17 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f4c0-9925-e569-04c6.res6.spectrum.com. [2603:6081:7b01:cbda:f4c0:9925:e569:4c6]) by smtp.gmail.com with ESMTPSA id a131sm687306qkc.105.2021.08.04.05.44.15 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Aug 2021 05:44:16 -0700 (PDT) Date: Wed, 4 Aug 2021 08:44:13 -0400 From: Tom Rini To: Wolfgang Denk Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?iso-8859-1?Q?Beh=FAn?= , U-Boot Mailing List Subject: Re: [PATCH 11/11] Remove including timestamp.h in version.h Message-ID: <20210804124413.GZ9379@bill-the-cat> References: <20210802131838.21097-1-pali@kernel.org> <20210802131838.21097-12-pali@kernel.org> <20210802194223.5myvz6l27rjkfrld@pali> <20210802213100.GG9379@bill-the-cat> <128122.1628056761@gemini.denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/zqQk/GhLgZoaxVr" Content-Disposition: inline In-Reply-To: <128122.1628056761@gemini.denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --/zqQk/GhLgZoaxVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 04, 2021 at 07:59:21AM +0200, Wolfgang Denk wrote: > Dear Tom, >=20 > In message <20210802213100.GG9379@bill-the-cat> you wrote: > >=20 > > I think that if nothing changes the banner not changing is the right > > behavior. >=20 > Hm... is it? How about "external" changes like building with a > different tool chain? Then at least the "version" command should > produce a corresponding output, which means some parts _have_ to be > recompiled, resulting in a new banner, too ? There's some misunderstanding about what this series does, and does not do. First, with the series applied and you don't force SOURCE_DATE_EPOCH, and you run make, and you re-run make, cmd/version.c is rebuilt (but only that and not a bunch of other things anymore) and the banner timestamp changes. Second, if you do set SOURCE_DATE_EPOCH to a fixed value (so you're trying to reproduce a build with a specific timestamp) AND re-run make, nothing changes, as it should. Third, if you change gcc, everything gets rebuilt including cmd/version.c and a new banner. --=20 Tom --/zqQk/GhLgZoaxVr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEKi5oACgkQFHw5/5Y0 tyyCKQv/ZhGEjESqiQIiv0X2LZdP2+EJlpXzl1vBVngZpytuDl1aqgXz2ROTVQcD onE8Jn5+jRKo1q/nfhGEtF+BYnuI/vDxzOfnEY5NRxkZEnKf415eekitUisA4IjI cwSJC+dZtchMvv7/1xxnJLSbHLYljxObpiafsm0Ta7IxNDTRi2u/V+elzUiHXeId NdpHvDegeoo/TWtr5bqlu75CCD2hAFQnp5z1G4ptWuMk4Gxa5qoJNupsQfakTbFg iQuEq8ABwI0bHODcF8RviTZwgju8XpEI0qfrmDANPhFsa5Skiyv8Ia7sE+H+bjqO j0OfJOboh4RMdMMQZwg+y1ebzNfaHb+vjZc5mBGlCnsJA1XDSB1sbpkhDjAWP91Q soYSq8eLjsJausdAKKf6HVxJcyWsluOOGc51mA8WSacW90sEgLCtOB6HvJRehvBm gVvsh8EaRmw4t5QrCkEcnc1CVZpAeggix8ws7AVk3eDtrdlmNlHzEDo/fbabGS8/ Xv+DylrH =9XgE -----END PGP SIGNATURE----- --/zqQk/GhLgZoaxVr--