From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC237C4320A for ; Thu, 5 Aug 2021 23:31:16 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFEA860EBC for ; Thu, 5 Aug 2021 23:31:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BFEA860EBC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 78D1482BC4; Fri, 6 Aug 2021 01:31:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="fSmqnpnH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C3B8982C8B; Fri, 6 Aug 2021 01:31:10 +0200 (CEST) Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3F6F980FC5 for ; Fri, 6 Aug 2021 01:31:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72e.google.com with SMTP id f12so6934375qkh.10 for ; Thu, 05 Aug 2021 16:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZAIKRc6Ll3XXodcPn3fh/uh1TjRuFIHNO+L4ATd/ZoY=; b=fSmqnpnHOP5sIm7EQr5nUQf1uDXgHVGg0+8Dc0Y29C+nJxn+0Oh3M/YX0LXoue9XtC btDta4uFFoDxsp7SzkN2bJJ2rLRwGQ9CM/h8LaTaasEmSAyGS/XwuZeQwqnqnY/RCRS4 8DFnXTdNZX8S6bfheuKylYXvZMUgw3cDMMsAo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZAIKRc6Ll3XXodcPn3fh/uh1TjRuFIHNO+L4ATd/ZoY=; b=gvFVfODn7n0MOZb40eSGBlyxaoJuVVKnHpS6chIDnp++2GiQlLTYIj4g2tcLZG/F29 hrdo7Onk5Iq67fJQmmMhNljjie+QKh5dKYlVNeXjv/oPkjwJ2SI0UEosl+e9CtyIfuUy sNMjTV5tnYL/Bf5NcLWzR+HfXhk3mE9YQZqr5w67+r5fBeZDEIhbPPWL6JmposlknnA7 Y+75oWZCMlaUEwlH8Yt2EOrhMdlW8Wh1eiM04bNx7fo/Cwtb+wqyPrMEyk/CpVeLrFdZ 7GhKZ1BpuIRkxBVpovvpzM6Z9IHZjG5d1Vh3mLWuGhMj4ypGJsIYO5rtDGScBc+FvXhE HMzA== X-Gm-Message-State: AOAM531eYGaAMtq1cYme3q6FQ/d5WIn1d2K7QzPGrfw5BH9gO/0yoDMc 2WT5NVHki5z9ZPGeMersaDV/5Q== X-Google-Smtp-Source: ABdhPJxU//ZNUKtrQVoj2pCH6OnXNAZO7ZWz+8UEtDlplSpIREYV1Zpg0e0FvYCmRYe4vJ7szQ0doQ== X-Received: by 2002:ae9:e002:: with SMTP id m2mr7512082qkk.474.1628206266070; Thu, 05 Aug 2021 16:31:06 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-91f5-8795-37c3-31a0.res6.spectrum.com. [2603:6081:7b01:cbda:91f5:8795:37c3:31a0]) by smtp.gmail.com with ESMTPSA id a20sm2756522qta.78.2021.08.05.16.31.04 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Aug 2021 16:31:05 -0700 (PDT) Date: Thu, 5 Aug 2021 19:31:03 -0400 From: Tom Rini To: Marek Vasut Cc: Jan Kiszka , U-Boot Mailing List , Hai Pham , Simon Goldschmidt , Stephen Warren , Lokesh Vutla Subject: Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64" Message-ID: <20210805233103.GS858@bill-the-cat> References: <1971775f-28de-83d0-9459-a4e68c744a18@siemens.com> <20210729152307.GP9379@bill-the-cat> <20210729165802.GA9379@bill-the-cat> <446b4861-6987-092a-43ce-5d3aa322f8f3@denx.de> <20210802130008.GR9379@bill-the-cat> <4046119c-c61c-ed49-92e6-dee5f8c67b3c@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HywJcj55HbA57jnN" Content-Disposition: inline In-Reply-To: <4046119c-c61c-ed49-92e6-dee5f8c67b3c@denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --HywJcj55HbA57jnN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 05, 2021 at 11:53:24PM +0200, Marek Vasut wrote: > On 8/2/21 3:00 PM, Tom Rini wrote: > > On Mon, Aug 02, 2021 at 02:54:22AM +0200, Marek Vasut wrote: > > > On 7/29/21 6:58 PM, Tom Rini wrote: > > >=20 > > > [...] > > >=20 > > > > > > so when did rcar3 introduce something there that shouldn't be > > > > > > reserved? And you had phrased this to me on IRC as about reser= ving spot > > > > > > for ATAGS, and that not being needed of course on arm64. But t= hat's not > > > > > > what's going on. Perhaps the answer is that rcar3 needs to int= roduce a > > > > > > board_lmb_reserve to free the normal arch one and provide whate= ver more > > > > > > narrow scope it needs. > > > > >=20 > > > > > Based on the commit message 2359fa7a878 ("arm: bootm: Disable LMB > > > > > reservation for command line and board info on arm64") , this is = about ATAGS > > > > > and we really don't need to reserve those on arm64. > > > >=20 > > > > Commit 2359fa7a878 disables the entire arch_lmb_reserve function on > > > > aarch64, yes. I assumed when we had talked that it was a small area > > > > being set aside and perhaps mis-recalled that ATAGS tended to live = at > > > > DDR_BASE + 0x800 or so. > > >=20 > > > That arch_lmb_reserve() is responsible for reserving architecture spe= cific > > > memory. On arm32 it is ATAGS, on arm64 it is nothing as far as I can = tell > > > (and see below regarding the TLB). > >=20 > > I don't think that LMB ever covered ATAGS. ATAGS, I could have sworn, > > were at start of memory + 0x800 or so. This LMB is for the top of > > memory where U-Boot is. >=20 > What is there to protect which Linux does not set up again ? What does Linux have to do this with? I don't see, but maybe have missed, where "U-Boot adds memory region to internal LMB list" is translated to "Update the device tree Linux will have with these regions". I do see code to read the reserved-memory regions from a DTB and add them to our LMB, but not the other direction. --=20 Tom --HywJcj55HbA57jnN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEMdLMACgkQFHw5/5Y0 tyzvcAwArG6KxwKQygWMTVoV2sSuAkw/nDjPQ/YCiO1KD1kNIZ+JFHnqaFbUQBWl Eoy3Gk9aHjpsBFnHNr6s+l8NtVtMyyaK5kVypXYQUC9fMOMi/IeoXosNyJP846JG eYX/3bwblw7HojU9CpjAIQnzEkjWF/69DADcHCkSazNZOzN6HrhRhNsqZouTbXXb wgDR8pomgRHEW0X519Gh83kc5dmjXNSCCL3Uebzhy1nJ6i8Bz7YDs2lxlpux00Ni 1r0sVmQCYZrv7zqB2h1jcMI4U50nctAbozvrElwS3JnHEnIUWAzYRS85glZCO4uK AoyMRFVLlLMV9t1xt3iuMulZifFvi263dnh+apm+jA6X99MTw1EQ1E6C0oO7ZIDB Y1x2CJY5saG8IAGJRbbBHUu6opkmt/xB3WCsab5R1Vj3qGj4P8lajTtCFl1sx88Q JWQhzu+sQYlnCCJVG1kXMnyzqJs8aX7f5VJcKVoJQ5XUTLzkjXJLZUF4TTIkeCEd UhXtXGYF =GvQM -----END PGP SIGNATURE----- --HywJcj55HbA57jnN--