Re: [PATCH v2 0/3] efi: Minimal revert to rodata change\

Simon Glass
2021-08-03T15:27:25Z

Hi Ilias,

On Mon, 2 Aug 2021 at 23:46, Ilias Apalodimas
<ilias.apalodimas@linaro.org> wrote:
>
> On Mon, Aug 02, 2021 at 01:22:18PM -0600, Simon Glass wrote:
> > Hi Heinrich,
> >
> > On Mon, 2 Aug 2021 at 11:35, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
> > >
> > >
> > >
> > > On 8/2/21 4:44 PM, Simon Glass wrote:
> > > > The changes to move from devicetree to rodata take things in the wrong
> > > > direction for various reasons:
> > > >
> > > > - devicetree is where config should be stored
> > >
> > > We are not talking about configuration here but about bundling a file.
> > >
> > > > - it provides no memory production in any case, particularly when U-Boot
> > >
> > > What do you mean by "production"?
> > >
> > > Should you mean memory protection: I cannot see that the memory pages
> > > containing the devicetree are set to readonly. Furthermore setenv can
> >
> > Did you read the discussion? Neither can rodata, so this is a pointless change.
> >
>
> It's far from pointless imho. In that same discussion I pointed out that the
> DTB might need to remain r/w for it's entire lifetime, while .rodata is
> just a matter of missing code to switch pages to RO-.

We don't support a r/w control DTB in U-Boot. At present any attempt
to update the DTB will cause devices to fail to probe since the
offsets they point to will be incorrect. If r/w is desired, I think
OF_LIVE is the only reasonable option.

So I think that point is moot also.

[..]

Regards,
SImon