public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de, Stefano Babic <sbabic@denx.de>
Cc: "Tim Harvey" <tharvey@gateworks.com>,
	"Heiko Schocher" <hs@denx.de>,
	"Alexandru Gagniuc" <mr.nuke.me@gmail.com>,
	"Fabio Estevam" <festevam@gmail.com>,
	"Faiz Abbas" <faiz_abbas@ti.com>,
	"Jaehoon Chung" <jh80.chung@samsung.com>,
	"Marek Vasut" <marex@denx.de>, "Michael Walle" <michael@walle.cc>,
	"Michal Simek" <michal.simek@xilinx.com>,
	"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
	"Pali Rohár" <pali@kernel.org>,
	"Philippe Reynes" <philippe.reynes@softathome.com>,
	"Simon Glass" <sjg@chromium.org>, "Stefan Roese" <sr@denx.de>,
	"Teresa Remmet" <t.remmet@phytec.de>
Subject: [PATCH v1 0/2] imx8m: fix secure boot
Date: Fri,  6 Aug 2021 06:44:25 +0200	[thread overview]
Message-ID: <20210806044427.1958686-1-hs@denx.de> (raw)


This series fixes secure boot on imx8m based boards. Tim
also detected this issue and the patches fixed on his hardware
also the problem, see discussion here:

https://lists.denx.de/pipermail/u-boot/2021-July/454351.html

Problem is that the IVT header gets loaded to a memallocated
buffer, but it needs to sit on memaddress coded in IVT header
itself. This patchseries adds a weak function spl_load_simple_fit()
in common spl code, which does not change current code behaviour.

Second patch than implements this weak function for imx based
boards (if no IVT header is found on address which is passed
to it, it does nothing).

I am not sure if this is the best solution, but it fixes a real
bug, and may could be made clearer, if possible.


Heiko Schocher (2):
  spl_fit. add hook to make fixes after fit header is loaded
  imx: spl: implement spl_load_simple_fit_fix_load

 arch/arm/mach-imx/spl.c | 33 +++++++++++++++++++++++++++++++++
 common/spl/spl_fit.c    | 11 +++++++++++
 include/spl.h           |  8 ++++++++
 3 files changed, 52 insertions(+)

-- 
2.31.1


             reply	other threads:[~2021-08-06  4:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06  4:44 Heiko Schocher [this message]
2021-08-06  4:44 ` [PATCH v1 1/2] spl_fit. add hook to make fixes after fit header is loaded Heiko Schocher
2021-09-30  4:09   ` Simon Glass
2021-10-07 14:13   ` sbabic
2021-08-06  4:44 ` [PATCH v1 2/2] imx: spl: implement spl_load_simple_fit_fix_load Heiko Schocher
2021-10-07 14:12   ` sbabic
2021-08-06  5:56 ` [PATCH v1 0/2] imx8m: fix secure boot Peng Fan (OSS)
2021-08-06  6:39   ` Heiko Schocher
2021-08-06  7:16     ` [EXT] " Ye Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210806044427.1958686-1-hs@denx.de \
    --to=hs@denx.de \
    --cc=faiz_abbas@ti.com \
    --cc=festevam@gmail.com \
    --cc=jh80.chung@samsung.com \
    --cc=marex@denx.de \
    --cc=michael@walle.cc \
    --cc=michal.simek@xilinx.com \
    --cc=mr.nuke.me@gmail.com \
    --cc=pali@kernel.org \
    --cc=philippe.reynes@softathome.com \
    --cc=sbabic@denx.de \
    --cc=sjg@chromium.org \
    --cc=sr@denx.de \
    --cc=t.remmet@phytec.de \
    --cc=tharvey@gateworks.com \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox