From: Tom Rini <trini@konsulko.com>
To: Stefan Roese <sr@denx.de>
Cc: u-boot@lists.denx.de, sjg@chromium.org
Subject: Re: [PATCH v1 4/5] arm64: arch/arm/lib: Add optimized memset/memcpy functions
Date: Fri, 6 Aug 2021 10:43:43 -0400 [thread overview]
Message-ID: <20210806144343.GY858@bill-the-cat> (raw)
In-Reply-To: <20210806133843.3642916-5-sr@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1044 bytes --]
On Fri, Aug 06, 2021 at 03:38:42PM +0200, Stefan Roese wrote:
> Ported from https://github.com/ARM-software/optimized-routines
>
> Please note that when adding these optimized functions as default memset
> memcpy functions in U-Boot, U-Boot fails to boot on the LX2160ARDB.
> After the initial ATF output, no U-Boot output is shown on the serial
> console. Some exception is triggered here in the very early boot process
> as some of the assembler opcodes need the caches to be enabled.
>
> Because of this, some additional patches will introduce memset_simple()
> which will be used in some selected code location.
>
> Note:
> I also integrated and tested with the Linux versions of these optimized
> functions. They are similar to the ones now integrated but these ARM
> versions are still a small bit faster.
Ah, so here's why you didn't use the kernel versions. Do the kernel
versions still have the cache issue? Also, this should be reworded a
bit since you did introduce memset_simple before here.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-08-06 14:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 13:38 [PATCH v1 0/5] arm64: Add optimized memset/memcpy functions Stefan Roese
2021-08-06 13:38 ` [PATCH v1 1/5] lib/string: Add memset_simple() Stefan Roese
2021-08-06 15:36 ` Wolfgang Denk
2021-08-06 16:13 ` Heinrich Schuchardt
2021-08-07 15:18 ` Wolfgang Denk
2021-08-07 15:34 ` Tom Rini
2021-08-06 13:38 ` [PATCH v1 2/5] board_init: Use memset_simple() in board_init_f_init_reserve() Stefan Roese
2021-08-09 7:52 ` Rasmus Villemoes
2021-08-09 13:17 ` Stefan Roese
2021-08-06 13:38 ` [PATCH v1 3/5] arm64: cache_v8: Use memset_simple() in create_table() Stefan Roese
2021-08-06 13:38 ` [PATCH v1 4/5] arm64: arch/arm/lib: Add optimized memset/memcpy functions Stefan Roese
2021-08-06 14:43 ` Tom Rini [this message]
2021-08-06 14:45 ` Stefan Roese
2021-08-06 15:41 ` Wolfgang Denk
2021-08-06 13:38 ` [PATCH v1 5/5] arm64: Kconfig: Enable usage of optimized memset/memcpy Stefan Roese
2021-08-06 14:24 ` [PATCH v1 0/5] arm64: Add optimized memset/memcpy functions Tom Rini
2021-08-06 14:44 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806144343.GY858@bill-the-cat \
--to=trini@konsulko.com \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox