From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 327D6C4338F for ; Wed, 11 Aug 2021 14:17:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19BBD6101E for ; Wed, 11 Aug 2021 14:17:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 19BBD6101E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 362BA82D90; Wed, 11 Aug 2021 16:17:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="MPvXMldu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 41B7A82CDC; Wed, 11 Aug 2021 16:17:16 +0200 (CEST) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3432982CDC for ; Wed, 11 Aug 2021 16:17:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2c.google.com with SMTP id v1so1196513qva.7 for ; Wed, 11 Aug 2021 07:17:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/vyDOhISj+Y8uYO3H7YZ48pmgDkwEkacntwHirsRuhY=; b=MPvXMldubw9WQUyRkhaKqbthlphNtckCPsObxs9JDpKCj+HMZxZFHqvh6CKtVAKkmU EYTQvg3dt4s60BR+AIH6uMf80wf2qo9jbDOvNbWrOB4u9ApqEAfx2GC3/JourADYRFwm l4l0FwHWmMTREUVF2FWO1hK/4rRTMMLe2Zt18= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/vyDOhISj+Y8uYO3H7YZ48pmgDkwEkacntwHirsRuhY=; b=dzZya1GGFKNNRYhmNjOK0r0ndc4oxZyP+yojJY1abmXheOjUi1lhFq8rjhgXTiA23p /QAHVcNADR03Tb5PHKpnOo01lw5YXHBHgWLzCH7Ed4XxZKFtYZDs5qZeXXTh7LnDltDK 56duRrAos4+kiEPuaRr+7YybN4uZjpoTCzHItx0bGcU374fYLvwIdlP+oZqVRG0YXn9k Q7/BPi8Ym2N3dWXENSVF7BNmhch5mCnA5TdpP6bp2RWIFQ2gjlM2QM3mViLd2bvekvoH PY+zyqhMI73/wkbMkZ4hHQvjIpYas4mozl3oMX9IMeJAXyGPCDEwywdxOuUYvx55PMPF AE4A== X-Gm-Message-State: AOAM533aDP6Y21pBi8T3bCYx/t6U2joS/NLaJ5pZSqMU4BS9T/W8s28E Zsdl/StD/FmFUKkMc7mRvVPVGw== X-Google-Smtp-Source: ABdhPJxwkWa7/urRIImLXt2GZ6Qbjc4qKzXSZ6ZpSsdsrNpj4yKQ6+OSUTUySDVN4PhXe2xYnejXyw== X-Received: by 2002:a05:6214:902:: with SMTP id dj2mr33646270qvb.23.1628691429849; Wed, 11 Aug 2021 07:17:09 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-2899-f679-6391-9304.res6.spectrum.com. [2603:6081:7b01:cbda:2899:f679:6391:9304]) by smtp.gmail.com with ESMTPSA id l4sm12854878qkd.77.2021.08.11.07.17.08 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Aug 2021 07:17:09 -0700 (PDT) Date: Wed, 11 Aug 2021 10:17:06 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Marek Vasut , Masahiro Yamada , Heinrich Schuchardt , Bin Meng , Stefan Roese , Marek =?iso-8859-1?Q?Beh=FAn?= , Sean Anderson , Aaron Williams Subject: Re: RFC: Support for U-Boot phases in Kconfig Message-ID: <20210811141706.GY858@bill-the-cat> References: <20210809191111.GD858@bill-the-cat> <20210810193809.GL858@bill-the-cat> <20210811134732.GV858@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZYwTRRUThkGj9JQ7" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --ZYwTRRUThkGj9JQ7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 11, 2021 at 08:03:00AM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Wed, 11 Aug 2021 at 07:47, Tom Rini wrote: > > > > On Wed, Aug 11, 2021 at 06:56:31AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Tue, 10 Aug 2021 at 13:38, Tom Rini wrote: > > [snip] > > > > I need to take another pass at converting a bunch of symbols, to see > > > > where we're at. Probably the biggest chunk of progress next would = be to > > > > start converting CONFIG_SYS_xxx to SYS_xxx and moving defines out of > > > > config.h and in to something else. I'm taking a peek at some of the > > > > remaining PCI ones now. > > > > > > How about we set a deadline for this? It has gone on for too long and > > > we just need to drop these CONFIGs. It's probably a higher priority > > > than a Kconfig change. > > > > > > I was expecting that the config.h files would go away and we would use > > > Kconfig (or DT) for everything. What sort of things don't fit into > > > that model? > > > > Environment is the hard one to move out from config.h and in to, well, I >=20 > Well you know my views on that :-) >=20 > http://patchwork.ozlabs.org/project/uboot/patch/1382763695-2849-4-git-sen= d-email-sjg@chromium.org/ >=20 > I still think it makes more sense than #defines and I can resurrect > that series if you like. That might work, yeah. I just also want to focus on less things in progress at once. That too I think has been part of why everything is taking so long. > > don't know what. I think there's also a handful of symbols like > > CONFIG_SPL_MAX_SIZE that are a little tricky to convert directly (they > > do math based on other symbols) rather than just as evaluate-and-set. >=20 > We can either evaluate them and put the answer in as the defconfig > value...or perhaps ask Masahiro to support evaluation in kconfig?! I do forget what kind of operations are allowed in Kconfig at this point, it might be possible now, yes. And if not, something worth trying. > > Right now, a little more than half of the unmigrated symbols are > > CONFIG_SYS_xxx things and those likely should become SYS_xxx things. Of > > the ones that don't just go away. >=20 > Do you mean things like this? >=20 > arch/m68k/include/asm/immap.h:#define CONFIG_SYS_PCI_BAR0 > (0x40000000) >=20 > Assuming this doesn't move to devicetree, it should be in its own asm/ > or asm/arch header file I think, not in the config.h file at all. >=20 > FSL layerscape should move CONFIG_SYS_PCIE3_PHYS_SIZE et al to devcetree. I started and set aside *PCI* since a bunch of that goes away once UCP1020 gets updated. But yes, there are lots of CONFIG_SYS_xxx things that live inside and outside of config.h and step one is likely a simple regex. They aren't really configurable. We can try and figure out what "get this from DT" approach makes sense after. > Some of the DM migrations will help - e.g. for I2C. NAND seems to have > a lot - who is the NAND maintainer? There's not currently a NAND maintainer. > But really what I am asking is, can we set a deadline where all > config.h files will be dropped? It has been 7 years... It's going to come down once again to figuring out what to do about older platforms. Since I picked on khadas platforms earlier, here's where meson64.h looks really good. All of the platforms use include/configs/meson64.h and that's very little outside of environment stuff. To go back to another part of the thread, it also shows how hard environment stuff is. It also reminded me that buildman never got kconfiglib support directly and we still have genboardcfg.py to spit out boards.cfg to be parsed by buildman. --=20 Tom --ZYwTRRUThkGj9JQ7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmET298ACgkQFHw5/5Y0 tyzz0Qv/enPXxvf2arlxyBx5I+VJh2DVUOPTnAMRmbBGRwAhePn2qP8PwkWJWD7t I8sJLIddB3c8nFew8dXXpIAr1s1z1i5L8dvuO8WtoJ9/Rxook69W0DwEZsFkYPfl jswJSf8fNumCcjlwYIWrfpnVR6X8w2Ra6NGxVjQmP5Hu/9MGi6PBmLldOAvOzNao cCnCcOy2lItIK19T7u4asKuN1Cr0dTvDcyh+SVs451QA4C9Dxc7N2EcKmTxsZj/p f+uU67TJVGrkZKT+GhivFrUhg+OQezuWgGhUjej+UQ6r/apWk05Bu8ZHTEh04fSy 7xxwO94kfgyXngt/X+QlByWuR25Dml4Qg27juoCj75i2TrHMmgoSCi/JZ3ot47QS SEcdEZ8KVzPt96Rx2esYnXf4yPomUDB6DE36XrnaJFfDpC8BLgb2xTY4Mx6f4DPT fcRjJErT3jJSJDAiswFSsxI0FUA7waq/Nc9NPjCu4ngENbyXmp5phXCSH1SwWcMW wySpiRoD =WNAZ -----END PGP SIGNATURE----- --ZYwTRRUThkGj9JQ7--