From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02285C4338F for ; Wed, 11 Aug 2021 20:42:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EF106105A for ; Wed, 11 Aug 2021 20:42:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1EF106105A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 706B382BD7; Wed, 11 Aug 2021 22:42:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="eRJ6AE4+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8CCFE82BD7; Wed, 11 Aug 2021 22:42:50 +0200 (CEST) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AA6FD82C19 for ; Wed, 11 Aug 2021 22:42:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id w10so3201389qtj.3 for ; Wed, 11 Aug 2021 13:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fuWCzXPUm8XnHkHzWX+YEK3s2tE4R+GWEwo4wVwFFj8=; b=eRJ6AE4+AEN1bMmwEbWx/X9vzPyfjMRLUJezmr2mQFvuDwwL6F0uFVpGatrLt/syMp KjLbOJ+bsL8HXFQuo7zAKJeh+L8+qNr4Fx2qkugOoftLROYSLdMXKQD/Sxp7k7grcL1A vidYMmfDhiRfSy/2fwq+dHJyifWSSC3hKcZHY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fuWCzXPUm8XnHkHzWX+YEK3s2tE4R+GWEwo4wVwFFj8=; b=fITS2ufO8pHcyX3b7Xgyyrnbg5E4EGkXydCRvN64m4yyxL+8cKIZzn4FU8YK35/yVl H5z/rVWfrTYfUvUZbsLiPRBkHai/lOvCMWgxVyy/eU+8LmosKl7wBuRGlxBicLRuIw8M UH11+z+NMtet39ohOJeukv0lquPlH8pEweazfKZ84oVT15pg6AUlyFF4MLEnu3caR+gi m0Rvey/DPfb+G0AlzbIXtBr4FcRbX1yDOkjlLUYc9yietnH1nJA3qdcbUDOZ1tpEdMWK qB8nvLa7sIHXH9z9T78p8hdVTXMB7FMJQb/ZiuF9qRLdUWcq2OIaVqJcUJZ8GsJdx4vl 95ag== X-Gm-Message-State: AOAM533DhGeu53QwFnNHMqdL0MeP1ZHyqU/QIuVohm5RRTEz4k2iXjKH Yb4XKwD3pAjOez1SUBoBdSAf4g== X-Google-Smtp-Source: ABdhPJzxwvEjVNE10/xSpdRcE0xIdrwSxw9IRCaH0Lk64/OBakGgIz5IORYXxxT8zPK74RZQmLPrNA== X-Received: by 2002:ac8:7489:: with SMTP id v9mr570675qtq.9.1628714560082; Wed, 11 Aug 2021 13:42:40 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-ddfe-3f7e-6e5c-2811.res6.spectrum.com. [2603:6081:7b01:cbda:ddfe:3f7e:6e5c:2811]) by smtp.gmail.com with ESMTPSA id w1sm181098qtc.7.2021.08.11.13.42.38 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Aug 2021 13:42:39 -0700 (PDT) Date: Wed, 11 Aug 2021 16:42:36 -0400 From: Tom Rini To: Sean Anderson Cc: Simon Glass , U-Boot Mailing List , Marek Vasut , Masahiro Yamada , Heinrich Schuchardt , Bin Meng , Stefan Roese , Marek =?iso-8859-1?Q?Beh=FAn?= , Sean Anderson , Aaron Williams Subject: Re: RFC: Support for U-Boot phases in Kconfig Message-ID: <20210811204236.GK858@bill-the-cat> References: <20210809191111.GD858@bill-the-cat> <20210810193809.GL858@bill-the-cat> <20210811134732.GV858@bill-the-cat> <20210811141706.GY858@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZMpvc8TwNEttvQ/F" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --ZMpvc8TwNEttvQ/F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 11, 2021 at 04:14:51PM -0400, Sean Anderson wrote: >=20 >=20 > On 8/11/21 10:17 AM, Tom Rini wrote: > > On Wed, Aug 11, 2021 at 08:03:00AM -0600, Simon Glass wrote: > > > Hi Tom, > > >=20 > > > On Wed, 11 Aug 2021 at 07:47, Tom Rini wrote: > > > > > > > > On Wed, Aug 11, 2021 at 06:56:31AM -0600, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Tue, 10 Aug 2021 at 13:38, Tom Rini wrote: > > > > [snip] > > > > > > I need to take another pass at converting a bunch of symbols, t= o see > > > > > > where we're at. Probably the biggest chunk of progress next wo= uld be to > > > > > > start converting CONFIG_SYS_xxx to SYS_xxx and moving defines o= ut of > > > > > > config.h and in to something else. I'm taking a peek at some o= f the > > > > > > remaining PCI ones now. > > > > > > > > > > How about we set a deadline for this? It has gone on for too long= and > > > > > we just need to drop these CONFIGs. It's probably a higher priori= ty > > > > > than a Kconfig change. > > > > > > > > > > I was expecting that the config.h files would go away and we woul= d use > > > > > Kconfig (or DT) for everything. What sort of things don't fit into > > > > > that model? > > > > > > > > Environment is the hard one to move out from config.h and in to, we= ll, I > > >=20 > > > Well you know my views on that :-) > > >=20 > > > http://patchwork.ozlabs.org/project/uboot/patch/1382763695-2849-4-git= -send-email-sjg@chromium.org/ > > >=20 > > > I still think it makes more sense than #defines and I can resurrect > > > that series if you like. >=20 > This would be nice. I was thinking about doing something like this for > LIL, to make writing tests easier. I was thinking of mentioning LIL, even, here. Converting (to start with, just a board or two) that implement distro boot from the current env scheme to another env scheme is going to go quite a ways to showing if the proposed idea is going to be workable enough or not. > > That might work, yeah. I just also want to focus on less things in > > progress at once. That too I think has been part of why everything is > > taking so long. > >=20 > > > > don't know what. I think there's also a handful of symbols like > > > > CONFIG_SPL_MAX_SIZE that are a little tricky to convert directly (t= hey > > > > do math based on other symbols) rather than just as evaluate-and-se= t. > > >=20 > > > We can either evaluate them and put the answer in as the defconfig > > > value...or perhaps ask Masahiro to support evaluation in kconfig?! > >=20 > > I do forget what kind of operations are allowed in Kconfig at this > > point, it might be possible now, yes. And if not, something worth > > trying. >=20 > At the moment there are conditionals for dependencies and defaults [1]. > It doesn't seem like too much of a stretch to allow for arbitrary > arithmetic. In particular, we could really get 80% of the functionality > with just + (and perhaps & or |). >=20 > https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html#menu-= dependencies Yeah, the addition of +- I think really would cover everything that's not "this doesn't belong in CONFIG space really" I think. The only maybe-hangups are that we say for example on TI platforms: #define CONFIG_SPL_MAX_SIZE (SRAM_SCRATCH_SPACE_ADDR - CONFIG_SPL_TEXT_BASE) where SRAM_SCRATCH_SPACE_ADDR isn't a CONFIG symbol, on purpose. But in turn, maybe that means we just want to re-think the symbol and have a choice instead. Some platforms end up being "automatic" size like the above. Other platforms like imx* might be "fixed" size and then define 0x10000 or whatever. It's all the kind of details that come up when picking a symbol and digging in. --=20 Tom --ZMpvc8TwNEttvQ/F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEUNjkACgkQFHw5/5Y0 tyxb9Av9HYYDUbetjarepr3KDEnsttf3nJiafOfbfjM78rSoqz9ILntmLwwUn4Ki qkEBSdIx5Sb8Kepj0+MBA1rXC0JIK4cUGkQ9Ok+DXCB4Q0DU5R/CXl/kvg7ygJGc PBMkSOouSKLbheW/GqVMYxcafumIFu9S4Tnh5zsW59jmjbP0NYzT6Uq20N7zFGrF 1VpcLJZkMp+qLycoilnDKfN7va9Jv+88hFdCoyjyAb1uBb8wNQcTVHbxgqK0kGGU 95ucgtbr5jnUPrbgss7pti1Cv7W9vjQoQIHvCsRW+tLKmPe3fDVW1iLT6L5yCwQ1 VVC71YCyve45YdamnGQR3Kk6zQjx/TY6DQcubDQ4ixVfKVe8ELsCNucsO4gwRqew Tkrdi92b51mCC6cL9FZrDsqxgm0pbERJq3yVIvGgpe8Y2cgc9EUn7f5Kl8q7U9uv 8xURAWaxO+8ohErQzrdcIFOjREnPgScXAyjGHQNae3V3yNS1+ZeDN+V1cZF5lEoq QviQNrn8 =m/GU -----END PGP SIGNATURE----- --ZMpvc8TwNEttvQ/F--