From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: u-boot@lists.denx.de, Marek Vasut <marek.vasut+renesas@gmail.com>,
Simon Glass <sjg@chromium.org>,
Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Subject: Re: [PATCH 03/14] lmb: Always compile arch_lmb_reserve() into U-Boot on arm
Date: Sun, 15 Aug 2021 15:47:30 -0400 [thread overview]
Message-ID: <20210815194730.GO858@bill-the-cat> (raw)
In-Reply-To: <20210815181314.132330-3-marek.vasut+renesas@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On Sun, Aug 15, 2021 at 08:13:03PM +0200, Marek Vasut wrote:
> The arch_lmb_reserve() is called by lib/lmb.c lmb_reserve_common() even
> if CMD_BOOT{I,M,Z} is not enabled. However, the arm32/arm64 variant of
> arch_lmb_reserve() is only compiled in if CMD_BOOT{I,M,Z} is enabled.
>
> This currently does not trigger build error, because there is an empty
> weak implementation of arch_lmb_reserve(), however that is not the
> function that should be used on arm32/arm64.
>
> Fix this by moving the arch_lmb_reserve() implementation into common
> code and always compile it in.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Cc: Tom Rini <trini@konsulko.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-08-15 19:47 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-15 18:13 [PATCH 01/14] configs: Disable LMB and BDI for tools-only Marek Vasut
2021-08-15 18:13 ` [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined Marek Vasut
2021-08-15 19:47 ` Tom Rini
2021-08-29 16:26 ` Marek Vasut
2021-08-29 18:02 ` Tom Rini
2021-08-29 19:24 ` Marek Vasut
2021-08-29 19:32 ` Tom Rini
2021-08-29 21:47 ` Marek Vasut
2021-08-29 22:10 ` Tom Rini
2021-08-29 22:19 ` Marek Vasut
2021-08-29 22:23 ` Tom Rini
2021-08-29 22:40 ` Marek Vasut
2021-08-29 22:51 ` Tom Rini
2021-08-29 23:00 ` Marek Vasut
2021-08-29 23:11 ` Tom Rini
2021-08-30 9:45 ` Marek Vasut
2021-08-30 12:01 ` Tom Rini
2021-09-04 14:03 ` Marek Vasut
2021-09-04 14:10 ` Tom Rini
2021-09-04 15:15 ` Marek Vasut
2021-09-04 15:17 ` Tom Rini
2021-09-04 16:05 ` Marek Vasut
2021-09-04 16:09 ` Tom Rini
2021-09-04 16:49 ` Marek Vasut
2021-09-04 17:01 ` Tom Rini
2021-09-04 19:37 ` Marek Vasut
2021-09-04 19:56 ` Tom Rini
2021-08-15 18:13 ` [PATCH 03/14] lmb: Always compile arch_lmb_reserve() into U-Boot on arm Marek Vasut
2021-08-15 19:47 ` Tom Rini [this message]
2021-08-15 18:13 ` [PATCH 04/14] lmb: Always compile arch_lmb_reserve() into U-Boot on arc Marek Vasut
2021-08-15 18:13 ` [PATCH 05/14] lmb: Add generic arch_lmb_reserve_generic() Marek Vasut
2021-08-15 19:49 ` Tom Rini
2021-08-15 18:13 ` [PATCH 06/14] lmb: Switch to " Marek Vasut
2021-08-15 19:48 ` Tom Rini
2021-08-15 18:13 ` [PATCH 07/14] lmb: nios2: Add arch_lmb_reserve() Marek Vasut
2021-08-15 18:13 ` [PATCH 08/14] lmb: nds32: " Marek Vasut
[not found] ` <HK0PR03MB2994783DDC460B69CDE74093C1CE9@HK0PR03MB2994.apcprd03.prod.outlook.com>
2021-09-02 1:53 ` Rick Chen
2021-08-15 18:13 ` [PATCH 09/14] lmb: riscv: " Marek Vasut
[not found] ` <HK0PR03MB2994629C8CC69189EDF64C00C1CE9@HK0PR03MB2994.apcprd03.prod.outlook.com>
2021-09-02 1:54 ` Rick Chen
2021-08-15 18:13 ` [PATCH 10/14] lmb: sh: " Marek Vasut
2021-08-15 18:13 ` [PATCH 11/14] lmb: xtensa: " Marek Vasut
2021-08-15 18:13 ` [PATCH 12/14] lmb: x86: " Marek Vasut
2021-08-15 18:13 ` [PATCH 13/14] lmb: Mark arch_lmb_reserve() as weak symbol Marek Vasut
2021-08-15 19:50 ` Tom Rini
2021-08-29 16:46 ` Marek Vasut
2021-08-29 18:01 ` Tom Rini
2021-08-15 18:13 ` [PATCH 14/14] lmb: Switch imx board_lmb_reserve() to arch_lmb_reserve() Marek Vasut
2021-08-15 19:47 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210815194730.GO858@bill-the-cat \
--to=trini@konsulko.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=simon.k.r.goldschmidt@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox