From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE544C4338F for ; Wed, 18 Aug 2021 08:03:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6403B60FE6 for ; Wed, 18 Aug 2021 08:03:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6403B60FE6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C2B0C82039; Wed, 18 Aug 2021 10:03:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1629273827; bh=Vk09Nqt7oFULPo21qOqD6gKvMcPrYtiTwOwVc2Z+avQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=HWjZE1OjWsYYiW4xjKycM926WujrYV5rIV2rrikoTTXj3F6WR0vkzcBfrXkTSDU8b IAwJbeSpepeAegAVhFshsARpgoUS1nc0Xwi1h8gbDxIUMZ7jVUQoTBjf4ZsXzuYXpV Dbq3G6CDToKZ3Cwc1Slz3uJ/5i79+zCZmay1DbMEfhezTDOlpvygxnv9PvpoFTkJPk g6LuR+K/FwNlyJNNafJCTOhiy5HOGnNifkS6O57OvpyFZTkUNAbgtsnM6/BGzpzsuL H0kCP2n+B9MvWv8BBAHsbjM+/QZT/xNz/2KKS+J4gaQc3ltq0xdaQtlN03JbyzUwyh 2DrIXQ6MJe3uw== Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 47D19807F3; Wed, 18 Aug 2021 10:03:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1629273825; bh=Vk09Nqt7oFULPo21qOqD6gKvMcPrYtiTwOwVc2Z+avQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=p4QM08iQ6fWjkxkpAKiNfmtGfxIlQBkNfZTzo3WfmM6NS0S1A3dHMX9zBCRXNnTZp wMiLpxy57xunTfH+mKn0B+UjFGe4s1yDphKeNdf128TEs6ecP5gJtwji4P7MIVRVIh 8NWx4UCJJuRzkr1H4ZUfislBvPLWRzmiwwE8HVC0ZviiV6BsBYASv+SVqWJgF9r7sD lcOsbSb8fd27+huQ18QobStkFlDJCf1Oq04fHzvaUJGXKUCkYnLUJkiZmFjr/ru8LY pKqmJHVFPVffUmmlHCURLqB4mMQtdAZ3UKtTdXdIhL+Ar1fIGnRLeCPp336NfRSOUr SO7q6RGMJ/Mjw== Date: Wed, 18 Aug 2021 10:03:38 +0200 From: Lukasz Majewski To: Tom Rini Cc: u-boot@lists.denx.de Subject: Re: [PATCH 01/13] kp_imx53: Switch to using a local namespace for ID EEPROM Message-ID: <20210818100338.13c68ac4@ktm> In-Reply-To: <20210817220009.22721-2-trini@konsulko.com> References: <20210817220009.22721-1-trini@konsulko.com> <20210817220009.22721-2-trini@konsulko.com> Organization: denx.de X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/Ulo+5w7jSGgk_TgWs1w5a79"; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Sig_/Ulo+5w7jSGgk_TgWs1w5a79 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Tom, > This platform does not use any of the standard EEPROM functionality > and instead provides its own. Use a local namespace for the I2C > related defines to access the EEPROM. >=20 > Cc: Lukasz Majewski > Signed-off-by: Tom Rini > --- > board/k+p/kp_imx53/kp_id_rev.c | 9 ++++++--- > include/configs/kp_imx53.h | 3 --- > 2 files changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/board/k+p/kp_imx53/kp_id_rev.c > b/board/k+p/kp_imx53/kp_id_rev.c index 7103a3e0f2b5..9f93cf008ce8 > 100644 --- a/board/k+p/kp_imx53/kp_id_rev.c > +++ b/board/k+p/kp_imx53/kp_id_rev.c > @@ -64,6 +64,10 @@ void show_eeprom(void) > eth_env_set_enetaddr("ethaddr", p); > } > =20 > +#define I2C_EEPROM_BUS_NUM 1 > +#define I2C_EEPROM_ADDR 0x50 > +#define I2C_EEPROM_ADDR_LEN 2 > + > int read_eeprom(void) > { > struct udevice *dev; > @@ -72,9 +76,8 @@ int read_eeprom(void) > if (eeprom_has_been_read) > return 0; > =20 > - ret =3D i2c_get_chip_for_busnum(CONFIG_SYS_EEPROM_BUS_NUM, > - CONFIG_SYS_I2C_EEPROM_ADDR, > - > CONFIG_SYS_I2C_EEPROM_ADDR_LEN, &dev); > + ret =3D i2c_get_chip_for_busnum(I2C_EEPROM_BUS_NUM, > I2C_EEPROM_ADDR, > + I2C_EEPROM_ADDR_LEN, &dev); > if (ret) { > printf("Cannot find EEPROM !\n"); > return ret; > diff --git a/include/configs/kp_imx53.h b/include/configs/kp_imx53.h > index c94882846efa..87f4841af05c 100644 > --- a/include/configs/kp_imx53.h > +++ b/include/configs/kp_imx53.h > @@ -20,9 +20,6 @@ > #define CONFIG_MXC_USB_FLAGS 0 > =20 > #define CONFIG_SYS_I2C_MXC > -#define CONFIG_SYS_I2C_EEPROM_ADDR 0x50 > -#define CONFIG_SYS_EEPROM_BUS_NUM 1 > -#define CONFIG_SYS_I2C_EEPROM_ADDR_LEN 2 > =20 > /* Command definition */ > #define CONFIG_LOADADDR 0x72000000 /* loadaddr > env var */ Acked-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/Ulo+5w7jSGgk_TgWs1w5a79 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmEcvtoACgkQAR8vZIA0 zr2ZFAgA1JNR4oWfIgFWQKpaVEe0aynZbH/RdqMubIF6N/wpR7ejKA4S3dS99y7F FrBoR72t4VfTZSeZzIHR+XmT0n2emHd6hXHmXKjsaS6+ztoflHPNE/C910K9gqZ7 g+v2Vwn2U3cLbyCj2bk+FMWA+E8Q/fkQVFGnxJp7SPwUc/CcLyASQqvuGPpkuGq3 zbfDRJ25F4UnmJ8An5kybXdVIn6qOuQ1mb/iTE/sQ65qMfrigZ0qKC4DPcWo+zea NxA9/P+F/MxPraMdwvNalcZMjq7/webMMXQoFR1Zv3GlOrOb4AwSHtGuokyMu04Z Qi/lRgMHr7HhJowLUk5XcVPE4EZWsQ== =Jokj -----END PGP SIGNATURE----- --Sig_/Ulo+5w7jSGgk_TgWs1w5a79--