From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Simon Glass <sjg@chromium.org>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Joao Marcos Costa <joaomarcos.costa@bootlin.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 05/11] sqfs: Suppress the message about missing filesystem
Date: Thu, 19 Aug 2021 09:03:50 +0200 [thread overview]
Message-ID: <20210819090350.4a2b153e@xps13> (raw)
In-Reply-To: <20210818214022.5.I3eb71025472bbb050bcf9a0a192dde1b6c07fa7f@changeid>
Hi Simon,
Simon Glass <sjg@chromium.org> wrote on Wed, 18 Aug 2021 21:40:27 -0600:
> This message comes up a lot when scanning filesystems. It suggests to the
> user that there is some sort of error, but in fact there is no reason to
> expect that a particular partition has a sqfs filesystem. Other
> filesystems don't print this error.
>
> Turn it into a debug message.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
>
> fs/squashfs/sqfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/squashfs/sqfs.c b/fs/squashfs/sqfs.c
> index 92ab8ac6310..e2d91c654cd 100644
> --- a/fs/squashfs/sqfs.c
> +++ b/fs/squashfs/sqfs.c
> @@ -1090,7 +1090,7 @@ int sqfs_probe(struct blk_desc *fs_dev_desc, struct disk_partition *fs_partition
>
> /* Make sure it has a valid SquashFS magic number*/
> if (get_unaligned_le32(&sblk->s_magic) != SQFS_MAGIC_NUMBER) {
> - printf("Bad magic number for SquashFS image.\n");
> + debug("Bad magic number for SquashFS image.\n");
> ret = -EINVAL;
> goto error;
> }
Thanks,
Miquèl
next prev parent reply other threads:[~2021-08-19 7:04 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 3:40 [PATCH 00/11] sandbox: Minor fixes and improvements Simon Glass
2021-08-19 3:40 ` [PATCH 01/11] dtoc: Further improve documentation about warnings Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 02/11] sandbox: Correct handling of --rm_memory Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 03/11] sandbox: Add license headers to the dts files Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 04/11] btrfs: Suppress the message about missing filesystem Simon Glass
2021-08-19 10:31 ` Marek Behún
2021-08-19 10:48 ` Qu Wenruo
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 05/11] sqfs: " Simon Glass
2021-08-19 7:03 ` Miquel Raynal [this message]
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 06/11] test: Tidy a comment in the bloblist test Simon Glass
2021-09-23 2:08 ` Tom Rini
2021-08-19 3:40 ` [PATCH 07/11] dm: core: Fix a few incorrect comments on first/next functions Simon Glass
2021-09-23 2:09 ` Tom Rini
2021-08-19 3:40 ` [PATCH 08/11] sandbox: Add a way to find the size of a file Simon Glass
2021-08-19 10:27 ` Marek Behún
2021-09-23 2:09 ` Tom Rini
2021-08-19 3:40 ` [PATCH 09/11] sandbox: Add a way to map a file into memory Simon Glass
2021-08-19 10:28 ` Marek Behún
2021-09-23 2:09 ` Tom Rini
2021-09-24 2:48 ` Simon Glass
2021-08-19 3:40 ` [PATCH 10/11] sandbox: mmc: Support a backing file Simon Glass
2021-08-28 5:15 ` Jaehoon Chung
2021-08-28 6:39 ` Sean Anderson
2021-09-18 9:34 ` Simon Glass
2021-09-16 18:40 ` Tom Rini
2021-09-18 9:34 ` Simon Glass
2021-09-18 13:16 ` Tom Rini
2021-09-18 16:31 ` Simon Glass
2021-09-20 3:18 ` Simon Glass
2021-10-21 20:17 ` Simon Glass
2021-08-19 3:40 ` [PATCH 11/11] test: Add a way to skip console checking until a string matches Simon Glass
2021-09-23 2:09 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819090350.4a2b153e@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=joaomarcos.costa@bootlin.com \
--cc=sjg@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox