From: Tom Rini <trini@konsulko.com>
To: Wolfgang Denk <wd@denx.de>
Cc: Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
u-boot@lists.denx.de, Simon Glass <sjg@chromium.org>,
Stefan Roese <sr@denx.de>
Subject: Re: [PATCH v6 10/12] watchdog: add gpio watchdog driver
Date: Thu, 19 Aug 2021 08:35:40 -0400 [thread overview]
Message-ID: <20210819123540.GV858@bill-the-cat> (raw)
In-Reply-To: <61767.1629376321@gemini.denx.de>
[-- Attachment #1: Type: text/plain, Size: 1047 bytes --]
On Thu, Aug 19, 2021 at 02:32:01PM +0200, Wolfgang Denk wrote:
> Dear Rasmus,
>
> In message <62540f7b-0e07-8759-8e12-125527c2edec@prevas.dk> you wrote:
> >
> > >> +static int gpio_wdt_reset(struct udevice *dev)
> > >> +{
> > >> + struct gpio_wdt_priv *priv = dev_get_priv(dev);
> > >> +
> > >> + priv->state = !priv->state;
> > >
> > > Potential NULL pointer dereference.
> >
> > No, no and no. If allocation of the (driver or uclass) private data
> > fails, the device probe would have failed, so this code can never get
> > called with such a struct udevice.
>
> Famous last words...
>
> > Perhaps try doing a
> >
> > git grep -10 -E 'dev_get(_uclass)?_priv'
> >
> > and see how many cases you can find where that is followed by a NULL check?
>
> The existence of bad code is not a justification to add more of it.
Since I literally just sent this in another email you couldn't have seen
yet, I'll repeat it here. Feel free to follow up to this with a series
to further update things, Wolfgang.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-08-19 12:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 9:56 [PATCH v6 00/12] handling all DM watchdogs in watchdog_reset() Rasmus Villemoes
2021-08-19 9:56 ` [PATCH v6 01/12] watchdog: wdt-uclass.c: use wdt_start() in wdt_expire_now() Rasmus Villemoes
2021-08-19 9:56 ` [PATCH v6 02/12] watchdog: wdt-uclass.c: introduce struct wdt_priv Rasmus Villemoes
2021-08-19 9:56 ` [PATCH v6 03/12] watchdog: wdt-uclass.c: neaten UCLASS_DRIVER definition Rasmus Villemoes
2021-08-19 9:56 ` [PATCH v6 04/12] watchdog: wdt-uclass.c: refactor initr_watchdog() Rasmus Villemoes
2021-08-19 9:56 ` [PATCH v6 05/12] watchdog: wdt-uclass.c: keep track of each device's running state Rasmus Villemoes
2021-08-19 11:35 ` Wolfgang Denk
2021-08-19 9:57 ` [PATCH v6 06/12] sandbox: disable CONFIG_WATCHDOG_AUTOSTART Rasmus Villemoes
2021-08-19 9:57 ` [PATCH v6 07/12] watchdog: wdt-uclass.c: add wdt_stop_all() helper Rasmus Villemoes
2021-08-19 11:37 ` Wolfgang Denk
2021-08-19 9:57 ` [PATCH v6 08/12] board: x530: switch to wdt_stop_all() Rasmus Villemoes
2021-08-19 9:57 ` [PATCH v6 09/12] watchdog: wdt-uclass.c: handle all DM watchdogs in watchdog_reset() Rasmus Villemoes
2021-08-19 11:43 ` Wolfgang Denk
2021-08-19 9:57 ` [PATCH v6 10/12] watchdog: add gpio watchdog driver Rasmus Villemoes
2021-08-19 11:46 ` Wolfgang Denk
2021-08-19 12:09 ` Rasmus Villemoes
2021-08-19 12:32 ` Wolfgang Denk
2021-08-19 12:35 ` Tom Rini [this message]
2021-08-19 13:03 ` Wolfgang Denk
2021-08-19 13:08 ` Tom Rini
2021-08-19 14:16 ` Wolfgang Denk
2021-08-19 14:44 ` Simon Glass
2021-08-19 14:57 ` Wolfgang Denk
2021-08-20 15:02 ` Simon Glass
2021-08-23 11:07 ` Wolfgang Denk
2021-08-23 17:25 ` Simon Glass
2021-08-20 6:22 ` Rasmus Villemoes
2021-08-20 18:22 ` Simon Glass
2021-08-19 9:57 ` [PATCH v6 11/12] sandbox: add test of wdt_gpio driver Rasmus Villemoes
2021-08-19 9:57 ` [PATCH v6 12/12] sandbox: add test of wdt-uclass' watchdog_reset() Rasmus Villemoes
2021-08-31 8:17 ` Stefan Roese
2021-08-31 9:29 ` Rasmus Villemoes
2021-08-31 12:44 ` Tom Rini
2021-08-31 15:03 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819123540.GV858@bill-the-cat \
--to=trini@konsulko.com \
--cc=rasmus.villemoes@prevas.dk \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox