From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A4A3C4338F for ; Fri, 20 Aug 2021 13:58:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FB2261075 for ; Fri, 20 Aug 2021 13:58:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8FB2261075 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1AEDD82999; Fri, 20 Aug 2021 15:58:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="CPt4bT+w"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1273B82AC8; Fri, 20 Aug 2021 15:58:05 +0200 (CEST) Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 575C980C85 for ; Fri, 20 Aug 2021 15:58:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82d.google.com with SMTP id l24so7522985qtj.4 for ; Fri, 20 Aug 2021 06:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ip13iD4LQAid371lJNaiY4WfZiKkLZcgNJRt1RrOmlA=; b=CPt4bT+ws8H7qJtKM9ydbpyy9ZrDjIPqp/bQiCMiY6XhmQ5AT3kw2ljIFVZ+QKG67M MAxPKLCD4a4WiO2VuEqbJNotM2fOhfbxQfLRhZ3SAuYEheup+1UTfpZLjP/4e3+zDZlP YrYSQR3AdMiSnhYAWVCd7ZMN934XlyfHGA5O0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ip13iD4LQAid371lJNaiY4WfZiKkLZcgNJRt1RrOmlA=; b=O0Olok4YJsUgQZQgkmtFq++rZQ+9jL5+E036QpI+4ZPjcUfZYo0ShvF9gnffzTkYgl D7wjiIZPd6BynYnwUdt50sW8fLU00XdUbdQ5Xx8WPV54FCfjNHZ4pIGfaqdtdUc3GiI2 ldocrNYgnWQMKZO3YrFlwppfQ9EhK8foDPwqUJ1Zwd0AQ+00YSZDYItTaZ6GBwlqGg+V u3wHMdpt/jlkdmJdIYCb2NDsrymhywHxHjFWb1DnPBT1gEw9KeAUGa76M/JjBlFVGXWn ixqoVHvUunqho8GbpgsPSUc6R9byYPXOzOUOWjaN7qBTVgX8dQ3Nj6vOYRZR04HCr4a8 C7CQ== X-Gm-Message-State: AOAM530oPJvUtl2432YRb6p/labARnMBVWiT2mpc920jayImMezpjd6Q jX984XVfMGjd/UdT1H117zM9ew== X-Google-Smtp-Source: ABdhPJz3sJVaAV6cMUgC/q5VeT/BMEX4rt/TDW7Dm9GM5fFRjint1PnRxozF/ifRiT4ukJ4RivrTBg== X-Received: by 2002:ac8:4b64:: with SMTP id g4mr15344945qts.263.1629467879071; Fri, 20 Aug 2021 06:57:59 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-4d9f-af8a-0612-bfbb.res6.spectrum.com. [2603:6081:7b01:cbda:4d9f:af8a:612:bfbb]) by smtp.gmail.com with ESMTPSA id x7sm2372883qtw.24.2021.08.20.06.57.57 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Aug 2021 06:57:58 -0700 (PDT) Date: Fri, 20 Aug 2021 09:57:56 -0400 From: Tom Rini To: Rasmus Villemoes Cc: u-boot@lists.denx.de Subject: Re: [PATCH] global: Remove dead code that starts with CONFIG_[0-9A] Message-ID: <20210820135756.GE858@bill-the-cat> References: <20210819190235.1751-1-trini@konsulko.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HELVWZdadaG0Mvdf" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --HELVWZdadaG0Mvdf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 20, 2021 at 03:01:19PM +0200, Rasmus Villemoes wrote: > On 19/08/2021 21.02, Tom Rini wrote: > > This removes a number of spots of dead code based on symbols that start > > with CONFIG_[0-9] or CONFIG_A. >=20 > How did you find those symbols? I suppose the actual patch is just > generated with unifdef or similar. The entire list is at scripts/config_whitelist.txt and I just used `git grep -Ovim ...` and removed by hand. > > include/configs/vexpress_common.h | 3 - > > 14 files changed, 3 insertions(+), 253 deletions(-) >=20 > Shouldn't they also be removed from scripts/config_whitelist.txt ? I don't bother because there's so many conflicts and it's a generated by scripts/build-whitelist.sh > More generally, running >=20 > for x in $(cat scripts/config_whitelist.txt) ; do git grep -w -q $x -- . > ':!scripts/config_whitelist.txt' || echo $x ; done >=20 > [I'm sure there's a more efficient way...] shows a few symbols that > could be removed from that file, along with the places where they are > set via a CONFIG_SYS_EXTRA_OPTIONS. Yes, finishing the migration of CONFIG_SYS_EXTRA_OPTIONS is also on the list. I'm just running down the list looking for chunks of symbols that hopefully aren't in the categories of: - Abusing tests for CONFIG_SPL_BUILD to set/unset based on SPL build or not. - Sometimes a value, sometimes a function name. - Some other kind of game cpp lets you do, but that's not so easy to move to Kconfig. --=20 Tom --HELVWZdadaG0Mvdf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEftN0ACgkQFHw5/5Y0 tywsewwAstQWTLvkwMyYvGcaFmlLQJJcwnkAnq+OwCssYbgMc2S9XG0bqgf1izxi eI9iBrmmYqZtZjfXLKYgJbmxYAFbQuV8PRvW3I8cKj7rL88uW+SkdMVEttsiK0b3 1+V+foVIEiD9rDGbe60J28bhkBbt7RdlbK17Fy3KuG7Edi9K1X9+UIFv6oiquLvo qqKXWwbA8YKbS9Q6ElAOkLveH3PCg9FvEHV1aAvQFD6nKiHOs33/ZBprq6DPpfI8 WqJw5U/pox3Q1X6vYfzIYr7kkgrzZLVb/RUqDl/+/3tEvtzf/2uW1HRA1F+6zf/x S1P2jdhdO/ZSSWkV0V4djzANM1TZEqVG2HEYdSwjYoiaK/nj+cVWgKAvn+8c0tfi 8agu4kem8lynpIsUi0We/o0V2pp1uDu6BqHl7Aa3VNY4dRw4xqrjHa8ET23LyO4v AeZD3CWH5JlIlE3JOVuU6CESSTPgbbbpDgklYNkt48esAtMN2dIuW1jXYu/3tjCA keruGCAs =7dek -----END PGP SIGNATURE----- --HELVWZdadaG0Mvdf--