public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 2/4] tools: docker: Build and install genimage
Date: Tue, 24 Aug 2021 22:00:41 -0400	[thread overview]
Message-ID: <20210825020041.GN858@bill-the-cat> (raw)
In-Reply-To: <20210825000520.19368-2-bmeng.cn@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1407 bytes --]

On Wed, Aug 25, 2021 at 08:05:18AM +0800, Bin Meng wrote:

> genimage [1] is a tool to create flash/disk images. This is required
> by some targets, e.g.: sifive_unleashed, to generate sdcard or spi-nor
> images for real hardware, as well as U-Boot CI testing.
> 
> [1] https://github.com/pengutronix/genimage
> 
> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> 
>  tools/docker/Dockerfile | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
> index be6d7dd4dc..8e558ca495 100644
> --- a/tools/docker/Dockerfile
> +++ b/tools/docker/Dockerfile
> @@ -60,6 +60,7 @@ RUN apt-get update && apt-get install -y \
>  	iasl \
>  	imagemagick \
>  	iputils-ping \
> +	libconfuse-dev \
>  	libgit2-dev \
>  	libguestfs-tools \
>  	liblz4-tool \
> @@ -172,6 +173,14 @@ RUN git clone https://gitlab.com/lbmeng/qemu.git /tmp/qemu && \
>  	make -j$(nproc) all install && \
>  	rm -rf /tmp/qemu
>  
> +# Build genimage (required by some targets to generate disk images)
> +RUN wget -O - https://github.com/pengutronix/genimage/releases/download/v14/genimage-14.tar.xz | tar -C /opt -xJ && \
> +	cd /opt/genimage-14 && \
> +	./configure && \
> +	make -j$(nproc) && \
> +	make install && \
> +	rm -rf /opt/genimage-14
> +

If we're building, we should do it in /tmp like the rest of the recipe
does.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2021-08-25  2:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  0:05 [PATCH 1/4] tools: docker: Bump up QEMU version to 6.1.0 Bin Meng
2021-08-25  0:05 ` [PATCH 2/4] tools: docker: Build and install genimage Bin Meng
2021-08-25  2:00   ` Tom Rini [this message]
2021-08-25  0:05 ` [PATCH 3/4] riscv: sifive: unleashed: Add genimage config files Bin Meng
2021-08-25  0:05 ` [PATCH 4/4] azure/gitlab: Add tests for SiFive Unleashed board Bin Meng
2021-08-25  2:01 ` [PATCH 1/4] tools: docker: Bump up QEMU version to 6.1.0 Tom Rini
2021-08-25  5:00   ` Bin Meng
2021-08-25 23:04     ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210825020041.GN858@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=bmeng.cn@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox