From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C8A2C432BE for ; Sat, 28 Aug 2021 10:24:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8706460EE4 for ; Sat, 28 Aug 2021 10:24:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8706460EE4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=foundries.io Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9D093832C7; Sat, 28 Aug 2021 12:23:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=foundries.io Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=foundries.io header.i=@foundries.io header.b="NKBzf8zc"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 56781831A0; Sat, 28 Aug 2021 12:23:48 +0200 (CEST) Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 29EDB832F3 for ; Sat, 28 Aug 2021 12:23:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=foundries.io Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=oleksandr.suvorov@foundries.io Received: by mail-lj1-x22f.google.com with SMTP id f2so16227900ljn.1 for ; Sat, 28 Aug 2021 03:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foundries.io; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0E85Rj/EMErILTMgXqbU7G1ubyi4iNkyga4pMktvsek=; b=NKBzf8zcj8Dczs72yzSb0/alvDwOElrc/RYon4rr2+IU5gRm7AGgyu/zR+ddAG2Bqy nNp0jVNjWrfuJ18HzlgC/yDX7hwaIogOXNoNjOcMuMaBTHQSdPSBzKZL7obwvo51wGQ4 IhoKMrJPoJhAKBoMjeZ7SmQTgAnxb+Kv1Gn4t8Xx8Tnee86/2L1npyVMxxSlDB6NKebr u7XUJGbFdz9MnfSq6EnONYeDvtd9jmNhrp1odWdLSOORi5cEAAum3s/hMBrqpbYCknNj BeiwzcFps7BX5O421LE4L2J2qgFpfl0eVgk7FTZTigA0dWaX/+Y5Gjlsr2rnW0QO84Ck mMdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0E85Rj/EMErILTMgXqbU7G1ubyi4iNkyga4pMktvsek=; b=oWM/MnuH9kMiqnfZSUENMGBFpsr2WWOSOVeNjRkRXIxcgZ2LkvwIhL05jisM91g6qa ELxxKWJiNybhqqunkGucE6BX3XVYKsQZ1Zz1fA+cUK1bL4MX7MAxl+A7KUnWcFpy3zND 9N28bUTKMRnhoQZsCxffN/oKHUNIAW3tKn7Uu4y6G6g1xCd5FjzEYt0l7vTCkvHQl/8p LK04S9JclGBYSUNXdTiVmx9cSDpEmO7CL0q9dmLVrM6ioiWdlPJxefeC9K7j5zWg2KuP VzSMMcPcIqtZaobO5G/+mitQdzXu3RTfQYOSZqMXchU0XgQnOJGRjRCyWBffTtXEAcV7 OyFA== X-Gm-Message-State: AOAM531lnjvyQxZ9SbbQW3DTyHdNi6zS6bPQKH1kHvT3XNVZ++oBq/JL UUl5501V7oMHAUJFayz/T1qbgtiQKbodT0mR9qA= X-Google-Smtp-Source: ABdhPJzdCC8KYQP83wMaduxPblYI/AL4REUDsbjUZaifet7YxTfc9HoHtQr/l8qGOD52tpzAtuZhMw== X-Received: by 2002:a2e:9182:: with SMTP id f2mr11575163ljg.57.1630146220324; Sat, 28 Aug 2021 03:23:40 -0700 (PDT) Received: from localhost.localdomain ([82.193.109.226]) by smtp.gmail.com with ESMTPSA id z2sm839895lfh.161.2021.08.28.03.23.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Aug 2021 03:23:39 -0700 (PDT) From: Oleksandr Suvorov To: u-boot@lists.denx.de Cc: Marcel Ziswiler , Philippe Schenker , Max Krummenacher , Oleksandr Suvorov , Oleksandr Suvorov , Fabio Estevam , Igor Opaniuk , "NXP i.MX U-Boot Team" , Stefano Babic , Tero Kristo Subject: [PATCH v2 2/2] colibri-imx8x: add on-module gpio expander fxl6408 Date: Sat, 28 Aug 2021 13:23:25 +0300 Message-Id: <20210828132316.v2.2.4c49798950@changeid> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210828132316.v2.1.ce74fbdbdc@changeid> References: <20210828102325.66668-1-oleksandr.suvorov@foundries.io> <20210828132316.v2.1.ce74fbdbdc@changeid> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean From: Oleksandr Suvorov The FXL6408 GPIO expander manages critical devices, including on-module USB hub. Configure the expander to switch the USB hub into bypass mode, allowing to use on-carrier-board USB hub. Signed-off-by: Oleksandr Suvorov Signed-off-by: Oleksandr Suvorov --- Changes in v2: - Kconfig: add better description for the config option. - gpio-fxl6408.c: -- improve registers' naming. -- fix code style (comments, etc.). -- reimplement fxl6408_read() reducing number of parameters. -- change return value of fxl6408_is_output() to bool. -- replace IS_ERR_VALUE() macros with simple x < 0 where it's possible. -- fxl6408_set_direction(): fix type of parameter "dir". -- fix return error codes to avoid using the predefined in the driver model ones. -- removed extra debug code. -- expand TODO list. arch/arm/dts/fsl-imx8qxp-colibri.dts | 27 +++++++++++++++++++++++++++ configs/colibri-imx8x_defconfig | 1 + 2 files changed, 28 insertions(+) diff --git a/arch/arm/dts/fsl-imx8qxp-colibri.dts b/arch/arm/dts/fsl-imx8qxp-colibri.dts index 11ece34c02..df992ac639 100644 --- a/arch/arm/dts/fsl-imx8qxp-colibri.dts +++ b/arch/arm/dts/fsl-imx8qxp-colibri.dts @@ -129,6 +129,14 @@ >; }; + /* On Module I2C */ + pinctrl_i2c0: i2c0grp { + fsl,pins = < + SC_P_MIPI_CSI0_GPIO0_00_ADMA_I2C0_SCL 0x06000021 + SC_P_MIPI_CSI0_GPIO0_01_ADMA_I2C0_SDA 0x06000021 + >; + }; + /* Off Module I2C */ pinctrl_i2c1: i2c1grp { fsl,pins = < @@ -298,6 +306,25 @@ }; }; +&i2c0 { + #address-cells = <1>; + #size-cells = <0>; + clock-frequency = <100000>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_i2c0>; + status = "okay"; + + /* GPIO expander */ + gpio_expander_43: gpio-expander@43 { + compatible = "fcs,fxl6408"; + gpio-controller; + #gpio-cells = <2>; + reg = <0x43>; + initial_io_dir = <0xff>; + initial_output = <0x05>; + }; +}; + &i2c1 { #address-cells = <1>; #size-cells = <0>; diff --git a/configs/colibri-imx8x_defconfig b/configs/colibri-imx8x_defconfig index a0816acc27..fbe6e575a3 100644 --- a/configs/colibri-imx8x_defconfig +++ b/configs/colibri-imx8x_defconfig @@ -38,6 +38,7 @@ CONFIG_TFTP_BLOCKSIZE=4096 CONFIG_TFTP_TSIZE=y CONFIG_CLK_IMX8=y CONFIG_CPU=y +CONFIG_FXL6408_GPIO=y CONFIG_MXC_GPIO=y CONFIG_DM_I2C=y CONFIG_SYS_I2C_IMX_LPI2C=y -- 2.31.1