From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47986C432BE for ; Mon, 30 Aug 2021 16:19:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CFBA60724 for ; Mon, 30 Aug 2021 16:19:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3CFBA60724 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 740F882BE5; Mon, 30 Aug 2021 18:19:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="kwA0mNiy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 13F7982BE5; Mon, 30 Aug 2021 18:19:24 +0200 (CEST) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ADE8C80224 for ; Mon, 30 Aug 2021 18:19:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x730.google.com with SMTP id m21so16210605qkm.13 for ; Mon, 30 Aug 2021 09:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=k6jwUN0392MlynrbAQRvk7Zvmt65K91riDDvQJe2w7U=; b=kwA0mNiyURGSXd+T6Q2EPhDQryd1INPAeUAFXdkMrzlfD2szgrSaTVZauIUNhxvCT4 gXUdnK4238ycdcjebKtteQQ4qOQtJgetzz/477eXImp2AYg3D0LzmxFQAf2JQNjN4wti fEs9/79E8ZWjbWr8Gs0vRlxOH4l2GC+ZGZ4yM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=k6jwUN0392MlynrbAQRvk7Zvmt65K91riDDvQJe2w7U=; b=ZFyZJ1/lKHDX5i1hgSne7+kaEC/vSJoImXdvwc2akR3Xgn5Krbh/GwJByeJq6OYNxV 4w6Xaakdwh3nvvYmaGleLRn5Sc2faDKEF3DFkvqQEuEi8nMgCkSUDWXvyYVihKW6aQLD atTFy+4HkmQJvRpu99e+2g0uxKoj2RMSBnK7u8N+np/UqCgobJJTwRFjVY53BuDaydyR pIe6baRYzZRjnEdpyMRkNF4qPUJhoMrFwbGwYsRCXGJbW1FTbVy+fMUjegxelyzJ/rCL ptiGjonQEThDyjNVcMIwjeOhQ4cOmrzuV9F7Eb1K7S8hPNbm8xc2dmX/vqdaHTx6+ked c8GQ== X-Gm-Message-State: AOAM531dhBeKIlBZwDGh/FzyZZh5UQB9o9M5EQj3ODoFADwPU272VvhE +uPGdTiXtWa0/xISmPP3MX990+KUD8OC2XGo X-Google-Smtp-Source: ABdhPJzIxPkOin3MmcYYxfc2ybCxVPVM25Crz/znfpEiEsw1Dq84337+cGCF9YkFtOZ22Eho36Ut0A== X-Received: by 2002:a05:620a:2e4:: with SMTP id a4mr23089977qko.288.1630340358465; Mon, 30 Aug 2021 09:19:18 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-8d75-4e9a-efec-7167.res6.spectrum.com. [2603:6081:7b01:cbda:8d75:4e9a:efec:7167]) by smtp.gmail.com with ESMTPSA id c193sm11841549qkg.120.2021.08.30.09.19.17 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 30 Aug 2021 09:19:17 -0700 (PDT) Date: Mon, 30 Aug 2021 12:19:16 -0400 From: Tom Rini To: Alexandru Gagniuc Cc: u-boot@lists.denx.de, sjg@chromium.org Subject: Re: [PATCH 3/5] common/spl: Drop SPL_HASH_SUPPORT in favor of SPL_HASH Message-ID: <20210830161916.GA858@bill-the-cat> References: <20210824005320.3647668-1-mr.nuke.me@gmail.com> <20210824005320.3647668-4-mr.nuke.me@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3NG3MkhfyVhvgwiL" Content-Disposition: inline In-Reply-To: <20210824005320.3647668-4-mr.nuke.me@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --3NG3MkhfyVhvgwiL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 23, 2021 at 07:53:18PM -0500, Alexandru Gagniuc wrote: > Both these configs exist. Stick to using CONFIG_SPL_HASH, and drop all > references to CONFIG_SPL_HASH_SUPPORT. >=20 > Signed-off-by: Alexandru Gagniuc [snip] > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > index d69d1fa5f7..c75c8aaf08 100644 > --- a/common/spl/Kconfig > +++ b/common/spl/Kconfig > @@ -477,16 +477,6 @@ config SPL_CRYPTO > this option to build the drivers in drivers/crypto as part of an > SPL build. > =20 > -config SPL_HASH_SUPPORT > - bool "Support hashing drivers" > - select SHA1 > - select SHA256 > - help > - Enable hashing drivers in SPL. These drivers can be used to > - accelerate secure boot processing in secure applications. Enable > - this option to build system-specific drivers for hash acceleration > - as part of an SPL build. There's a lot more work to be done around platforms that enabled sha1/sha256 this way and confirming that it was actually unusable code. For example, (as it was where I stopped paging at in less just now) ls1043aqds_nor_ddr3 drops sha256 and md5 algorithm support, I suspect because of this hunk, but could be some other part of the series. Using buildman's --show-sizes --bloat can be really handy to see when a patch drops out a bunch of code, or adds it in. --=20 Tom --3NG3MkhfyVhvgwiL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEtBQMACgkQFHw5/5Y0 tywYfQv+Jw2tFwHeMBtwHgXqRjjEaTxTsSp7l9ShnQ8pBS77MPLmbNIwd0QL2vM4 eTpTCisSie6Q9n6eBL740rjtXM71gkzUTTx6GprS3FaRhghZ6uF0eQcwqaSXr8vV F4xPz5QoIk0XT2HoopT0HExtbidXKOt7ScbMD/GMy+Wly1BiIirgBbtYlfN5Dt8S ND6vB/sPosX5wXwoI1JRemF93lzC2tCisd7hIHPeW4NEjCr6kD1zSPwVsy1La/Zs sKiJT+nYRdZx9XdMB1Sv624BWsOHImfy6RJLDnZ6xfPVeKj1/lCgcPSC4utDHwcU u+2bnd1N6vE4BDZ3ff/HWTvxg4BEuljZl63dWHTKj2vuOEj+8OQb40QCCE8WR7Qt m2b85wfMK1vdr4tUjBRbNO4ArBQ6vLESzW6r3kHCeuze5DeBXzBmyg21QZ6CaQi1 oK5Km77kdUvJ9KAvR9FSU5r9HGOc8IIjr7CsRUUoHhrr4mSyBhZHCBgesN6EcxGG /xEiJ9Sx =y1TP -----END PGP SIGNATURE----- --3NG3MkhfyVhvgwiL--