From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA17BC4320A for ; Tue, 31 Aug 2021 12:44:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 385126103D for ; Tue, 31 Aug 2021 12:44:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 385126103D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D86E580C68; Tue, 31 Aug 2021 14:44:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="LOcEV8Vg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E6998807FE; Tue, 31 Aug 2021 14:44:53 +0200 (CEST) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A471380C68 for ; Tue, 31 Aug 2021 14:44:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2b.google.com with SMTP id z7so6217268qvi.4 for ; Tue, 31 Aug 2021 05:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=hAHaIRjo8uqywjx9LIXnTyPRLwfCWcPKOWEhFIgCJ5s=; b=LOcEV8VgmI2UBCiU3BJzzqe57D5LpsdTWNyLHZu1EcG31wKY+411axGvDZKkse/RCB 0pk0KqRX7P906WCaFKYbyqZOThp+rDJ6LEW/nfIqwOdixdZOqwt5YtG+N2O+fJtZKBLS nutQJnLwkzQ/5Ri5EkAyAvyFpwVzoUgT1N2NM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=hAHaIRjo8uqywjx9LIXnTyPRLwfCWcPKOWEhFIgCJ5s=; b=d2QyzFNEv8uxRhHO0iaVdr7b4cNrFitWxkgtN4WsMbl2XTPB5p6vEVFMN/iKqmugGX BhWR39j4eZAR6nm1HpJOuA05Q70KwV04ThJRCW9npwvIAuU0by7nsWAufZcSAE5ApJ/y HaGiPvtWV4XG29ASVO4VyEqJqw0n8j4cKVI2UPlhMMmkvBcRAWb+swRRqZV/vqrA/KSW H6HICrtx65zGlX0RfYiVWvWLKpWqKbDGslDkfTTkxHxWYQUfI9mLpft8XUGATuNceLE3 mvfp2tGXxCK3etQyBka1ofs+wJzJz9lT7E04xn6FjOTQKktWdQikWW0Ya+UqzPJJv9kh qt/w== X-Gm-Message-State: AOAM53313vJDKVES/HFJ88r/1GyozSpLDrOBJ8+B3K3Bn+Q4gy9Z5Tem jsYO1Q0YAotNA9zaMcsKFunN3Q== X-Google-Smtp-Source: ABdhPJyP7Md1FYb0zHMH0hT+0LHpFV0DP2wHNN50awkmgkUtEICi+wd7n8BSLyN9VaYn1ka7ls8afQ== X-Received: by 2002:a05:6214:18f0:: with SMTP id ep16mr28128819qvb.25.1630413883461; Tue, 31 Aug 2021 05:44:43 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-8d75-4e9a-efec-7167.res6.spectrum.com. [2603:6081:7b01:cbda:8d75:4e9a:efec:7167]) by smtp.gmail.com with ESMTPSA id p1sm13884893qkh.115.2021.08.31.05.44.42 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 31 Aug 2021 05:44:42 -0700 (PDT) Date: Tue, 31 Aug 2021 08:44:41 -0400 From: Tom Rini To: Rasmus Villemoes Cc: Stefan Roese , u-boot@lists.denx.de, Simon Glass , Wolfgang Denk Subject: Re: [PATCH v6 12/12] sandbox: add test of wdt-uclass' watchdog_reset() Message-ID: <20210831124441.GC858@bill-the-cat> References: <20210819095706.3585923-1-rasmus.villemoes@prevas.dk> <20210819095706.3585923-13-rasmus.villemoes@prevas.dk> <2070bb6a-84c3-9fc9-fd06-6c40f7ed1fbc@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5CYgJs0NbY5oHGr7" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --5CYgJs0NbY5oHGr7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 31, 2021 at 11:29:51AM +0200, Rasmus Villemoes wrote: > On 31/08/2021 10.17, Stefan Roese wrote: > > Hi Rasmus, > >=20 > > I've pulled this patchset now into next [1] and have run it through > > CI via Azure. Here an error occurs: > >=20 > > https://dev.azure.com/sr0718/u-boot/_build/results?buildId=3D109&view= =3Dlogs&j=3D50449d1b-398e-53ae-48fa-6bf338edeb51&t=3D97605dd2-f5a5-5dd7-211= 8-315ffdc8bcd6&l=3D533 > >=20 > >=20 > > Could you please take a look at this? >=20 > I'm pretty confident that has nothing to do with my patches, but is a > broken (or, to put it more gently, fragile) test. >=20 > It does >=20 > // fetch the emulated device's current base_time value, setting it to 0 > old_base_time =3D sandbox_i2c_rtc_get_set_base_time(emul, 0); >=20 > // fetch the emuluated device's current base_time value, don't (-1) set > // a new value, check that we got 0 > ut_asserteq(0, sandbox_i2c_rtc_get_set_base_time(emul, -1)); >=20 > // call the device's ->reset method > /* Resetting the RTC should put he base time back to normal */ > ut_assertok(dm_rtc_reset(dev)); > // fetch the new base_time value, without altering it > base_time =3D sandbox_i2c_rtc_get_set_base_time(emul, -1); > // and check that the base time was put back to "normal" > ut_asserteq(old_base_time, base_time); >=20 > The thing is, the ->reset method does >=20 > static void reset_time(struct udevice *dev) > { > struct sandbox_i2c_rtc_plat_data *plat =3D dev_get_plat(dev); > struct rtc_time now; >=20 > os_localtime(&now); > plat->base_time =3D rtc_mktime(&now); >=20 > It's inevitable that this will cause occasional spurious failures. I can > trivially reproduce it with >=20 > =3D> while ut dm rtc_reset ; do echo . ; done >=20 > it fails after a few screenfuls of successes. Yes, this test fails sometimes and just needs to be re-run. Currently we even have code in the test framework to allow for a little bit of wiggle room in the value, but perhaps it needs to be bumped up slightly. --=20 Tom --5CYgJs0NbY5oHGr7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEuJDgACgkQFHw5/5Y0 tyzNngwAotwqEcErj/HhGqt4IUi5TqY+XA9mzPCouQmJ8X3M+TXM57SmWDQ1hyOa oBmU6Ei7WAi29TOcM8R4FLwezOngk4VfUDqAVPPUdh1MRoPcy38a2Sa/oQzNM11o JvwZQqaAUlVpT3psVwq89TK+Ku+ElAxg0IxSzdgFT5ywp32k5jtbHe48tXIQcBMq R5OsiWDaSGaL50/ivUj5gmaZcqkz0dJ/Wha9kSdcAQL715jadogYAD1BD6biBXeR iD+tiavLKtB1I1B0rqUa8pjMNvn+zKPz4LXbiTASD0QhAvAAxGFo4TEig93Pxapl LltMTIcf8ncuq+5DqDkQ3DL2aOzURn5geedueIaNn1Z7f4Bnb7E6Lk/N74QVqkjM JS//+zV+tizD7X+JysHoWRP7xMhDY4ldHnsRI0y+Y93C+r2iqADrOQ6h4AWs8qaO sgQgMeLl+kZValiV9eIlZt6nAvmPRHm4Z9gQJPHP9NallHlccDo3TmUreo/j0EKA 5EmKnNNR =B9mj -----END PGP SIGNATURE----- --5CYgJs0NbY5oHGr7--