From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2BCCC432BE for ; Tue, 31 Aug 2021 18:46:23 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BDB4D61008 for ; Tue, 31 Aug 2021 18:46:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BDB4D61008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D0F7E83123; Tue, 31 Aug 2021 20:46:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="eYRY1S7I"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2A1B083129; Tue, 31 Aug 2021 20:46:19 +0200 (CEST) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02on060d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe06::60d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E398B83118 for ; Tue, 31 Aug 2021 20:46:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=vladimir.oltean@nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DoG0/r8phYIfQEM2xiLC93RZ8NZvuEEQV4fLMDCWp+pIByUzECB5aQKDm1Vp+YCat94uMCYx0sx8CeQKBWVC5MxIMq23WCFA9K5AXe9Jfr20jAgPzK1q3YliH8PqzWN2SiMyHjy/OFDBtQz0YUz9M1aFesaFUPVdCvZeLDaUHXIZzMJ3bFcqXO3EhWAWFIbn0VFj3Tzv7EFRKYE50i7eXiiNZDlm67yxGsUfAmP3yYFWnkCMITgBDSEs8R1kJG/E9GGpaG0gJQcrssD+IRicfIWEYVu3/I6C4hBRrleHkaLuMBuIxYEWyyF7Sphmtvem5rhVTfgFazr7aQnedOQBfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mwprfEBEUzS2RLtNFmo/5M7E/FC1SvM+xXDS/cve1a8=; b=QlarokWy/Pdg+h9sOwwJpGP3XDawyF/C3w7nDglfV+VHJ3BWeq7/9zlL9vg4Ef04pcFHHxPBJso9VzYcofT2HHLOWiQuoH0kcwkC1bHosR1eUMWyQk06g+c6I4M5/WaH51umStKvTJtkVp/+aEsohT2uHU3e/MN5WKgpfnBa0DOFP7Ar2HBIsYQzGfB5uItqQfacGO3zvivNWoQoDs61/rlWs8nk6IeZKyXQlc+LhjjfZXZSlCT90KKx7tHYGIZXsSk5Y9m/OVvE18LW5vE9OVfyZSVdFD7t3rVTAcxGzTTnw/VGfnFU3qdnAdTsbRcCjkj9svmHLsSDER1U+wramw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mwprfEBEUzS2RLtNFmo/5M7E/FC1SvM+xXDS/cve1a8=; b=eYRY1S7IYmYIZFJMpKMT6Fb0HzkmCh+IL+gtla23jVBpQSF7CVRfcWAetfJbKnHlRXwjvsYyy+izNftswf+hsSyjSp+3FIGZc5udYCz2f5SpUBQnJ8XTD/ZxDPbWOTJnJW79VVBL7MIt0sC6bVBNwGjbNx3a64jHhi1PrRTt+ZI= Received: from VI1PR04MB5136.eurprd04.prod.outlook.com (2603:10a6:803:55::19) by VI1PR04MB7104.eurprd04.prod.outlook.com (2603:10a6:800:126::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20; Tue, 31 Aug 2021 18:46:13 +0000 Received: from VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0]) by VI1PR04MB5136.eurprd04.prod.outlook.com ([fe80::109:1995:3e6b:5bd0%2]) with mapi id 15.20.4457.024; Tue, 31 Aug 2021 18:46:13 +0000 From: Vladimir Oltean To: Michael Walle CC: "u-boot@lists.denx.de" , Jagan Teki , Priyanka Jain , Tom Rini , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH 2/9] arm: dts: ls1028a: move devices into /soc Thread-Topic: [PATCH 2/9] arm: dts: ls1028a: move devices into /soc Thread-Index: AQHXnn6UWA1PuTb8a0CSNRFTzCl4NKuN8/KA Date: Tue, 31 Aug 2021 18:46:12 +0000 Message-ID: <20210831184611.tk7dzssaxburpneg@skbuf> References: <20210831154028.1649864-1-michael@walle.cc> <20210831154028.1649864-3-michael@walle.cc> In-Reply-To: <20210831154028.1649864-3-michael@walle.cc> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: walle.cc; dkim=none (message not signed) header.d=none;walle.cc; dmarc=none action=none header.from=nxp.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7a3ca2a8-893d-49e9-35a5-08d96caf9b59 x-ms-traffictypediagnostic: VI1PR04MB7104: x-ld-processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oPu1jWFGrxaFfJ7ipEUg547WbK+P3TnIHG3znqzdgUGu1RCf6vqEmORkSjTwzNgG6is52bNw+Zeqs1HskJV/60tChEzvHLCKlw5kuPNaWOS//8PkEcgLMThHYsfPUYj0dsPC95c/k+gnVlzHF8DqsOeVNkZAfAqEuUdtmvd5yM0u4BTIOLNXN7ut65XFn2yfBtPSnRah4934/GOGG4W8BngzjHjCBJWvhhVDRx2uCPTCi0Y4oTE6IUH3Q2JPdiq8zbn4+eZIqkWC5Fz9qBFsMUy2BaLegX9IRvz7RyzA6vbn84l1EwCC8u0NGJ/fEnVN9hcnBGfAHuc++KyjUccTQjLW8WFyqg2h4CE9PRuOw25ewvRB1SG161wmi/RWdExK2gqAsrSOxpsdxTwi0FNGhdzQfjWCGsURZKiM/srpLzKMyd0jETb/f9IOj7suEQIfYsNPwyQov/C8GLqGZyYOIwTGgZx2UUiQgCWOv+syO/Bpzw4zlUEah9irI2zO9rWACd5PrqEUxNKRAV6UWjwczlO8b6iJYt+4cMlA1B1Dpog938rIo+p/nOB939wVeOnQFuenrAPqpggOR6+ecBqORF+afztMC1dCTXRlBLoqQgOjeFPI2CgHXwVkPAN23ZWAmJUH57crPn60HVX4Rmzt403Lxb4JPkBnNDoZ2GpTP6JZRRih5JFvezM7mjWuiCoDsajtFBtB9++cJJQmexMsJw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB5136.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(7916004)(4636009)(366004)(122000001)(6486002)(38100700002)(83380400001)(86362001)(9686003)(6512007)(33716001)(71200400001)(38070700005)(26005)(66476007)(66946007)(1076003)(6506007)(4326008)(508600001)(186003)(66556008)(76116006)(91956017)(66446008)(64756008)(54906003)(2906002)(8676002)(6916009)(8936002)(44832011)(5660300002)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?E8QY/L0Crua/6TzVPTAdhICerRugwoNXWqHYAAIvifokwV2Ks6NNNugi5zp8?= =?us-ascii?Q?Wxmq7BlzwEnUFQj9dlOyu6L2IcfClBBScjJxalPXwdnXS9G1vBhhB8pnA+GT?= =?us-ascii?Q?/Uwo/T/yClQcyV33nUM4RMMFRZ1isTgukaMq/iLqIfhAlXpxhjpc4z4I6ppM?= =?us-ascii?Q?C67Xtnc5whcLyFvKrXXOqospi+R7oDmQLm4oWM8uEnVCzTvuaxHKC8H6eDK7?= =?us-ascii?Q?SWWs7+6IFTSqPXQC3cnCliZEZ8lOSkqiBf8fDzrFq1d/HpSv0dzMSUMYgrzr?= =?us-ascii?Q?ITgKKFZWh4FYH1umf4pTv/CdSIJ+X8C0pfjrgZF29qoJxTDyCTtFBUanLEM3?= =?us-ascii?Q?gsTBuvdd9tLrjoIgJMj9CCFexVML24X5AMKhnaKmRosCDw8WN+rewZ6jJfdP?= =?us-ascii?Q?du/PwQJXCZHGhhYKegLt8L7hYEM1ZvAEwy+uyq+vlBeTCT+fpElvRdegWTrD?= =?us-ascii?Q?e/EjHmE4bK0sBb5wxBIMPQI0l0wiEp0n/CokZsOjULa0wsAM78W98uc4gyUE?= =?us-ascii?Q?aakxm5Ny5FCo/KgprenRKr3modt7v3Yw/zf7+jyYvt7BLEMPpZvc1t1UU9aO?= =?us-ascii?Q?l76NBU7K/mdhZOQD+nVhz2uTSti8eUAJjMaNIAYVih/9XwfO+xqHI6ER2eo+?= =?us-ascii?Q?X/HWYBNR8jeK5k4+DW5+qXiC0cal7L1/eW/3nCV2aJPeh6tn+Obi+iwTkWvk?= =?us-ascii?Q?nic8Kg7K0R8gKL43qg5f+qQAwJQANoodQcLKqa4nuEYIqYpiSUAG5KBUJcSJ?= =?us-ascii?Q?0pT9vEzKdPcFEZDaa773Fh189VxvtOlNV04kdYofuubLSjHp4PaRhZ4Rsnf6?= =?us-ascii?Q?xx4tJ11rcdJ7MGtHiw5i+66n/iP+wRHV0Di6wALBlVO0AFHEjQfhxW5/45Hd?= =?us-ascii?Q?takiLU4TknrDK5bxjKbdp/rHSFesR2gFRD2G/Dzfo2iiJ8Ya//ufz6KBfRxr?= =?us-ascii?Q?xzid9tGF4qyZlgj4o0mhCM5mrMxu/32I3D+63qYGmAjuPs5P1e0vPhNzP9ua?= =?us-ascii?Q?E36axwaiD3fpy9sAE/6FGWdAcdgfeW6cBUw8FPQR4cx2ka+/xQdMNTqPoUrZ?= =?us-ascii?Q?szEXVKtcd0bJszUJyspKROVQ5j4MWksPaWmSNPVQvgglJNXjNhGJSm0Yy7dZ?= =?us-ascii?Q?p9R/DQwUkG4QhwyMeTTKCWhOe4F7mZfWB7H+aQxwxqEVUCwFk6RJTmpIDcU9?= =?us-ascii?Q?59ryqMLQOkfZJ8m2qU4oKgdc3bMvDtzE9hXSdzxkExA3cFeLnnMS19YPJ/Je?= =?us-ascii?Q?7iOjNL9CjXcA+hext07ozTLJXL7vIsjLEOPB14mrur+nKN2B01VyqvgsUrc8?= =?us-ascii?Q?+OgB0QDRl2h39wyayplpnJZiHASPmneOmdxS9ryeRClOkw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7a3ca2a8-893d-49e9-35a5-08d96caf9b59 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2021 18:46:12.9708 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IijcbF9mEi001Ujk/H8Fs8QQpfPFa3HnneQz5Purb2XZlerP7Tvo7uM4/n6FMCDQCMHAwKjIuS97VZ+srh9OTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7104 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Aug 31, 2021 at 05:40:21PM +0200, Michael Walle wrote: > Move all the CCSR related device nodes into /soc similiar to the linux > device tree. >=20 > Signed-off-by: Michael Walle > --- > .../dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi | 4 + > .../dts/fsl-ls1028a-qds-1xxx-sch-30842.dtsi | 2 +- > .../dts/fsl-ls1028a-qds-6xxx-sch-30842.dtsi | 2 +- > .../dts/fsl-ls1028a-qds-7777-sch-30841.dtsi | 8 +- > .../dts/fsl-ls1028a-qds-7xx7-sch-30841R.dtsi | 4 +- > .../dts/fsl-ls1028a-qds-8xxx-sch-24801.dtsi | 2 +- > .../fsl-ls1028a-qds-9999-sch-24801-LBRW.dtsi | 8 +- > .../dts/fsl-ls1028a-qds-9999-sch-24801.dtsi | 8 +- > .../fsl-ls1028a-qds-x3xx-sch-30841-LBRW.dtsi | 8 +- > .../fsl-ls1028a-qds-x5xx-sch-28021-LBRW.dtsi | 8 +- > .../dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi | 2 +- > .../dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi | 2 +- > arch/arm/dts/fsl-ls1028a-qds.dtsi | 4 + > arch/arm/dts/fsl-ls1028a-rdb.dts | 4 + > arch/arm/dts/fsl-ls1028a.dtsi | 767 +++++++++--------- > 15 files changed, 426 insertions(+), 407 deletions(-) >=20 > diff --git a/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi b/arch/arm= /dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi > index b3861ed98c..fa4c05212a 100644 > --- a/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-kontron-sl28-u-boot.dtsi > @@ -266,6 +266,10 @@ > u-boot,dm-pre-reloc; > }; > =20 > +&soc { > + u-boot,dm-pre-reloc; > +}; > + Does the Kontron SL28 use SPL? > &sysclk { > u-boot,dm-pre-reloc; > }; > diff --git a/arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi b/arch/arm/= dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi > index 1fb2cdf0c2..1834418ae2 100644 > --- a/arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-qds-x7xx-sch-30842.dtsi > @@ -20,7 +20,7 @@ > &mscc_felix_port1 { > status =3D "okay"; > phy-mode =3D "sgmii-2500"; > - phy-handle =3D <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@50/phy@02}>; > + phy-handle =3D <&{/soc/i2c@2000000/fpga@66/mux-mdio@54/mdio@50/phy@02}>= ; > }; > =20 > &mscc_felix_port4 { > diff --git a/arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi b/arch/arm/= dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi > index 2333f74e5a..2ee11bcacb 100644 > --- a/arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-qds-xx7x-sch-30842.dtsi > @@ -20,7 +20,7 @@ > &mscc_felix_port2 { > status =3D "okay"; > phy-mode =3D "sgmii-2500"; > - phy-handle =3D <&{/i2c@2000000/fpga@66/mux-mdio@54/mdio@60/phy@02}>; > + phy-handle =3D <&{/soc/i2c@2000000/fpga@66/mux-mdio@54/mdio@60/phy@02}>= ; > }; > =20 > &mscc_felix_port4 { > diff --git a/arch/arm/dts/fsl-ls1028a-qds.dtsi b/arch/arm/dts/fsl-ls1028a= -qds.dtsi > index 69632fa796..3b223a5b52 100644 > --- a/arch/arm/dts/fsl-ls1028a-qds.dtsi > +++ b/arch/arm/dts/fsl-ls1028a-qds.dtsi > @@ -241,6 +241,10 @@ > status =3D "okay"; > }; > =20 > +&soc { > + u-boot,dm-pre-reloc; > +}; > + The LS1028A-QDS does not use SPL, it uses TF-A, hence the name: configs/ls1028aqds_tfa_defconfig > &usb1 { > status =3D "okay"; > }; > diff --git a/arch/arm/dts/fsl-ls1028a-rdb.dts b/arch/arm/dts/fsl-ls1028a-= rdb.dts > index 82a8c0a0cd..06ee4e747a 100644 > --- a/arch/arm/dts/fsl-ls1028a-rdb.dts > +++ b/arch/arm/dts/fsl-ls1028a-rdb.dts > @@ -123,6 +123,10 @@ > status =3D "okay"; > }; > =20 > +&soc { > + u-boot,dm-pre-reloc; > +}; > + Likewise. Otherwise, the patch itself is pretty much impossible to follow. I guess the only option would be to move nodes one by one to /soc such that it becomes obvious. I don't have a strong preference, just saying that I can't judge it for correctness.=