From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Michael Walle <michael@walle.cc>
Cc: "u-boot@lists.denx.de" <u-boot@lists.denx.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Priyanka Jain <priyanka.jain@nxp.com>,
Tom Rini <trini@konsulko.com>,
Peter Griffin <peter.griffin@linaro.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: Re: [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux
Date: Wed, 1 Sep 2021 11:43:33 +0000 [thread overview]
Message-ID: <20210901114332.guvhyyulkkbl2mf5@skbuf> (raw)
In-Reply-To: <20210901085522.1712104-9-michael@walle.cc>
On Wed, Sep 01, 2021 at 10:55:21AM +0200, Michael Walle wrote:
> - pcie1: pcie@3400000 {
> - ranges = <0x81000000 0x0 0x00000000 0x80 0x00020000 0x0 0x00010000 /* downstream I/O */
> - 0x82000000 0x0 0x40000000 0x80 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
> - };
>
> - pcie2: pcie@3500000 {
> - ranges = <0x81000000 0x0 0x00000000 0x88 0x00020000 0x0 0x00010000 /* downstream I/O */
> - 0x82000000 0x0 0x40000000 0x88 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
> - };
> + pcie1: pcie@3400000 {
> + ranges = <0x81000000 0x0 0x00000000 0x80 0x00010000 0x0 0x00010000 /* downstream I/O */
> + 0x82000000 0x0 0x40000000 0x80 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
> };
>
> + pcie2: pcie@3500000 {
> + ranges = <0x81000000 0x0 0x00000000 0x88 0x00010000 0x0 0x00010000 /* downstream I/O */
> + 0x82000000 0x0 0x40000000 0x88 0x40000000 0x0 0x40000000>; /* non-prefetchable memory */
> + };
This change also makes an undocumented movement of the PCIe window in
the SoC memory space from 0x80_00020000 to 0x80_00010000 for pcie1, and
from 0x88_00020000 to 0x88_00010000 for pcie2.
It should probably work either way, considering that the SoC system
memory map lists the entire 32GB of address space starting from
0x0080_0000_0000 as belonging to PEX1, and 0x0088_0000_0000 belonging to
PEX2, but either way, is there no better way to make these changes?!
It seems like a lot to go through. At the very least do document the
changes in the commit message, it makes you be aware of what you're
changing, and it makes people get an overview instead of needing to do
dumpster diving.
next prev parent reply other threads:[~2021-09-01 11:43 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 8:55 [PATCH v2 0/9] arm: dts: ls1028a: sync device tree with linux Michael Walle
2021-09-01 8:55 ` [PATCH v2 1/9] armv8: ls1028a: add IOMMU stream ID to vivante node Michael Walle
2021-09-01 8:55 ` [PATCH v2 2/9] arm: dts: ls1028a: move devices into /soc Michael Walle
2021-09-01 10:05 ` Vladimir Oltean
2021-09-01 8:55 ` [PATCH v2 3/9] arm: dts: ls1028a: remove /memory node Michael Walle
2021-09-01 8:55 ` [PATCH v2 4/9] arm: dts: ls1028a: update the labels Michael Walle
2021-09-01 10:07 ` Vladimir Oltean
2021-09-01 8:55 ` [PATCH v2 5/9] watchdog: sp805_wdt: use correct compatible string Michael Walle
2021-09-01 8:55 ` [PATCH v2 6/9] spi: fsl_dspi: add new compatible fsl, ls1021a-v1.0-dspi Michael Walle
2021-09-01 8:55 ` [PATCH v2 7/9] serial: lpuart: add new compatible fsl,ls1028a-lpuart Michael Walle
2021-09-01 8:55 ` [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Michael Walle
2021-09-01 10:29 ` Vladimir Oltean
2021-09-01 21:34 ` Michael Walle
2021-09-01 21:59 ` Vladimir Oltean
2021-09-06 8:37 ` Michael Walle
2021-09-01 11:24 ` Vladimir Oltean
2021-09-01 11:51 ` Michael Walle
2021-09-01 11:55 ` Vladimir Oltean
2021-09-01 12:05 ` Michael Walle
2021-09-01 12:21 ` Vladimir Oltean
2021-09-01 12:38 ` Michael Walle
2021-09-01 12:57 ` Vladimir Oltean
2021-09-01 13:30 ` Michael Walle
2021-09-01 21:38 ` Tom Rini
2021-09-01 11:27 ` Vladimir Oltean
2021-09-01 14:51 ` Michael Walle
2021-09-01 11:43 ` Vladimir Oltean [this message]
2021-09-01 11:46 ` Michael Walle
2021-09-01 8:55 ` [PATCH v2 9/9] arm: dts: sl28: sync dtbs Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210901114332.guvhyyulkkbl2mf5@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=jagan@amarulasolutions.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michael@walle.cc \
--cc=peter.griffin@linaro.org \
--cc=priyanka.jain@nxp.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox