From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DEDAC432BE for ; Wed, 1 Sep 2021 20:59:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2178161027 for ; Wed, 1 Sep 2021 20:59:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2178161027 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8C82882986; Wed, 1 Sep 2021 22:59:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="pG1Lmcgy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5628682986; Wed, 1 Sep 2021 22:59:18 +0200 (CEST) Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D489E817D3 for ; Wed, 1 Sep 2021 22:59:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x731.google.com with SMTP id t190so996490qke.7 for ; Wed, 01 Sep 2021 13:59:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IoKo3fHG8U6M/gHKOh7p+gyzOcJdn0VHAGJAV9fUtGE=; b=pG1LmcgyehjD174/GFx2zoKxCnfO+Y6eEaIo6QLWoUVWDwB76SWZiUFSq13CMPe+Yz KGEE40fgNLM2sTC0jfVtaukhZdJWxP+lez+FfNlpfO+t8Slr91mvgJw1vww4zdkJHOKP SwZnDwHz8OVd69MAXHhmF0iO7AGwxVTcae+0I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=IoKo3fHG8U6M/gHKOh7p+gyzOcJdn0VHAGJAV9fUtGE=; b=aTyci/I8s5z9Yp2NsvxnihvcLqcN3YsahA+Hff1IbKXC7gzCQHC0NOgfBP5a3S/0Cp eFqlEEykKeBiVrsGflYQRQPj58VamlXed8hdj6Zq6OJkYA0Ec4WlDtC8I4x7PdGJ6+QS e2vJNvLAuI6PFu4g/PFaoowaR8vyzR3Sp5vXTVFvU6YftQC8otbh2HoOrQA16CsP+/3H Noj/8SFs7sGYKHUrXqh2Z9gtAyNevtq3MB1HPafD1pafO711ochIDmVE4901sByW5Sr5 4G7KZ2Y/FYIsC+Cv7Dg1Sc0tetgmMvjRX2sKZUZ250SDfPxZctjsv382W108BHxkjjcv SpVw== X-Gm-Message-State: AOAM530iGqxhNGD+bMwtR/HYCf2NvO3wsQB3YgEMYtLtZrnbFM1ZypIG ZIjgmjdA6rodDsPmiJWJUwwdDg== X-Google-Smtp-Source: ABdhPJzrQ4yilMf5iOWIE8szUsTw4JS/NYiXUWaP/Q/erpc25lCVwzR7W47+CYDj5J/poD4o8kaagw== X-Received: by 2002:a37:9f15:: with SMTP id i21mr1594001qke.16.1630529952518; Wed, 01 Sep 2021 13:59:12 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-9d52-d816-c53d-6548.res6.spectrum.com. [2603:6081:7b01:cbda:9d52:d816:c53d:6548]) by smtp.gmail.com with ESMTPSA id m68sm534116qkb.105.2021.09.01.13.59.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Sep 2021 13:59:11 -0700 (PDT) Date: Wed, 1 Sep 2021 16:59:09 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: [PATCH 00/11] Reduce usage of timestamp macros Message-ID: <20210901205909.GA23592@bill-the-cat> References: <20210802131838.21097-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SUOF0GtieIMvvwua" Content-Disposition: inline In-Reply-To: <20210802131838.21097-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --SUOF0GtieIMvvwua Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Roh=E1r wrote: > Including timestamp.h (either directly or transitionally) cause build > system to recompile binaries at every 'make' run. This has disadvantage > in U-Boot development as for every small change 'make' recompiles lot of > other irrelevant files which were not touched / changed. >=20 > This patch series eliminate transitional / indirect usage of > timestamp.h by removing unneeded inclusion of header files, moving > timestamp values from macros to global variables, etc... >=20 > After these patches, U-Boot tools are not recompiled by every 'make' run, > which decrease time for incremental U-Boot recompilation. >=20 > Please test these patches, specially m68k and powerpc parts as I do not > have any of these boards. >=20 > Patch series depend on this patch (now marked as accepted): > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-pa= li@kernel.org/ >=20 > Pali Roh=E1r (11): > Remove #include from files which do not need it > Remove #include from files which do not need it > efi_loader: Use directly version_string variable > version: Move version_string[] from version.h to version_string.h > m68k: mcf: Remove overloading version_string > version: Put version_string[] variable into section > .text_version_string > powerpc: mpc: Put U-Boot version string at correct place by linker > script > version: Do not make version_string[] variable as a weak > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > version: Remove global macro U_BOOT_VERSION_STRING from version.h > Remove including timestamp.h in version.h So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 this fails to build for at least qemu-ppce500 and xtfpga. Over in=20 doc/develop/ci_testing.rst we document how to run a world build. Please fix these build errors and re-submit, thanks. --=20 Tom --SUOF0GtieIMvvwua Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEv6ZoACgkQFHw5/5Y0 tyzt/AwAmGKiCegE4DrqceFr5N7MWcWqp+MURvCs3jwQCh12ZEEg5suL74Pu0VaE i+/co7BmO04GnE42giKfb77m3F1p/2sgSBwTLtp1lXF4CmCaVxBFURTgChcKxaEj qPyTkbtYSa4Sbc52uAOaNX+L3+ah1BRI9o4CuLEGU2T6wkV/ak/NasmzQMjywjpa gEpHJcF9+V+aOJ7A11/B+7j9oYXby9KPI5F6cZQvP/0B0vBxvX5u4IrP/Hxq0RRP iu1REba6Ev4PjEEjLjKHixE1MSc+oZ5gk9wPlxAuoxizBRnwaeX4le9Mfwi0h4gw nl+JCXjmyLeVIN8h6Bn5SVeIAuyfsjEPUjFwF1+9iQJ6Wn7H4QDrYgX+t3ggF/Si UD+Cyjo8z0dt62/rccMmp8DtRS2n/XgDcCI3RFsGSAgVkzP/9NnUbT3/DtL5+POf fRdN7FWmNd6xTEgCST6b6udQ0028ocmnNljKd3LpkHmmbTsPFTzrimD8nDEA5wwu CW1ojOgN =3F/a -----END PGP SIGNATURE----- --SUOF0GtieIMvvwua--