From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63F4DC432BE for ; Wed, 1 Sep 2021 21:06:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D29D6056C for ; Wed, 1 Sep 2021 21:06:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D29D6056C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 78D058324B; Wed, 1 Sep 2021 23:05:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="HCe7qbv6"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9DD1F82D3C; Wed, 1 Sep 2021 23:05:56 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A1FC88324B for ; Wed, 1 Sep 2021 23:05:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id 0BDB36069E; Wed, 1 Sep 2021 21:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630530348; bh=RMx07InV7w4e2vUDjyUfADWU1E+zuL0EvJcikwv1QWA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HCe7qbv6tkcIvpk2HphiNxoN4e0DWmdV20AAnWBe0wMVB6fmaYTWq34TJKb8OLVzU 31M20IbJ9uCpg3YZlnOCAdQJ8WRfGEUVW3QSqCSZ/Ghmt33zjIqNa+KivieQ1h6/Jh I3OzEeCOzyDQVASxLW+8SpxbWAAbb2ztJwrKLrTqj1VbxjXbq2T0TUacMxrsi5vtW7 XXadLrRTkn6cjE/SlocDvuYp4zy0SSLNJ2/iu7nExxQj+K/QWFUs05+ncKsP4b2Gjb SGxjYGJJXhAK+I8MI9o54dEOD84vp6zVylly0Hi6D3Oppigrs9pdSKCX8DORGVjyPf QotDOAm/OHvlw== Received: by pali.im (Postfix) id D0252A46; Wed, 1 Sep 2021 23:05:45 +0200 (CEST) Date: Wed, 1 Sep 2021 23:05:45 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Tom Rini Cc: Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?utf-8?B?QmVow7pu?= , u-boot@lists.denx.de Subject: Re: [PATCH 00/11] Reduce usage of timestamp macros Message-ID: <20210901210545.4mbkattfc4m7nupl@pali> References: <20210802131838.21097-1-pali@kernel.org> <20210901205909.GA23592@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210901205909.GA23592@bill-the-cat> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Rohár wrote: > > > Including timestamp.h (either directly or transitionally) cause build > > system to recompile binaries at every 'make' run. This has disadvantage > > in U-Boot development as for every small change 'make' recompiles lot of > > other irrelevant files which were not touched / changed. > > > > This patch series eliminate transitional / indirect usage of > > timestamp.h by removing unneeded inclusion of header files, moving > > timestamp values from macros to global variables, etc... > > > > After these patches, U-Boot tools are not recompiled by every 'make' run, > > which decrease time for incremental U-Boot recompilation. > > > > Please test these patches, specially m68k and powerpc parts as I do not > > have any of these boards. > > > > Patch series depend on this patch (now marked as accepted): > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-pali@kernel.org/ > > > > Pali Rohár (11): > > Remove #include from files which do not need it > > Remove #include from files which do not need it > > efi_loader: Use directly version_string variable > > version: Move version_string[] from version.h to version_string.h > > m68k: mcf: Remove overloading version_string > > version: Put version_string[] variable into section > > .text_version_string > > powerpc: mpc: Put U-Boot version string at correct place by linker > > script > > version: Do not make version_string[] variable as a weak > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > > version: Remove global macro U_BOOT_VERSION_STRING from version.h > > Remove including timestamp.h in version.h > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > this fails to build for at least qemu-ppce500 and xtfpga. Over in > doc/develop/ci_testing.rst we document how to run a world build. Please > fix these build errors and re-submit, thanks. Already happened about month ago https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-1-pali@kernel.org/ As stated, following build command now passes: make CROSS_COMPILE=powerpc-linux-gnu- MCR3000_defconfig u-boot.bin