From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AF2FC432BE for ; Wed, 1 Sep 2021 21:34:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 981E060FDC for ; Wed, 1 Sep 2021 21:34:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 981E060FDC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 012DC8325B; Wed, 1 Sep 2021 23:34:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="GL1wp96F"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 11F398324E; Wed, 1 Sep 2021 23:34:07 +0200 (CEST) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BEB268325B for ; Wed, 1 Sep 2021 23:34:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x833.google.com with SMTP id s15so1029226qta.10 for ; Wed, 01 Sep 2021 14:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=4PnchNI2CzhC/ojas+g8BttI8cvNujXaw5DFq0mQ2UQ=; b=GL1wp96FewuyxBN5T1f8FhbvcERcKWm1DiS4xluwSt2HBoxGzRNv3NITwJURNP4dmH xZAyoHzF2BgldmaS8nIDkzqSrI7uj6rqDbaX1ACrnzaNIQijECQSAq/z6NlG2fNnk4GT WygXA4f1tujke/M+J3mR4/21N2GRc7lNuC3zc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=4PnchNI2CzhC/ojas+g8BttI8cvNujXaw5DFq0mQ2UQ=; b=TwJWjElecM4Lfr2O6dZZPy5odrsFKToCvAVcjgrDJVVKqhRGTMfj/I90pci8//IKyp 2H652jg+wH3GThFCUlJ8g6Xhu5hgdIlnIsB2p2366MW9iJ9/r92VJw0L/D7IUXEgaivz uFYt3zIwoFhEtPz0JMu0/j5eroB30L7qiVdUQ3t+yK12dg/09jvZ6XemJ3hmPIJIwV3u cLK1Kl5YJsfNKPUhpLLHkLiaYwnnAybkOoKuh4kx0sZJHOOmBGRg6Zu/unPIOQEE2KWy QJpxr/PI2OZBsxHzvxtGOW0DWlsNsBnwfjmZISdmjJwsY8tZkzbbX2LwychaPpnm5aib vCDw== X-Gm-Message-State: AOAM532dU+lDShh01HE7tlkUAgzltLXjA4KnjIngIi8ucfm5OAbF0heo lD7gf1llJE3FQGie4vdT1tw7mw== X-Google-Smtp-Source: ABdhPJwmR2wZjZqjSUxt+2Fi9cmBrA/f7ZiP836yQl3idP7A5/qkUzjBjsAhm1pWTQoNRDTDnAYFbQ== X-Received: by 2002:aed:204b:: with SMTP id 69mr1564274qta.24.1630532040467; Wed, 01 Sep 2021 14:34:00 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-9d52-d816-c53d-6548.res6.spectrum.com. [2603:6081:7b01:cbda:9d52:d816:c53d:6548]) by smtp.gmail.com with ESMTPSA id 13sm586672qka.56.2021.09.01.14.33.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Sep 2021 14:33:59 -0700 (PDT) Date: Wed, 1 Sep 2021 17:33:57 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?iso-8859-1?Q?Beh=FAn?= , u-boot@lists.denx.de Subject: Re: [PATCH 00/11] Reduce usage of timestamp macros Message-ID: <20210901213357.GS858@bill-the-cat> References: <20210802131838.21097-1-pali@kernel.org> <20210901205909.GA23592@bill-the-cat> <20210901210545.4mbkattfc4m7nupl@pali> <20210901211706.GR858@bill-the-cat> <20210901212854.dabsvrkga4xdqxdf@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XRkbtIJilauJWAZ9" Content-Disposition: inline In-Reply-To: <20210901212854.dabsvrkga4xdqxdf@pali> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --XRkbtIJilauJWAZ9 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 01, 2021 at 11:28:54PM +0200, Pali Roh=E1r wrote: > On Wednesday 01 September 2021 17:17:06 Tom Rini wrote: > > On Wed, Sep 01, 2021 at 11:05:45PM +0200, Pali Roh=E1r wrote: > > > On Wednesday 01 September 2021 16:59:09 Tom Rini wrote: > > > > On Mon, Aug 02, 2021 at 03:18:27PM +0200, Pali Roh=E1r wrote: > > > >=20 > > > > > Including timestamp.h (either directly or transitionally) cause b= uild > > > > > system to recompile binaries at every 'make' run. This has disadv= antage > > > > > in U-Boot development as for every small change 'make' recompiles= lot of > > > > > other irrelevant files which were not touched / changed. > > > > >=20 > > > > > This patch series eliminate transitional / indirect usage of > > > > > timestamp.h by removing unneeded inclusion of header files, moving > > > > > timestamp values from macros to global variables, etc... > > > > >=20 > > > > > After these patches, U-Boot tools are not recompiled by every 'ma= ke' run, > > > > > which decrease time for incremental U-Boot recompilation. > > > > >=20 > > > > > Please test these patches, specially m68k and powerpc parts as I = do not > > > > > have any of these boards. > > > > >=20 > > > > > Patch series depend on this patch (now marked as accepted): > > > > > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32= 325-1-pali@kernel.org/ > > > > >=20 > > > > > Pali Roh=E1r (11): > > > > > Remove #include from files which do not need it > > > > > Remove #include from files which do not need it > > > > > efi_loader: Use directly version_string variable > > > > > version: Move version_string[] from version.h to version_string= =2Eh > > > > > m68k: mcf: Remove overloading version_string > > > > > version: Put version_string[] variable into section > > > > > .text_version_string > > > > > powerpc: mpc: Put U-Boot version string at correct place by lin= ker > > > > > script > > > > > version: Do not make version_string[] variable as a weak > > > > > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug = log > > > > > version: Remove global macro U_BOOT_VERSION_STRING from version= =2Eh > > > > > Remove including timestamp.h in version.h > > > >=20 > > > > So, looking at https://source.denx.de/u-boot/u-boot/-/pipelines/8948 > > > > this fails to build for at least qemu-ppce500 and xtfpga. Over in= =20 > > > > doc/develop/ci_testing.rst we document how to run a world build. P= lease > > > > fix these build errors and re-submit, thanks. > > >=20 > > > Already happened about month ago > > > https://patchwork.ozlabs.org/project/uboot/patch/20210808112038.7942-= 1-pali@kernel.org/ > > >=20 > > > As stated, following build command now passes: > > > make CROSS_COMPILE=3Dpowerpc-linux-gnu- MCR3000_defconfig u-boot.bin > >=20 > > OK, I'll make sure to grab that. Note that xtfpga isn't PowerPC... >=20 > I saw only error https://source.denx.de/u-boot/u-boot/-/jobs/316601 and > this should be fixed above patch. At least I got similar error for > MCR3000_defconfig with new gcc before that. >=20 > But now after scrolling down I see that second xtfpga error > https://source.denx.de/u-boot/u-boot/-/jobs/316614 > But seems that in this UI is error log truncated. I see only >=20 > +xtensa-dc233c-elf-ld.bfd: section .text_version_string LMA [00000000fe02= 1584,00000000fe0215c7] overlaps section .u_boot_list LMA [00000000fe021584,= 00000000fe021e6b] >=20 > Is there a way how to show full build log? And which defconfig and > compiler is used? Because that error does not help me what is wrong > here... That's the full error log, from the linker, I believe. It's the xtfpga config for the xtensa architecture. It's one of the few that buildman won't fetch a good toolchain for so you'll want to look at tools/docker/Dockerfile and see we get it from https://github.com/foss-xtensa/toolchain/releases/download/2020.07/x86_64-2= 020.07-xtensa-dc233c-elf.tar.gz if you don't have the CI builder container itself handy already. --=20 Tom --XRkbtIJilauJWAZ9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEv8cEACgkQFHw5/5Y0 tyyxcwwAs0cFD3kyEnuMq+SPZDycr+hZFgzBo0a2WKE08nroN2UdnCBYhbS+zHAD hNeIS7iJfKCl91pXTE1NyWkHuSvbd0QXvTnF7g1lX6jZ3uHYWnUawgVue/3ldvZY +0eF0jHz4SzNa9JHtvQS2vYb5SxvdOy+XQkvTR8YQjC7N0UZCeVD3kYhqDfthlhj AIfjD83Uf4ercvGmQY8QppaMKXWy3gZTySKJwanWq+LvhEo92YJzeUyFmPkBMSye G5XrkxiQ047ttmDLoKtOS/HJIarvBIU2OjpP2HIbbMBAWvRRngvn7q48f6ZvChW2 o4ODNHA2/N0wPDEEAtxNFnYVeqioxwDU0HFSxA/1Tyyq3Fc033CjVqiKzI1s2bm6 egzwjuKHYNJnl3dAC41A84M9X68YNYnnDiGS7O4Ea0EaT0CK+B0mvhLQumLfpgNE tNlYVgGb/VdRNs9K+AQ0rJ/6dOrhjya7k2JxBsZVdlKD7/x5JvKZ6h45EV6Ji0/D uG2xHvvA =+16K -----END PGP SIGNATURE----- --XRkbtIJilauJWAZ9--