From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A417AC432BE for ; Wed, 1 Sep 2021 21:38:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CB1560525 for ; Wed, 1 Sep 2021 21:38:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0CB1560525 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D14438325E; Wed, 1 Sep 2021 23:38:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="QktnBMf9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1B76B83275; Wed, 1 Sep 2021 23:38:41 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C3BE683246 for ; Wed, 1 Sep 2021 23:38:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id t9so1078891qtp.2 for ; Wed, 01 Sep 2021 14:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=7IQ0erKn5ggS/jfMWthf8GrQVa0RDKLDXeGgvGicL7Q=; b=QktnBMf9YvgnYd9tdLcE2rssMUAbCZTwhBH4E7n9OHKr10Ogo+DsXH6lbhtxGKEjcN lIL0ej9YOJ3aA72lGGlj79Ocw0MIA6ioeCZeOUv7BnBMKrt5e0011moQYVs1Isgt0m4M /F8eN+vhFROeBh0lxmDDSqllcCLaxbwKURZUo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7IQ0erKn5ggS/jfMWthf8GrQVa0RDKLDXeGgvGicL7Q=; b=h9YKLguTCTbfqWxPmBlNGdbhJgdWpE/H2KFo0byDQWXbSU8ibOcGR3CWNR6pXxH3yP 0e0NT2N1jqig60SNxXC6ad4FGek81raNMqEPJclcnZqCXHhKezKK/lNVkbZqXpCYa8MZ EBm0GwsLkJqXiBmlrcB9milSAbYHsADaHQrjtvL6jPGwEWqMvFQc5XWouWEFh35FcGHP 6Xh8hNZPCkOabF1f7zV6SdlDfdHnMnmXAHYVCWV9IM0KzySMW6umRh9WzSrXwvwWopsg 8SbqHmL4sQfB1tEhVpBW3g8tlMU/D8y7or+Wx1CKVskRKS2fiN6+LJYLd2c7T5sDmhVj 6iGw== X-Gm-Message-State: AOAM530hMliHzn8eNkCd9DubGBmVTv2XiUsBZzhxri18t72xm+NJyYBh NDKuUzIs37J49C0+RDPQp9cdXA== X-Google-Smtp-Source: ABdhPJzH4+M8k6IY9wSWuBqgL2BobJ88cGL6FT5mI4CyjDR09PSIwHwAMI5fx+qTKe199QsoTivVOg== X-Received: by 2002:ac8:1099:: with SMTP id a25mr1484850qtj.155.1630532315506; Wed, 01 Sep 2021 14:38:35 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-9d52-d816-c53d-6548.res6.spectrum.com. [2603:6081:7b01:cbda:9d52:d816:c53d:6548]) by smtp.gmail.com with ESMTPSA id y12sm660854qtj.3.2021.09.01.14.38.34 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Sep 2021 14:38:34 -0700 (PDT) Date: Wed, 1 Sep 2021 17:38:32 -0400 From: Tom Rini To: Michael Walle Cc: Vladimir Oltean , u-boot@lists.denx.de, Jagan Teki , Priyanka Jain , Peter Griffin , Manivannan Sadhasivam Subject: Re: [PATCH v2 8/9] arm: dts: ls1028a: sync the fsl-ls1028a.dtsi with linux Message-ID: <20210901213832.GT858@bill-the-cat> References: <20210901085522.1712104-1-michael@walle.cc> <20210901085522.1712104-9-michael@walle.cc> <20210901112414.u3dbcbtlbyanwhjn@skbuf> <713ec89615bb7fbe461b909390cc09c7@walle.cc> <20210901115554.2zlfcfc4m6ymxwfx@skbuf> <248b3bb606fa9a073a98adc0748656ad@walle.cc> <20210901122149.bpufsq7gzo3n73mk@skbuf> <164efeb6985726c9d9f18a4e231a942e@walle.cc> <20210901125738.3q57qgfptjznaouh@skbuf> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xJ/5MdahJfjvnstE" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --xJ/5MdahJfjvnstE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 01, 2021 at 03:30:59PM +0200, Michael Walle wrote: > Am 2021-09-01 14:57, schrieb Vladimir Oltean: > > On Wed, Sep 01, 2021 at 02:38:15PM +0200, Michael Walle wrote: > > > Am 2021-09-01 14:21, schrieb Vladimir Oltean: > > > > On Wed, Sep 01, 2021 at 02:05:34PM +0200, Michael Walle wrote: > > > > > Am 2021-09-01 13:55, schrieb Vladimir Oltean: > > > > > > On Wed, Sep 01, 2021 at 01:51:53PM +0200, Michael Walle wrote: > > > > > > > Yes but that is on purpose. In the current u-boot device tree= , it was > > > > > > > disabled, but the boards reenabled them again. So it didn't m= atter. > > > > > > > > > > > > > > I want to have a specific sync point (that is the v5.14 tag) = for the > > > > > > > .dtsi. At least where possible; for phy-mode and so on I need= ed to to > > > > > > > take additional patches which weren't picked up in linux yet,= but > > > > > > > these just affect the sl28 board device trees. > > > > > > > > > > > > Binary compatibility is one thing and I can understand it. > > > > > > Textual compatibility, down to label names, and where the devic= e is > > > > > > being disabled from? Hmmmm, I'm having a hard time saying yes t= o that. > > > > > > > > > > It's a step back, yes. But only until v5.16 (I don't think the ch= anges > > > > > will make it during the merge window). I guess you are concerned > > > > > because > > > > > of your vendor fork? Mh, well actually I don't understand your > > > > > concert, > > > > > because your tree isn't compatible anyway if we change the labels. > > > > > > > > No, I don't care about "our vendor fork", it's been years since I've > > > > stopped using that. > > > > > > > > > We'd trade the clear information where the device tree is from for > > > > > something that - in my opinion - is not worth it. I mean the devi= ce > > > > > tree (source) is used just here in u-boot for these three boards = and > > > > > all have the usb nodes enabled. > > > > > > > > My concern was actually much simpler: your v1 conversion of the lab= el > > > > names was buggy (see the LS1028A-QDS build breakage). You deleted a > > > > bunch of comments which U-Boot had but Linux did not (luckily they = did > > > > not provide a lot of useful information anyway). You introduced some > > > > comments which do not make sense for the U-Boot tree, because they = were > > > > in Linux: the ICIDs in the iommu-map being fixed up by the bootload= er > > > > (you can instead say that "we will fix these up for the operating > > > > system"). > > > > Again, not big issues, but if it would boil down to my common sense, > > > > I'd focus more on the binary compatibility (after all, there will s= till > > > > be U-Boot specifics, which will constitute textual differences, but > > > > Linux will gladly ignore them, because this is what binary compatib= ility > > > > is about), and if it is preferable to have status =3D 'disabled' in= the > > > > dtsi, and a patch was already sent to Linux but not yet accepted, I > > > > would have kept U-Boot the way it was, and follow a model of > > > > "eventual consistency". > > > > > > > > If you still care more about textual consistency, I went through the > > > > patches > > > > once already, so it's not like changing things now will make things > > > > easier, > > > > or matter. > > >=20 > > > Ok, I see. But shouldn't be the goal to make things easy and just copy > > > the device tree to u-boot once in a while? Otherwise, we will > > > eventually > > > end up in the same mess as it is right now. Because well if they are > > > different anyway, then "we can just add another small thing right here > > > and there". > >=20 > > So if we "just add another small thing here and there", where that thing > > is a comment, or a 'status =3D "disabled"' structured differently but to > > the same result, does that land us in the "same mess" where half of the > > peripherals, and networking, would not work in Linux with the U-Boot > > provided DT? >=20 > I said eventually. My fear is that otherwise it will slowly diverge > again, because nobody really cares to keep them in sync. It doesn't have to, especially if we get things in proper sync now. There's a number of platforms that do regularly re-sync with the kernel. It's also something that with a bit of CI work, we could also make sure doesn't regress as well. But that'll take some binding documentation work to start with, along with updating / adding bindings upstream too. But again, just doing an every kernel release re-sync to keep things together is quite doable. --=20 Tom --xJ/5MdahJfjvnstE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEv8tgACgkQFHw5/5Y0 tyy0AAv/R02q+3ddg1JGUtg8hqnh7kFU8bU80swo2/d/Rdbv14fF4HVa7xcpyTNl 2+mGsb7yZ5Dp7D2NzN4BZc7yBF6a7tIjtgjB9uYzweOkxGpjF/kJ+FBEOohyPCU0 7WzauIAQhXGut0S8teZw0hZdV3HT6JxOm0X0z0+VhBb1T6eANG5n7hcvB+JfoDMx il94CbDSDuLE+yejhvtlJ298lA0BOGEr1wuQnebpHq+NOrycI9YTkztT2mF0kj4D 1UvaAGY5OwfO0mCzKujDDFENNVgnNToKJmbUTSQ4tX1VlZ0mgIiFWVqt7wPw+6dT 57B+LDOp2lHT9g680B7Wck2LQ6Qwm1eE9TS52uFzagt+xVMfmym9PzKSWBQUnpIT yvSCm2Gr2jJ+o4Fd+56gZXvU+wROnMXp31+mBRBphu5snynvFO78CSai98aNhXGt R7oseyFepQnEXE5quR4NsPRyXBIfD0dC2jLo4FWD89stjd+qheFTaz0F9Bp8cRG/ /tBRp/yv =q4Ls -----END PGP SIGNATURE----- --xJ/5MdahJfjvnstE--