From: Tom Rini <trini@konsulko.com>
To: Callum Sinclair <callum.sinclair@alliedtelesis.co.nz>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] rtc: ds1307: Fix incorrect clock reset for DS13xx
Date: Thu, 2 Sep 2021 09:29:29 -0400 [thread overview]
Message-ID: <20210902132929.GG858@bill-the-cat> (raw)
In-Reply-To: <20210810025115.30487-2-callum.sinclair@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
On Tue, Aug 10, 2021 at 02:51:15PM +1200, Callum Sinclair wrote:
> The ds1307 driver also supports the DS1339 and DS1340.
> However, in ds1307_rtc_reset the register writes assume that the chip
> is a DS1307. This is evident in the writing of bits SQWE, RS1, RS0 to
> the control register. While this applies correctly to the DS1307, on a
> DS1340 the control register doesn't contain those bits (instead, the
> register is used for clock calibration). By writing these bits the
> clock calibration will be changed and the chip can become
> non-functional after a reset call.
>
> Signed-off-by: Callum Sinclair <callum.sinclair@alliedtelesis.co.nz>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2021-09-02 13:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 2:51 [PATCH 0/1] rtc: ds1307: Fix incorrect clock reset for DS13xx Callum Sinclair
2021-08-10 2:51 ` [PATCH 1/1] " Callum Sinclair
2021-09-02 13:29 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902132929.GG858@bill-the-cat \
--to=trini@konsulko.com \
--cc=callum.sinclair@alliedtelesis.co.nz \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox