From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9129C432BE for ; Thu, 2 Sep 2021 14:42:11 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D6DA6108E for ; Thu, 2 Sep 2021 14:42:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1D6DA6108E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2F63E83474; Thu, 2 Sep 2021 16:42:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Sgs7+cra"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 468A683474; Thu, 2 Sep 2021 16:42:06 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 563AA83224 for ; Thu, 2 Sep 2021 16:42:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id a66so2303933qkc.1 for ; Thu, 02 Sep 2021 07:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EygpBm5+9iakTwaTDhQMP9pbdspNukp4qT7gfmYq+Ik=; b=Sgs7+craJndAhtbZx+QcjJwcRfY3TmrUGpdMws0QK7z5CqONIUjIQ+LOtwDFj2Yxhx iBHW1v+m3wYj986748E9hUSrWvPVdbbGWSz0vXxr2WU6NhtOHkVNW7rbrcSseNAePrcu /qrxRpvCzTg+y7Ff1uieVV/v9pDlQv9yqcJVM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EygpBm5+9iakTwaTDhQMP9pbdspNukp4qT7gfmYq+Ik=; b=CMRpGTvP67DZII/cgB1Nsnc4ZYVIw+4a9yqJzf3U9AxBJnFt2ige2PVbQT2jNIPSqk fMPZffvME+sxzZKwAqVN6izgg9E+fAYV1PxiyKfv3FzVDScU6oTXuQJexd+JapHTkS0j F3BBLm/MKkbkBDv91lCr4HoCm5EIhe8czYxuEbMT4jHDNAH6faXTnl5RMPRxH0aqXMCG h7J5QtxjnKxb184P6HrFVQ4r/li2j+YHy2i+LvsK1PdKV4OjKRMp4vuVPpVVswjyC4rD XTuhxwt+V5IrR87gzXATkoRD600jH0YahTdFMSfiLDIhwjNTkWLY4q00WmBz6JrloCNq cKYg== X-Gm-Message-State: AOAM533LhyxwpuA3yY69s9chxLQ4azEqmjtlF07PSUqoa8Y1ggCgzoiq QIQYBZ8Cr3e/E+jWVXd3giGK4w== X-Google-Smtp-Source: ABdhPJwCoW62GVfTGIHawsptxCEN1FNrhcUJoeauw/eb+doSsoA0BU9lF2dBelWsq2+nWH2UqImEkw== X-Received: by 2002:a37:e43:: with SMTP id 64mr3551410qko.249.1630593720216; Thu, 02 Sep 2021 07:42:00 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-95b1-4c42-35f4-d991.res6.spectrum.com. [2603:6081:7b01:cbda:95b1:4c42:35f4:d991]) by smtp.gmail.com with ESMTPSA id 102sm1139263qtc.62.2021.09.02.07.41.59 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 02 Sep 2021 07:41:59 -0700 (PDT) Date: Thu, 2 Sep 2021 10:41:57 -0400 From: Tom Rini To: Stefan Roese Cc: u-boot@lists.denx.de, Rasmus Villemoes , sjg@chromium.org, Wolfgang Denk Subject: Re: [PATCH v5 3/3] arm64: Kconfig: Enable usage of optimized memset/memcpy/memmove Message-ID: <20210902144157.GL858@bill-the-cat> References: <20210817084827.692859-1-sr@denx.de> <20210817084827.692859-4-sr@denx.de> <20210902141722.GA15430@bill-the-cat> <160f27bb-e94d-329f-0cea-5444071a09a1@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EcGdEOzhxf5S15/x" Content-Disposition: inline In-Reply-To: <160f27bb-e94d-329f-0cea-5444071a09a1@denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --EcGdEOzhxf5S15/x Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2021 at 04:37:41PM +0200, Stefan Roese wrote: > On 02.09.21 16:17, Tom Rini wrote: > > On Tue, Aug 17, 2021 at 10:48:27AM +0200, Stefan Roese wrote: > >=20 > > > This patch enables the use of the optimized memset(), memmove() & > > > memcpy() versions recently added on ARM64. > > >=20 > > > Signed-off-by: Stefan Roese > > > --- > > >=20 > > > Changes in v5: > > > - memmove is now auto-selected (or deselected) with the memcpy > > > Kconfig selection as it's entry is the same as memcpy for ARM64 > > >=20 > > > Changes in v3: > > > - Add memmove as well > > >=20 > > > arch/arm/Kconfig | 37 +++++++++++++++++++++++++++++---= --- > > > arch/arm/include/asm/string.h | 4 ++++ > > > 2 files changed, 35 insertions(+), 6 deletions(-) > >=20 > > This gives a ton of build failures for me, using gcc-9.2.0 (from > > kernel.org) along the lines of: > > Building current source for 1 boards (1 thread, 16 jobs per thread) > > aarch64: + j721e_evm_a72 > > +(j721e_evm_a72) aarch64-linux-ar: warning: arch/arm/lib/memset-arm64.o= : unsupported GNU_PROPERTY_TYPE (5) type: 0xc0000000 > > +(j721e_evm_a72) aarch64-linux-ar: warning: arch/arm/lib/memcpy-arm64.o= : unsupported GNU_PROPERTY_TYPE (5) type: 0xc0000000 > > +(j721e_evm_a72) aarch64-linux-ld.bfd: warning: arch/arm/lib/memset-arm= 64.o: unsupported GNU_PROPERTY_TYPE (5) type: 0xc0000000 > > +(j721e_evm_a72) aarch64-linux-ld.bfd: warning: arch/arm/lib/memcpy-arm= 64.o: unsupported GNU_PROPERTY_TYPE (5) type: 0xc0000000 > > +(j721e_evm_a72) aarch64-linux-objcopy: warning: u-boot: unsupported GN= U_PROPERTY_TYPE (5) type: 0xc0000000 > > +(j721e_evm_a72) aarch64-linux-objdump: warning: u-boot: unsupported GN= U_PROPERTY_TYPE (5) type: 0xc0000000 > > +(j721e_evm_a72) aarch64-linux-nm: warning: u-boot: unsupported GNU_PRO= PERTY_TYPE (5) type: 0xc0000000 > > +(j721e_evm_a72) tools/relocate-rela: bad rela bounds > > +(j721e_evm_a72) make[1]: *** [u-boot-nodtb.bin] Error 1 > > +(j721e_evm_a72) make: *** [sub-make] Error 2 >=20 > I did not notice this, as I'm currently compiling locally with gcc-10. > Using gcc-9.4 also from kernel.org also works fine. gcc-9.2 throws these > errors. I suppose this also means I should finish my local move up to gcc-11.1.0 to match CI, then, or whack the last of my local scripts to fire off Docker rather than not. > Should we switch to gcc-9.4? I could also add something like this as a > dependency to the Kconfig entries: >=20 > https://patchwork.kernel.org/project/linux-arm-kernel/patch/2020061912355= 0.48098-1-broonie@kernel.org/ We have GCC_VERSION available in Kconfig, so yes, lets go with that in a v6. --=20 Tom --EcGdEOzhxf5S15/x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEw4rUACgkQFHw5/5Y0 tywzkQv/f5NuZVWvXAOFET5t2A6ZKWVtsrV2SGhTFuah/Mvfd8Z5WTHns7CySc9s OjrON0zMOiNHQBapfznfvhagCYOdrdUpfq82QQJYVfyqrC/g56Bp30RbSzoFY16F rPXjZbIuZhWIvDT5PlNKn4scKAHOa2bQbLyiYdGQ7ZgiZGeQYL3cEP4pxuSZCEJk kHwGgQqSxteMb4a5ym9ZZTe4tdtSwLf1SnMF/KebXKNZJdCTbWHolFHiqNegOjNr SqcwoIxDUiFj0opBqiA3YbmhPk91ATIJorMoRwWh0dZm53p8CIrh/+9lTbdVfu2J GclKEqLwVNc9iQchKA9QiMs60e4+VrFOTVhJ44HPEN6mOmafIX8QPaj1+X0lhUAY oPQ6VkK/XLtJR7FKTldF9irxF8zrkMgoCAeeiDkNPtslQo+STiZNg7LzU9syX0eF jPFYwxsI8qt4Y9CKPTG+lVjx0DbdFXK34YIbdZKYqQiqlU8SFszN0fMeOHeN4e6w 9H1WkY35 =ClL1 -----END PGP SIGNATURE----- --EcGdEOzhxf5S15/x--