From: Tom Rini <trini@konsulko.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Andreas Schwab <schwab@suse.de>,
U-Boot Mailing List <u-boot@lists.denx.de>,
Pragnesh Patel <pragnesh.patel@sifive.com>,
Bhargav Shah <bhargavshah1988@gmail.com>
Subject: Re: [PATCH] lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build
Date: Thu, 2 Sep 2021 20:54:06 -0400 [thread overview]
Message-ID: <20210903005406.GH858@bill-the-cat> (raw)
In-Reply-To: <CAEUhbmUhQK0ihuc2=YS2DbJJ5ZA8DagLQXOqRQZmZ7gE0x7WbQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
On Fri, Sep 03, 2021 at 08:52:18AM +0800, Bin Meng wrote:
> On Fri, Sep 3, 2021 at 6:42 AM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Aug 17, 2021 at 12:51:34PM +0200, Andreas Schwab wrote:
> >
> > > CONFIG_MMC_SPI_CRC_ON needs the crc16 functions, but it was not included
> > > in an SPL build. For non-SPL builds, crc16.o is already added
> > > unconditionally. This also removes CONFIG_SPL_YMODEM_SUPPORT from the
> > > sifive board configs, which is only relevant for some ARM boards and was
> > > only set for its side effect of adding crc16.o.
> >
> > Applied to u-boot/next, thanks!
>
> I thought I replied this email, but it seems not.
>
> This patch is missing SoB tag.
Yes, I also saw, but it's also small / obvious enough that it's not
worrisome. By which I also mean, if you check through the linux kernel,
there's still an occasional no-SoB tag commit. Not often, but non-zero.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-09-03 0:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 10:51 [PATCH] lib: add crc16.o if CONFIG_MMC_SPI_CRC_ON for SPL build Andreas Schwab
2021-09-02 22:42 ` Tom Rini
2021-09-03 0:52 ` Bin Meng
2021-09-03 0:54 ` Tom Rini [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-08-09 13:02 Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210903005406.GH858@bill-the-cat \
--to=trini@konsulko.com \
--cc=bhargavshah1988@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=pragnesh.patel@sifive.com \
--cc=schwab@suse.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox