From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AB8FC433F5 for ; Sat, 4 Sep 2021 15:08:45 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1877A60E9B for ; Sat, 4 Sep 2021 15:08:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1877A60E9B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3A83181FC6; Sat, 4 Sep 2021 17:08:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="pUrSQe92"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 163B381D1F; Sat, 4 Sep 2021 17:08:39 +0200 (CEST) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E4C9981FC6 for ; Sat, 4 Sep 2021 17:08:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id g11so1787864qtk.5 for ; Sat, 04 Sep 2021 08:08:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=6f1mJSntnK0GWvl9Zzbljys0SXix5beCpQ1J7rJmIwU=; b=pUrSQe92HbBurkoh+m6vA1MFGb0B5ZwClJaEUYiNc/f8GK6MiLz9Srg3Od997jPJC1 KkuvOWvjpoP8KvR1zb479KZPzte0GwM/BGJkl43Zns3+r0aG0QxW2rm3MR3u6IcgN1wC 5TM9tJSSb0ns7lgKSkf5yV1DS9lk/9ohTcLsw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=6f1mJSntnK0GWvl9Zzbljys0SXix5beCpQ1J7rJmIwU=; b=PmQePjjEBuAslNYLRmBOdDjoVS0MwvMDHFwWldXztcHu4uveJVWX3hQizGnyILlT1u yb2/52XUoCrNlxTDpi5ODTCX9NP/dDanXTMkaPjenkiKLvuZJZziQXVsMj6eaayy3DhQ UM5x6MBfSSeJ1zFYL2Eb9pVM773+yyh/iUUAjBk16Xw5KqmHNanM+UU4xsVDaEJIKT+E s7JW8/gqVw7i8dDVi6Eo/9sNIpGEEqIPZASxDYTydA7UQvmgcrqeN5pq0bPCztQ/ZuaF F0CNkP7DAoo2rxn0QT6k/7LdyrkZ/78rXwHtHJ4k6zRs3fN1ubxNuMvyc0AEbA1aucx2 FnKg== X-Gm-Message-State: AOAM5317jKsN/JeTME4Yf+WW2gXlhYc/L250yd2YpQzKH5esbPfuShba uQBJrQMKfFJwWDKwPLXVJhanrfZe8TJQ8Zrc X-Google-Smtp-Source: ABdhPJwgq5xXcZGF8G1ZfhPQ1QHCKLGsyDnFBaNx0mvFWUzSkJh3U7p2jjQq6r4fS+zA4gfhAJylig== X-Received: by 2002:ac8:7599:: with SMTP id s25mr3773369qtq.317.1630768113565; Sat, 04 Sep 2021 08:08:33 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-eda5-0c2a-e600-b83e.res6.spectrum.com. [2603:6081:7b01:cbda:eda5:c2a:e600:b83e]) by smtp.gmail.com with ESMTPSA id 75sm1797577qko.100.2021.09.04.08.08.32 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Sep 2021 08:08:32 -0700 (PDT) Date: Sat, 4 Sep 2021 11:08:30 -0400 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Heiko Schocher Subject: Re: [PATCH 19/23] i2c: Convert CONFIG_POWER_I2C et al to Kconfig Message-ID: <20210904150830.GA13888@bill-the-cat> References: <20210808182031.3747270-1-sjg@chromium.org> <20210808182031.3747270-20-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cWoXeonUoKmBZSoM" Content-Disposition: inline In-Reply-To: <20210808182031.3747270-20-sjg@chromium.org> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 08, 2021 at 12:20:27PM -0600, Simon Glass wrote: > This converts the following to Kconfig: > CONFIG_POWER_I2C > CONFIG_POWER_LEGACY >=20 > They are handled at the same time due to a dependency between them. > Update the Makefile rule to use legacy power only in U-Boot proper. >=20 > Unfortunately a separate rule is needed in SPL to be able to build legacy > power. All of this can be cleaned up when boards are migrated or removed. >=20 > Signed-off-by: Simon Glass > Reviewed-by: Jaehoon Chung I'm taking care of this now, but JFYI, this is actually a tricky conversion where the "hack print" tool I've posted before is required, along with running it with and without CONFIG_SPL_BUILD defined. At issue here is that a number of platforms play games with only setting CONFIG_POWER in SPL, really but moveconfig.py doesn't catch it. You can see this with the buildman size/bloat functions and that main U-Boot nows includes drivers/power/power_core.c and its non-DM non-configurable pmic cmd. --=20 Tom --cWoXeonUoKmBZSoM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEzi+sACgkQFHw5/5Y0 tyyZzwv9HEeYyGchhfr8yBOwDCpMSSZDTbFJ9z2bCkvHH5j2HFd46dVtPHxufJNX C7MVODOD1mafejSReJMCYH5JFpr0Y8v2FgviZ4bio6wcjHF+xFzSlmj6lCJt47bf wriBCGSjRib15afcJ6nJdmG2rdk6+ycDvkI23e4GJuLIUQkFgwhB6wwJiV49/HJ4 YCnhsmg4CAgCT6huzbdIGphVO/1ghvmoPS9AUEnxDu+Dj37psHcAGhx0xqDL3Qxc TbYz7LiGYijnZcQbDSyuhkF5ZDqPgWZKlFvnTRQvbPaqHT6ExCM0hkYctBx4Vv4Y 3fusB8MgcpkfPrGxGBGFYq7POUAo5FybupkatxS2KvEilXf8P+7jPMYueigZ5YPZ 3XfJ2oPH3sKGPE4tiGQMQ+uymqzO4ajVeDk5lWwM+bPoYb4HBfn10B5hKuCjcy+S jmLIafWh5GAXGcQMYp9wpfq4EhCAwwDOJhdW4D4LI09B6qh7keRH1TAXIx3lra78 WXLJCy6e =OccN -----END PGP SIGNATURE----- --cWoXeonUoKmBZSoM--