From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB9AC433EF for ; Sat, 4 Sep 2021 16:09:14 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2DBD601FF for ; Sat, 4 Sep 2021 16:09:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A2DBD601FF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 53853832A0; Sat, 4 Sep 2021 18:09:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="knNQmfNQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8BC12832A0; Sat, 4 Sep 2021 18:09:09 +0200 (CEST) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9FDA88329E for ; Sat, 4 Sep 2021 18:09:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2c.google.com with SMTP id p17so1525200qvo.8 for ; Sat, 04 Sep 2021 09:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=n7x8kXtIJ+Vdbapm8VqtTqg3yJVvmcBVZd2b9ddNI4g=; b=knNQmfNQjU3xUWCqfJyXE9Zj3r13RpU8ASfM34KPga+7yOBQu5u19hMvHFtX0msKht FstkFqumuiVoabkY47qu4pqYFK5Hr1ZZFH5DQJKz54l5Ub9hev5kLjxj7lokfd7uPX+O fQ3jdwEXwSO5pIZ4PiF0hSIT5ZH0hbc2CW/+k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=n7x8kXtIJ+Vdbapm8VqtTqg3yJVvmcBVZd2b9ddNI4g=; b=Y8COBH5BpmVFCJ7MsfjxOzYhyV8I/lJG3CgJMFOoBkfgqoXqf8ejO39K8xGVJs/TO8 nz1LxP2S+RdJDNkVOXGSBD4LlgjpF6HedOZrdthrBYRegzHvithZf2flRT2dkzaAdkBf tbEr6l+Ogeu4WclTHxODb8e9VNzYvOknJhCSVKdPzVINekK/aH6o2IN9pz/o5dsjdMUH IjIU701o9dqAwXuDsD+N5go+PDVltGkR3HxiHTRe2wXIIUud8x9/ccZVr3knzfTVfsI0 Qz4Z/hSXhdlVNwk5arE84Q+7HzQaaSXgitD7XKWra9+yMOkBL5Sn/tELjEtqv+mATO9/ 6/fA== X-Gm-Message-State: AOAM533cQSCJPgMIinWk2qZzc4hUKHlPi4g/r1KU0/6l7z7JVtWCfFZl vw4reDJdKV5Mic2uIg2x77LLmQ== X-Google-Smtp-Source: ABdhPJxfdI8xGSpL0IcUpCQosGU3F4uA+ksrguLlYDdnNs1eOhP/Od1Ru5gHlVoNgT1B8dhY312IMg== X-Received: by 2002:a0c:c34f:: with SMTP id j15mr4527832qvi.15.1630771744156; Sat, 04 Sep 2021 09:09:04 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-eda5-0c2a-e600-b83e.res6.spectrum.com. [2603:6081:7b01:cbda:eda5:c2a:e600:b83e]) by smtp.gmail.com with ESMTPSA id h68sm2014005qkf.126.2021.09.04.09.09.03 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Sep 2021 09:09:03 -0700 (PDT) Date: Sat, 4 Sep 2021 12:09:01 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Simon Glass , Simon Goldschmidt Subject: Re: [PATCH 02/14] lmb: Use CONFIG_LMB_*_REGIONS only if they are defined Message-ID: <20210904160901.GF12964@bill-the-cat> References: <20210829225126.GM858@bill-the-cat> <20210829231145.GN858@bill-the-cat> <95c965a3-2da8-1212-fb54-0d5628d7743b@denx.de> <20210830120102.GO858@bill-the-cat> <678a77d9-356a-e924-da8e-102fba938ee3@denx.de> <20210904141019.GC12964@bill-the-cat> <72c92d4d-f064-f7f3-dd4b-57cf994009db@denx.de> <20210904151714.GE12964@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aZoGpuMECXJckB41" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --aZoGpuMECXJckB41 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 04, 2021 at 06:05:50PM +0200, Marek Vasut wrote: > On 9/4/21 5:17 PM, Tom Rini wrote: > > On Sat, Sep 04, 2021 at 05:15:45PM +0200, Marek Vasut wrote: > > > On 9/4/21 4:10 PM, Tom Rini wrote: > > > [...] > > >=20 > > > > > > > > At this point, I think you should rework things to stop mak= ing > > > > > > > > CONFIG_LMB be optional, it should be a def_bool y. > > > > > > >=20 > > > > > > > I disagree, see above. > > > > > >=20 > > > > > > The only reason "tools-only_defconfig" builds a useless u-boot = binary > > > > > > today is in CI where it would be more work than it's worth to m= ake CI > > > > > > exclude that from the build list. But if you want to just do t= hat > > > > > > instead, I'll also accept adding -x tools-only to the azure/git= lab jobs > > > > > > that build all other architectures, as tools-only is tested in = its own > > > > > > build job, for it's only valid build target. > > > > >=20 > > > > > The tools-only build is also used elsewhere, to build just that, = tools. > > > >=20 > > > > I've repeatedly explained myself and what I'm looking for in v2 of = this > > > > series. I will summarize one last time. The "tools-only_defconfig= " is > > > > for tools, only. Building anything other than the "tools-only" tar= get > > > > isn't useful. In U-Boot itself, LMB is required as that is how we > > > > prevent a number of CVEs from being trivial to exploit. v2 of this > > > > series needs to drop patches 1 and 2 of v1 of this series. It can > > > > further do any of: > > > > 1. Nothing else. > > > > 2. Add tools-only to the exclude list in the "build everything else= " CI > > > > job. > > > > 3. Make CONFIG_LMB be def_bool y. > > >=20 > > > If tools-only is for tools, only, then why should it enable LMB ? > > > The tools are userspace tools, they do not need LMB, and so LMB can be > > > disabled. > > >=20 > > > This is the part which is unclear to me. > >=20 > > I don't know why it's unclear to you at this point, sorry. >=20 > Well why exactly does a userspace program require LMB enabled ? > What does LMB protect in there ? obviously not U-Boot. I feel like you've lost the thread. --=20 Tom --aZoGpuMECXJckB41 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEzmhoACgkQFHw5/5Y0 tywjeQv9HGDs0kcNUgHebxb9Hny44LRBac5fZlmJDfVDGx8wi7hsQ8G7JO2MKi2T 1eDhrwOhdGjbKtxcwlCV/WOovOhwXpruodSNT0qDEqe2RGJ7qgXj6DaEExrD9S6d 5xyvBRVz5wa+pOzFlypx2uGmAMg5rVdl8wiwwjyiaxcTzJ2kxm/YzQx2taZLpFnD 3p4N/pjGt2XwUMe3PG++dpV0NJToQWEfg8xL35aiUf1bmzw7UHLBoLDzZ6vt+rsR dWu7e7Hewd34ko/L3AO6GO5a1YWiuPsZ2EJI3AtbEsMiU37a/xZRmS3hxlM2PcWP bG0dHBz0h/U7HZD1O7j+rt7fEJGiJeWKEDiIaNwAwaH4L/zI9K9IA/Wrc6D6sr50 rZCufu5Bh1caiQ9YEpDScXvHyGdEQs1qMbXj1mjm7fT+w3HeH2FS8ScX/HHtZqo4 oZ/wtJ0T4lPen8x7iqfWjkd2tX6QBpDfg7Fmjr1MnOODhoEK4uwiy89l9S/CQs8v Xp0uUeO9 =2Sow -----END PGP SIGNATURE----- --aZoGpuMECXJckB41--