Re: [PATCH 3/5] arm: Disable ATAGs support

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1873 bytes --]

On Sat, Sep 04, 2021 at 06:29:50PM +0200, Stephan Gerhold wrote:
> Hi Tom,
> 
> On Mon, Aug 30, 2021 at 09:16:30AM -0400, Tom Rini wrote:
> > With the exception of nokia_rx51 and icnova-a20-swac, disable ATAG
> > support.  A large number of platforms had enabled support but never
> > supported a kernel so old as to require it.  Further, some platforms are
> > old enough to support both, but are well supported by devicetree
> > booting, and have been for a number of years.  This is because some of
> > the ATAGs related functions have been re-used to provide the same kind
> > of information, but for devicetree or just generally to inform the user.
> > When needed still, rename these functions to get_board_revision()
> > instead, to avoid conflicts.  In other cases, these functions were
> > simply unused, so drop them.
> > 
> > Cc: Andre Przywara <andre.przywara@arm.com>
> > Cc: Jagan Teki <jagan@amarulasolutions.com>
> > Cc: Phil Sutter <phil@nwl.cc>
> > Cc: Stefan Bosch <stefan_b@posteo.net>
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > [...]
> > ---
> >  include/configs/stemmy.h                      |  3 --
> > [...]
> > +++ b/include/configs/stemmy.h
> > @@ -23,7 +23,4 @@
> >  #define CONFIG_SYS_L2_PL310
> >  #define CONFIG_SYS_PL310_BASE		0xa0412000
> >  
> > -/* Generate initrd atag for downstream kernel (others are copied in stemmy.c) */
> > -#define CONFIG_INITRD_TAG
> > -
> >  #endif
> 
> Please keep this option for the stemmy board. It's still used
> occasionally to boot the original downstream/vendor kernel which is
> currently still necessary to charge the battery on these devices.
> 
> See commit e2f82f93 ("board: stemmy: Copy atags for booting
> downstream/vendor kernel") [1] for details.

OK, I'll re-work this to also keep ATAGS support on stemmy when merging,
thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]