From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FED9C433EF for ; Sat, 4 Sep 2021 17:40:03 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46CEF60E93 for ; Sat, 4 Sep 2021 17:40:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 46CEF60E93 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E8C5A83130; Sat, 4 Sep 2021 19:39:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="iviZHV/N"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 06BA083167; Sat, 4 Sep 2021 19:39:58 +0200 (CEST) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6C5EE82E7D for ; Sat, 4 Sep 2021 19:39:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2c.google.com with SMTP id bn14so1606078qvb.12 for ; Sat, 04 Sep 2021 10:39:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=e0jSzQzJ7QySp9fh8jFUWz66sMXR5/iBYPoulVf+Fvc=; b=iviZHV/NJp70DXNQuf5/NUxWuMCNEkH7Pdr3uJLuj2IrRrm+0x9KFgMlaFnJvPPfiN iZukjDNZ1m8+AuJqa1F6x2YXvQMy8hGjtMKFgZWQnJcSjmQCUzQ07XRn5Tu0pyqafWX/ jVuRUUXMHNzWp2I5AEuDuIXPpzBZerbcP87Vo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=e0jSzQzJ7QySp9fh8jFUWz66sMXR5/iBYPoulVf+Fvc=; b=ubeL55dBZzTKh9wr0QhMIuQuQZWoz4lUce0W9Za7nU6lpuOURVMed566fL+Go7SYQO hZcb95v1hQY8n5bhnI0rtdo+N9agIFi1bH67TdVHksoo40mFNADD62ALT4He+AtXpqnw QhbkadWZbth2cqWoqwnGWs5X/Iba/lpkyvZWm49jkkZA4uJdkJZ6UNnHcoTWWzm05uI8 sTFCxoP1Hwqve/CQKTMag/Bztex46CNZ0pxukJgQafU/Zt0A0ZbD3GFoEPu2bmXjdDdR JhEgsPOBiCjUcMvaRukG28fRgnA6g9eEJ1xKqYGVQAOYWL/fCqo1WCtfeD8KShWnZepz eAow== X-Gm-Message-State: AOAM532fTzoMaWuAtyjiANTEL8zovQaOEKZ2Km2AqwcahLNmEIVjT7NG HOp+6mte27N4Jg/HfWBxEEcvMA== X-Google-Smtp-Source: ABdhPJxX7Co8IlblkRD9e5+3wlF/7zm+edy0vGd0SN4UqU390wHzDXEVKnL+Lk9sTnVxTzzdz1AnPw== X-Received: by 2002:a0c:b394:: with SMTP id t20mr4868160qve.58.1630777193201; Sat, 04 Sep 2021 10:39:53 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-eda5-0c2a-e600-b83e.res6.spectrum.com. [2603:6081:7b01:cbda:eda5:c2a:e600:b83e]) by smtp.gmail.com with ESMTPSA id x25sm1905925qtj.77.2021.09.04.10.39.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 Sep 2021 10:39:52 -0700 (PDT) Date: Sat, 4 Sep 2021 13:39:49 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: U-Boot Mailing List , Alexander Graf , Masahisa Kojima , Ilias Apalodimas , AKASHI Takahiro , Simon Glass Subject: Re: Pull request for efi-2021-10-rc4 Message-ID: <20210904173949.GI12964@bill-the-cat> References: <61e2e1cc-b474-84dd-eceb-bb86a59972be@gmx.de> <20210904130111.GA12964@bill-the-cat> <20210904143722.GD12964@bill-the-cat> <46CAD3CD-41FA-43B9-9099-225711B754E1@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mXDO3udm/xYWQeMQ" Content-Disposition: inline In-Reply-To: <46CAD3CD-41FA-43B9-9099-225711B754E1@gmx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --mXDO3udm/xYWQeMQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Sep 04, 2021 at 07:03:48PM +0200, Heinrich Schuchardt wrote: >=20 >=20 > Am 4. September 2021 16:37:22 MESZ schrieb Tom Rini : > >On Sat, Sep 04, 2021 at 03:08:38PM +0200, Heinrich Schuchardt wrote: > >>=20 > >>=20 > >> Am 4. September 2021 15:01:11 MESZ schrieb Tom Rini : > >> >On Sat, Sep 04, 2021 at 11:56:47AM +0200, Heinrich Schuchardt wrote: > >> > > >> >> Dear Tom, > >> >>=20 > >> >> The following changes since commit 94509b79b13e69c209199af0757afbde= 8d2ebd6d: > >> >>=20 > >> >> btrfs: Use default subvolume as filesystem root (2021-09-01 10:11= :24 > >> >> -0400) > >> >>=20 > >> >> are available in the Git repository at: > >> >>=20 > >> >> https://source.denx.de/u-boot/custodians/u-boot-efi.git > >> >> tags/efi-2021-10-rc4 > >> >>=20 > >> >> for you to fetch changes up to 1dfa494610c5469cc28cf1f8538abf4be6c0= 0324: > >> >>=20 > >> >> efi_loader: fix efi_tcg2_hash_log_extend_event() parameter check > >> >> (2021-09-04 09:15:09 +0200) > >> >>=20 > >> >> ---------------------------------------------------------------- > >> >> Pull request for efi-2021-10-rc4 > >> >>=20 > >> >> Documentation: > >> >>=20 > >> >> Remove invalid reference to configuration variable in UEFI doc > >> >>=20 > >> >> UEFI: > >> >>=20 > >> >> Parameter checks for the EFI_TCG2_PROTOCOL > >> >> Improve support of preseeding UEFI variables. > >> >> Correct the calculation of the size of loaded images. > >> >> Allow for UEFI images with zero VirtualSize > >> >>=20 > >> >> ---------------------------------------------------------------- > >> >> Heinrich Schuchardt (5): > >> >> efi_loader: sections with zero VirtualSize > >> >> efi_loader: rounding of image size > >> >> efi_loader: don't load signature database from file > >> >> efi_loader: efi_auth_var_type for AuditMode, DeployedMode > >> >> efi_loader: correct determination of secure boot state > >> >>=20 > >> >> Masahisa Kojima (3): > >> >> efi_loader: add missing parameter check for EFI_TCG2_PROTOCOL= api > >> >> efi_loader: fix boot_service_capability_min calculation > >> >> efi_loader: fix efi_tcg2_hash_log_extend_event() parameter ch= eck > >> > > >> >And I don't see Simon's revert in here either. And he asked you about > >> >that yesterday: > >> >https://lore.kernel.org/r/CAPnjgZ3eRdjF0jb9S-cJK6y+feuyRyWf0hNkf2triB= 4DR4UFBQ@mail.gmail.com/ > >> > > >> >So at this point, are you asserting there is nothing to revert? > >>=20 > >> Never. Simons "revert" is breaking functionality. The concept for supo= rting blobs in devicetrees supplied by a prior bootstage has not been defin= ed yet. > > > >And to be clearer, reverting something that was introduced in one rc in > >a later rc isn't breaking functionality. U-Boot releases (well, the > >non-rc ones for sure) are on a very regular schedule. External projects > >may not depend on some feature introduced at -rcN unless they're willing > >to accept that some changes could happen before release. > > >=20 > There is no value delivered by Simon's series. Neither does the image get= smaller nor does it fix anything. If he wants to enforce a design, it must= work for all use cases. But this requires some conceptual work. Yes, and what's the rush to not do the conceptual work? If I recall part of the thread correctly, yes, Simon didn't get his objections in before the patches were merged, but it was early enough in the release cycle that taking a step back and reverting was a reasonable request. What he had said wouldn't have changed if he had gotten the email out a few days earlier. So yes, please merge Simon's revert, or post and merge new more minimal revert that brings things to the same functional end. There are objections to this implementation, and thus far Simon has been responding all of the requests to better clarify all of the related code and concepts that have been asked of him, so that in the end an implementation that fulfills all of the technical requirements can be created, that hopefully leaves all parties satisfied. --=20 Tom --mXDO3udm/xYWQeMQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGyBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEzr2IACgkQFHw5/5Y0 tyyugAv1GJYSwZyHpCTjMBQhOhz9g9/DToc/6zxWHw265swhLyTYqebJ25hHZQCj FI8jY8zwYoeNd96Tje/t3LOrqei7gtdohviJ0P3dzOzih7xT1+AYEubg7Vs6Ehek Lj8EdU/QV+x/SCVvcBcsKf+FFQHoH2Wvwao6jseB9emnEedHI3OdcCYRrql0YauM CGD9g8+0mG+RXC2C1NCWUGavn65dYO/h64lZlXqBVcW7RVa7eVM/DSo6nVtwb4Fu mK67w7TM4drXawsiPjHmUtPUHS9l9EwAC1ich2sKcV8qh+O+TZeBpEjKFpoiHJrT KR+UcTToV4ipxyArCyw7pDbKG5mXxFe/FjVzqiGYlYtYnwS2LeCPUyQcNys6l+8c A9i9NV39k9YgVQtfkbAcczkQPLjWcR9mUdmPtNVaJn7HycjvG8WYl2a6s2RfPHEH 4yaUhvwPYSfNxjA2Bl0cC2HRX2ob6jIFaQWMQU1xu7eB/b579x0KqDfUameDqP37 xMsGS1M= =hmqZ -----END PGP SIGNATURE----- --mXDO3udm/xYWQeMQ--