From: "Marek Behún" <marek.behun@nic.cz>
To: Stefan Roese <sr@denx.de>
Cc: u-boot@lists.denx.de, pali@kernel.org,
Chris Packham <judge.packham@gmail.com>,
Baruch Siach <baruch@tkos.co.il>, Mario Six <mario.six@gdsys.cc>,
Jon Nettleton <jon@solid-run.com>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH u-boot-marvell v2 15/39] tools: kwboot: Allow greater timeout when executing header code
Date: Tue, 7 Sep 2021 23:53:09 +0200 [thread overview]
Message-ID: <20210907235309.4e2b3305@thinkpad> (raw)
In-Reply-To: <20210907095837.14042-16-marek.behun@nic.cz>
On Tue, 7 Sep 2021 11:58:13 +0200
Marek Behún <marek.behun@nic.cz> wrote:
> +static uint64_t
> +_now(void)
> +{
> + struct timespec ts;
> +
> + if (clock_gettime(CLOCK_MONOTONIC, &ts)) {
> + static int err_print;
> +
> + if (!err_print) {
> + perror("clock_gettime() does not work");
> + err_print = 1;
> + }
> +
> + /* this will just make the timeout not work */
> + return -1ULL;
> + }
> +
> + return ts.tv_sec * 1000 + (ts.tv_nsec + 500000) / 1000000;
We need u64 literal here to avoid overflow:
return ts.tv_sec * 1000ULL + (ts.tv_nsec + 500000) / 1000000;
Marek
next prev parent reply other threads:[~2021-09-07 21:53 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 9:57 [PATCH u-boot-marvell v2 00/39] kwboot higher baudrate Marek Behún
2021-09-07 9:57 ` [PATCH u-boot-marvell v2 01/39] tools: kwbimage: Fix printf format warning Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 02/39] tools: kwboot: Fix buffer overflow in kwboot_terminal() Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 03/39] tools: kwboot: Make the quit sequence buffer const Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 04/39] tools: kwboot: Refactor and fix writing buffer Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 05/39] tools: kwboot: Print version information header Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 06/39] tools: kwboot: Fix kwboot_xm_sendblock() function when kwboot_tty_recv() fails Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 07/39] tools: kwboot: Fix return type of kwboot_xm_makeblock() function Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 08/39] tools: kwboot: Fix comparison of integers with different size Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 09/39] tools: kwboot: Fix printing progress Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 10/39] tools: kwboot: Print newline on error when progress was not completed Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 11/39] tools: kwboot: Split sending image into header and data stages Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 12/39] tools: kwboot: Use a function to check whether received byte is a Xmodem reply Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 13/39] tools: kwboot: Allow non-xmodem text output from BootROM only in a specific case Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 14/39] tools: kwboot: Print new line after SPL output Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 15/39] tools: kwboot: Allow greater timeout when executing header code Marek Behún
2021-09-07 21:53 ` Marek Behún [this message]
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 16/39] tools: kwboot: Prevent waiting indefinitely if no xmodem reply is received Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 19/39] tools: kwbimage: Simplify iteration over version 1 optional headers Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 20/39] tools: kwboot: Don't patch image header if signed Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 21/39] tools: kwboot: Patch source address in image header Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 22/39] tools: kwboot: Patch destination address to DDR area for SPI image Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 23/39] tools: kwbimage: Refactor image_version() Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 24/39] tools: kwbimage: Refactor kwbimage header size determination Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 25/39] tools: kwbimage: Update comments describing kwbimage v1 structures Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 26/39] tools: kwboot: Round up header size to 128 B when patching Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 27/39] tools: kwboot: Explicitly check against size of struct main_hdr_v1 Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 28/39] tools: kwboot: Support higher baudrates when booting via UART Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 30/39] tools: kwboot: Check whether baudrate was set to requested value Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 32/39] kwboot: Disable tty interbyte timeout Marek Behún
2021-09-07 11:51 ` Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 33/39] tools: kwboot: Disable non-blocking mode Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 34/39] tools: kwboot: Cosmetic fix Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 35/39] tools: kwboot: Avoid code repetition in kwboot_img_patch() Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 36/39] tools: kwboot: Update file header Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 37/39] tools: kwboot: Add Pali and Marek as authors Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 38/39] doc/kwboot.1: Update man page Marek Behún
2021-09-07 9:58 ` [PATCH u-boot-marvell v2 39/39] MAINTAINERS: Add entry for kwbimage / kwboot tools Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210907235309.4e2b3305@thinkpad \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=jon@solid-run.com \
--cc=judge.packham@gmail.com \
--cc=mario.six@gdsys.cc \
--cc=pali@kernel.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox