From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9381AC433EF for ; Wed, 8 Sep 2021 13:57:57 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E390161100 for ; Wed, 8 Sep 2021 13:57:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E390161100 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 90D388336D; Wed, 8 Sep 2021 15:57:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="K/BrWsvu"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2112C83383; Wed, 8 Sep 2021 15:57:52 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5F09283368 for ; Wed, 8 Sep 2021 15:57:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2a.google.com with SMTP id w8so749782qvt.0 for ; Wed, 08 Sep 2021 06:57:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2dkvl+GRdM/DTJOYnfhgTiMlch2iAHhsV8B+mo8IPn8=; b=K/BrWsvuVNEDt6LaQQuzfhXN+6YgqZVkZY4KIubptNn7CIDnrnI0fTDo0HoPzD7bn0 DEUJtIKQPW1A3Y025Yv0Ao2pgz8B1cO6Sb2YjqLSENU5HIPJGfXRhV3gavlOHrEiyv2c YTnXcKmHlhuHQg8Ij4l1ilZS+ZAjLZMpiziMs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2dkvl+GRdM/DTJOYnfhgTiMlch2iAHhsV8B+mo8IPn8=; b=v+y4l+KlgwJM1w2ZUFwr8DKIZpc2WB1v/uaKbqAu+pBjNCJEWaGNsCTiSK91jVGnT4 DKEMVyVRabZl1mTxhCx0IlJmLpMqkbOzbgNVHcUjWDqC/vXsaFh7m/7U+EwNETpx2kIV z8Oakyg1nHFTaVcdVABP4LQE3Cdd7F2mGH80VhkZuk9HJ4ftu2VwvNP4Z0W52ciS7o/J rDxCmL+MOTAfy1ZRKkdAYZ7TkcCBjYNOBCpQQ2kQ3payWvu9ROLs8I0j4Ph6EPhIOvIu sb26mSheXTfZw963RaiB7immuqd4FsnMWI7kg1wF8AccxLQN9xS40w/F0znWONDUt80N W5xw== X-Gm-Message-State: AOAM533v3Le3lgU+A2cMBtysfS+Vu0GfIpGgQWLBL9xl1CaN5B7DxCXF EeqaRcu4YJy9xicaEpAkOEwoJe2WR4Dubg== X-Google-Smtp-Source: ABdhPJwChAea1fMppJ2SiFjKcOmU8RkSZ2BOgS04gyMzfBrHwQGnQ59tAS1M4VRB5+ZFS+BAt0LC2A== X-Received: by 2002:a0c:b356:: with SMTP id a22mr4056384qvf.7.1631109467112; Wed, 08 Sep 2021 06:57:47 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-717f-113d-7bb2-2acf.res6.spectrum.com. [2603:6081:7b01:cbda:717f:113d:7bb2:2acf]) by smtp.gmail.com with ESMTPSA id l11sm1502068qtv.88.2021.09.08.06.57.46 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Sep 2021 06:57:46 -0700 (PDT) Date: Wed, 8 Sep 2021 09:57:44 -0400 From: Tom Rini To: Kristian Amlie Cc: u-boot@lists.denx.de, Liviu Dudau Subject: Re: [PATCH 1/1] ARM: vexpress_ca9x4: Reintroduce board in order to use with QEMU. Message-ID: <20210908135744.GD12964@bill-the-cat> References: <20210907063751.32363-1-kristian.amlie@northern.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZljC5FVPx7rxDQQ8" Content-Disposition: inline In-Reply-To: <20210907063751.32363-1-kristian.amlie@northern.tech> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --ZljC5FVPx7rxDQQ8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 07, 2021 at 08:37:51AM +0200, Kristian Amlie wrote: > vexpress_ca9x4 is seemingly the only board except for qemu_arm which > is able to run U-Boot correctly, using the `-M vexpress-a9` option to > QEMU. Building for qemu_arm and running qemu-system-arm with the `-M > virt` argument has a number of downsides, most importantly that it > only supports virtio storage drivers. This significantly reduces its > usefulness in testing memory card and Flash solutions, especially when > the tested images are from a third party source. >=20 > So therefore we reintroduce the vexpress_ca9x4 board in this commit, > with the explicit goal of using it with QEMU. >=20 > A number of differences to note from the original: >=20 > * Since the board was apparently unmaintained, I have now set myself > as the maintainer. >=20 > * The board has been converted to use the driver model, which was the > reason it was removed in the first place. >=20 > * The vexpress_ca15_tc2 and vexpress_ca5x2 boards, which were removed > in the same commit, are not necessary for the QEMU use case, and > have been omitted. >=20 > * An `mmc0` alias was introduced in the dts file. The mmc is not > detected correctly without this, now that it's based on the device > tree instead of the board's init function. >=20 > * A couple of other nodes were removed because they were problematic > when trying to run the UEFI bootmgr. Once again, the primary use > case here is QEMU, and these nodes are not needed for that to work. >=20 > * Unnecessary board init code has been removed, thanks to driver model > and device tree. >=20 > * `CONFIG_OF_EMBED` has been enabled. I know this goes against > recommended practice, but there doesn't seem to be any other way to > pass the dtb to U-Boot in the QEMU scenario. Using the -dtb argument > does not work, I suppose because U-Boot doesn't use the same > mechanics as the kernel when it's booting. This is something that should get looked at and figured out, but is separate. I thought this did work on Pi for example. > * Load addresses have been changed to fit QEMU use case. >=20 > People wanting to get a more detailed, yet somewhat isolated, diff > between this and the original, can run this command: >=20 > git diff c6c26a05b89f25a06e7562f8c2071b60fd0c9eac~1 -- \ > $( git diff-tree --diff-filter=3DA -r --name-only HEAD~1 HEAD) >=20 > (Make sure to either check out this commit first, or replace HEAD with > the commit ID of this commit) >=20 > Signed-off-by: Kristian Amlie I'm glad to see this come back. A request: [snip] > diff --git a/include/configs/vexpress_ca9x4.h b/include/configs/vexpress_= ca9x4.h > new file mode 100644 > index 0000000000..8157a5868d > --- /dev/null > +++ b/include/configs/vexpress_ca9x4.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ > +/* > + * (C) Copyright 2011 Linaro > + * Ryan Harkin, > + * > + * Configuration for Versatile Express. Parts were derived from other ARM > + * configurations. > + */ > + > +#ifndef __VEXPRESS_CA9X4_H > +#define __VEXPRESS_CA9X4_H > + > +#define CONFIG_VEXPRESS_ORIGINAL_MEMORY_MAP > +#include "vexpress_common.h" CONFIG_VEXPRESS_ORIGINAL_MEMORY_MAP looks to just be polluting the CONFIG namespace, it's only then used.. > + > +#endif /* VEXPRESS_CA9X4_H */ > diff --git a/include/configs/vexpress_common.h b/include/configs/vexpress= _common.h > index b131480e5b..99a5dd064a 100644 > --- a/include/configs/vexpress_common.h > +++ b/include/configs/vexpress_common.h > @@ -169,29 +169,10 @@ > func(DHCP, dhcp, na) > #include > =20 > -#ifdef CONFIG_VEXPRESS_ORIGINAL_MEMORY_MAP > -#define CONFIG_PLATFORM_ENV_SETTINGS \ > - "loadaddr=3D0x80008000\0" \ > - "ramdisk_addr_r=3D0x61000000\0" \ > - "kernel_addr=3D0x44100000\0" \ > - "ramdisk_addr=3D0x44800000\0" \ > - "maxramdisk=3D0x1800000\0" \ > - "pxefile_addr_r=3D0x88000000\0" \ > - "scriptaddr=3D0x88000000\0" \ > - "kernel_addr_r=3D0x80008000\0" > -#elif defined(CONFIG_VEXPRESS_EXTENDED_MEMORY_MAP) > -#define CONFIG_PLATFORM_ENV_SETTINGS \ > - "loadaddr=3D0xa0008000\0" \ > - "ramdisk_addr_r=3D0x81000000\0" \ > - "kernel_addr=3D0x0c100000\0" \ > - "ramdisk_addr=3D0x0c800000\0" \ > - "maxramdisk=3D0x1800000\0" \ > - "pxefile_addr_r=3D0xa8000000\0" \ > - "scriptaddr=3D0xa8000000\0" \ > - "kernel_addr_r=3D0xa0008000\0" > -#endif > #define CONFIG_EXTRA_ENV_SETTINGS \ > - CONFIG_PLATFORM_ENV_SETTINGS \ > + "kernel_addr_r=3D0x60100000\0" \ > + "fdt_addr_r=3D0x60000000\0" \ > + "bootargs=3Dconsole=3Dtty0 console=3DttyAMA0,38400n8\0" \ > BOOTENV \ > "console=3DttyAMA0,38400n8\0" \ > "dram=3D1024M\0" \ around here, to modify what the default environment is. Can you please do a patch (a follow-up to this is fine) to rename it to just VEXPRESS_ORIGINAL_MEMORY_MAP ? Thanks! --=20 Tom --ZljC5FVPx7rxDQQ8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE4wVgACgkQFHw5/5Y0 tyxSgAv9GZotWZJPNVa5RjjhNpwduXxOcUd1//eguvUFaJfARPKcvebO4D2/bVUM q+TVZcXJKFH6rnkflUkZsB1+4K1cZ3Gnx9SS5PB1KOAS7sL1+LnTKGNeqW2oq1kl rRtyD6waR7HNKmpA0Rveppr9cXDWDoz8zL24RaJFvXscDldogzYAGwM7jsoK+Db2 VOBbTK/zJUX/xXeWXrZ7edHXqMye4OVVTHVFLvqyRNkCyZq3gbcD2D5+VW3x04c2 i1wgpDE9BRS9Rfe1vP+ykzOJITCUkP3325mL/GcdIFlCIR9RPxU95dhlURTB2lAq KAXSdoCBpRW79Fa5a25RkaHS0/RSlZkkhqYM23gxssyX4qwFRDMFZnuIGZnm/Q8E Ph4B417VFVLnIVTADJX2six7dFZXjBdh8Oujp0YepIjUYD6uK4w0gxqlCmhXtCrU YUTWx9Etr9MiN/71DH9oBQTw3jARQRC29LO4UMGUIyk1D3DhCUABUq0WnINqlnJ3 omI7oU4V =odUc -----END PGP SIGNATURE----- --ZljC5FVPx7rxDQQ8--