From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FD8BC433EF for ; Thu, 9 Sep 2021 01:25:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F4356108D for ; Thu, 9 Sep 2021 01:25:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F4356108D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 696FB833DF; Thu, 9 Sep 2021 03:25:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="KvysXmNP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B5C608339D; Thu, 9 Sep 2021 03:25:17 +0200 (CEST) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9601B8339A for ; Thu, 9 Sep 2021 03:25:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf31.google.com with SMTP id a12so204740qvz.4 for ; Wed, 08 Sep 2021 18:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=BIJdrgePHhfQ0GvEIHZiHiVngkTGdbsJdQCK45lw5NM=; b=KvysXmNPznybGZdZDW3SIpyvQoKpIy83ymMoJeJpGLz+pWWxZiNeHveeYecc5FD2Oy G+5s6Ye9BW6JiYAwDa5rOkGL3t1O80Wm5YY4uZuoun//rtjAoRXxLm9wRP0bbGHNu2y4 YRkZoqKt/xIxYCJkI+lQi5LHrFlaOS8BAlFYI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=BIJdrgePHhfQ0GvEIHZiHiVngkTGdbsJdQCK45lw5NM=; b=WfUwBVYDrXetuH1vtP5Rt0UcKXG1eRb40qoxoKV3bTTpWL7ghbaClF8ZjlLY8Y2tBu QIZtZtFX3VsBW3GTAXpf/don/wn8xV0QuLRlJpwQuI/TcXkrNXWrIBqMmX0vry5zTIBA cD62fyUF60kbDb/ByO60+oTGpteNKtqSvQA+MkZPiqORcucT40PoxNQUlm6YLj3K/V0m M3yPjEsqTo0mVb8vulq9N3RYm4NuGzjpo9FnTTXMVGdCwCoBt4Ny37rcycY9TQZvQlnu WUZOo1Hl7yU1mVKG4rK8U7LPpnE0rFk4cv6WkMHkl/B6GYF0ATHwP+x2oqkplKUfpVUS yaYw== X-Gm-Message-State: AOAM530WoQ4od4aBtScCBUIIUXDAN/V/BZJBgRDWRbdEZdD5MINVbsM4 Ecy4w6skrANmGogz3HXWAuIrfw== X-Google-Smtp-Source: ABdhPJzA/8bJh/qZCUgYFKZpoabZVP3JsJa9qTBZfPo/P0RVUZKcXNfUe9s8UksSODWOsOkEpP91Bw== X-Received: by 2002:ad4:40d1:: with SMTP id x17mr450834qvp.7.1631150713263; Wed, 08 Sep 2021 18:25:13 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f91e-f867-d1bc-397d.res6.spectrum.com. [2603:6081:7b01:cbda:f91e:f867:d1bc:397d]) by smtp.gmail.com with ESMTPSA id a24sm180621qto.18.2021.09.08.18.25.11 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Sep 2021 18:25:11 -0700 (PDT) Date: Wed, 8 Sep 2021 21:25:09 -0400 From: Tom Rini To: Alexandru Gagniuc Cc: u-boot@lists.denx.de, sjg@chromium.org Subject: Re: [PATCH v2 1/6] common: Remove unused CONFIG_FIT_SHAxxx selectors Message-ID: <20210909012509.GP12964@bill-the-cat> References: <20210903005422.1336362-1-mr.nuke.me@gmail.com> <20210903005422.1336362-2-mr.nuke.me@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Iy2CUD6FdotTkhwY" Content-Disposition: inline In-Reply-To: <20210903005422.1336362-2-mr.nuke.me@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Iy2CUD6FdotTkhwY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2021 at 07:54:17PM -0500, Alexandru Gagniuc wrote: > Originally CONFIG_FIT_SHAxxx enabled specific SHA algos for and only > for hash_calculate() in common/image-fit.c. However, since commit > 14f061dcb1 ("image: Drop IMAGE_ENABLE_SHAxxx"), > the correct selector was changed to CONFIG_SHAxxx. >=20 > The extra "_FIT_" variants are neither used, nor needed. Remove them. > One defconfig disables FIT_SHA256, which is now changed to 'SHA256'. >=20 > CMD_MVEBU_BUBT needs to select select SHA256 to avoid undefined > references to "sha256_*()". bubt.c needs sha256, so this selection is > correct. It is not clear why this problem did not manifest before. >=20 > Note that SHA selection in SPL is broken for this exact reason. There > is no corresponding SPL_SHAxxx. Fixing this is is beyond the scope of > this change. >=20 > Signed-off-by: Alexandru Gagniuc After making SHA256 be an implied option under FIT, to mirror the current behavior, applied to u-boot/master, thanks! --=20 Tom --Iy2CUD6FdotTkhwY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE5YmwACgkQFHw5/5Y0 tyxb2wv/Ty0vHfIPLO8iEP8nT+qN/FJ/g0u1rjhe1WFCOrRWRIls7ZE8QYNa/l6S +wqRWM73ek44PcpxdI3SfWA58AQPD8MfDamFhN+8mzYlGWHflo5AolVTlQvrFfzP drcrAkefJ95jCeenmJrnHPVcqWtU7WsvX8rVAj/U4x+AQPgF45r9OhC2nmRLKejX d9sX6e+HVW3R1VbKwKRPCfxzML/pDZuSaKvbC/+sMB2XcliL1lMWJzeG2CbcfoNK q4kr3SM5i2NXHw/yc4wxiewTbDYqHjT92qWqNjvE7WIhSf4BbT25hT2Jp5zX2fCN AMmNPNqpz5Wx9jn+IjjWliMUx8iDq+5W917+DyxBVV0MuZ1z4LoH/E6K/9JXhEaX u6+1SvuK+WBt65pPrHIJ72Hb6g1vgI+sjOWRLAQE65pZxx1beQXguJ5VqEcrftQx msUqtPuzbGdTO7ZwLXQxzvydzcd43Hhn+5MmeYQYQbeNBUb9rnJhgt4gH+J66Kh3 /GTpDRKo =lliQ -----END PGP SIGNATURE----- --Iy2CUD6FdotTkhwY--