From: Tom Rini <trini@konsulko.com>
To: Alexandru Gagniuc <mr.nuke.me@gmail.com>
Cc: u-boot@lists.denx.de, sjg@chromium.org
Subject: Re: [PATCH v2 4/6] common: Move MD5 hash to hash_algo[] array.
Date: Wed, 8 Sep 2021 21:25:26 -0400 [thread overview]
Message-ID: <20210909012526.GS12964@bill-the-cat> (raw)
In-Reply-To: <20210903005422.1336362-5-mr.nuke.me@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Thu, Sep 02, 2021 at 07:54:20PM -0500, Alexandru Gagniuc wrote:
> MD5 is being called directly in some places, but it is not available
> via hash_lookup_algo("md5"). This is inconsistent with other hasing
> routines. To resolve this, add an "md5" entry to hash_algos[].
>
> The #ifdef clause looks funnier than those for other entries. This is
> because both MD5 and SPL_MD5 configs exist, whereas the other hashes
> do not have "SPL_" entries. The long term plan is to get rid of the
> ifdefs, so those should not be expected to survive much longer.
>
> The md5 entry does not have .hash_init/update/finish members. That's
> okay because hash_progressive_lookup_algo() will catch that, and
> return -EPROTONOSUPPORT, while hash_lookup_algo() will return the
> correct pointer.
>
> Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
With a fix to CONFIG_IS_ENABLED(MD5), applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-09-09 1:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 0:54 [PATCH v2 0/6] Fix FIT hash algos in SPL (Fixes v2021.10-rc3) Alexandru Gagniuc
2021-09-03 0:54 ` [PATCH v2 1/6] common: Remove unused CONFIG_FIT_SHAxxx selectors Alexandru Gagniuc
2021-09-09 1:25 ` Tom Rini
2021-09-03 0:54 ` [PATCH v2 2/6] lib: Drop SHA512_ALGO in lieu of SHA512 Alexandru Gagniuc
2021-09-09 1:25 ` Tom Rini
2021-09-09 13:58 ` Andreas Schwab
2021-09-03 0:54 ` [PATCH v2 3/6] common/spl: Drop [ST]PL_HASH_SUPPORT in favor of [ST]PL_HASH Alexandru Gagniuc
2021-09-09 1:25 ` Tom Rini
2021-09-03 0:54 ` [PATCH v2 4/6] common: Move MD5 hash to hash_algo[] array Alexandru Gagniuc
2021-09-09 1:25 ` Tom Rini [this message]
2021-09-03 0:54 ` [PATCH v2 5/6] image: Drop if/elseif hash selection in calculate_hash() Alexandru Gagniuc
2021-09-09 1:25 ` Tom Rini
2021-09-03 0:54 ` [PATCH v2 6/6] image: Drop IMAGE_ENABLE_{MD5, CRC32} #defines Alexandru Gagniuc
2021-09-09 1:25 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909012526.GS12964@bill-the-cat \
--to=trini@konsulko.com \
--cc=mr.nuke.me@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox