From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D504FC433EF for ; Thu, 9 Sep 2021 01:25:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5742760724 for ; Thu, 9 Sep 2021 01:25:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5742760724 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 38F298348F; Thu, 9 Sep 2021 03:25:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="rj5OJ1G3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F229F8339D; Thu, 9 Sep 2021 03:25:37 +0200 (CEST) Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2733D8348F for ; Thu, 9 Sep 2021 03:25:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82a.google.com with SMTP id l24so92873qtj.4 for ; Wed, 08 Sep 2021 18:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=2gfsGSG0dGbC1TX1zbCvUp4bNTKc0ErGcuz8LiObhCM=; b=rj5OJ1G3j0Y8P9sRd7Vfbp/vRuzjzBwJxnneKN5hY9rEq4q+3cMSMluZMqUtr9nZIs avV0aEYyieWuy2EdjwzWq1g1M4YEoDHt7S2jGP1a/ZHzJTvDosVUQ2JWXFe0mY3snoqm 7xEvtMos8ZbfUkJtrhcd2hcxRiCJtMdnQ8wdQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=2gfsGSG0dGbC1TX1zbCvUp4bNTKc0ErGcuz8LiObhCM=; b=zK4thWBQmCrkbeL8z+ihi70OzHuwmOQutYG9vC+l/WYe9jGIwf4jh/W5ML42Uiq1WQ BERfj/JDhcIPW5UpZBVCIb6c3j1EuL9lWeG9vZGQ8s6X7FwfBX9ZuQGhICxbAfR5Nc05 Q+BJEQPgJtPCzmKhwuauPGGU/SFsL3C07XKY/0Tpz8K0snQREsT4jUTjhYLbFlbaH/rJ VC49dplrNilsgbhTE2UriuAUhfMDM04KtUWTz6p3f2rjgx+YOdBQyTyc+4kSuCYORO60 kp9/pTwIk/VMAIVJ6E8JBtSf/H8ct3aSy7BiBtXXMw6kSSI1UZuF2si0DWHoCP2+J5yz od7w== X-Gm-Message-State: AOAM531cJ1srSfLwpl6qZNWBp1AlEcp48HzlQAgbvs7J21DEYaozejAo WXr6iefciX3JdehtK7XQAcU36QjjukOUyA== X-Google-Smtp-Source: ABdhPJyuG86bpyfXS3z1WXeCip5P6terr+Ifap5LMfSZvU4pkXoSEzAYkDSOudEfRkBMFFoZxjbscw== X-Received: by 2002:ac8:71ca:: with SMTP id i10mr594416qtp.62.1631150728824; Wed, 08 Sep 2021 18:25:28 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f91e-f867-d1bc-397d.res6.spectrum.com. [2603:6081:7b01:cbda:f91e:f867:d1bc:397d]) by smtp.gmail.com with ESMTPSA id s204sm271462qke.109.2021.09.08.18.25.27 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 08 Sep 2021 18:25:28 -0700 (PDT) Date: Wed, 8 Sep 2021 21:25:26 -0400 From: Tom Rini To: Alexandru Gagniuc Cc: u-boot@lists.denx.de, sjg@chromium.org Subject: Re: [PATCH v2 4/6] common: Move MD5 hash to hash_algo[] array. Message-ID: <20210909012526.GS12964@bill-the-cat> References: <20210903005422.1336362-1-mr.nuke.me@gmail.com> <20210903005422.1336362-5-mr.nuke.me@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CBkz1G+j/QuiWKyF" Content-Disposition: inline In-Reply-To: <20210903005422.1336362-5-mr.nuke.me@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --CBkz1G+j/QuiWKyF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 02, 2021 at 07:54:20PM -0500, Alexandru Gagniuc wrote: > MD5 is being called directly in some places, but it is not available > via hash_lookup_algo("md5"). This is inconsistent with other hasing > routines. To resolve this, add an "md5" entry to hash_algos[]. >=20 > The #ifdef clause looks funnier than those for other entries. This is > because both MD5 and SPL_MD5 configs exist, whereas the other hashes > do not have "SPL_" entries. The long term plan is to get rid of the > ifdefs, so those should not be expected to survive much longer. >=20 > The md5 entry does not have .hash_init/update/finish members. That's > okay because hash_progressive_lookup_algo() will catch that, and > return -EPROTONOSUPPORT, while hash_lookup_algo() will return the > correct pointer. >=20 > Signed-off-by: Alexandru Gagniuc With a fix to CONFIG_IS_ENABLED(MD5), applied to u-boot/master, thanks! --=20 Tom --CBkz1G+j/QuiWKyF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE5YoYACgkQFHw5/5Y0 tyxsAQv/d22u0PQv27A8v15D7ia/Wdwvs9G7+pC/r7lzy4lnvRl34GJzKinNioJj KFt0x3K1AbZQEfwYuFgZfUcl9m4tYQ9UmFHqCPGVRbk/uixfB7CA7R2fcAS63Puj jO/epJ/SfZlAdET9Vxw7my1dsssZ/pxXmnYHsk9peXHOPaN5jHspyPghBP4oJBEr zIH0axDmQG528hU7aE1meo0eBixhh0V7AZIUMbfXA0f5sXMWfrjJBn/fgQWZgHwE 5bTUYkxRRHS4bOF9RMYPwabtDaK26gul4UX0w8wMu1sP/FTGO1prImw83l9NaL9p rfKse/12ybYVLZ8rraQyVdXyZhqJIHbPoFWZW0v1UJUU0FM5YN+TrZAdzFev7kHb i6LtGWz62VrTAt/AYAExX+wxX8LGgL4HsyElxyBiHFkTHKRZgsfeImZf+3P8hl/T m6POVl9XurF82aY1Itt1OSc51Jh7G2TrvB6KRcgGD5rpqFo1B4VcBffZTosbIZnl LrHy4nmM =5sn3 -----END PGP SIGNATURE----- --CBkz1G+j/QuiWKyF--