From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3782FC433EF for ; Thu, 9 Sep 2021 08:30:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2825C60E76 for ; Thu, 9 Sep 2021 08:30:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2825C60E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DE8AA82ECC; Thu, 9 Sep 2021 10:30:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="CjsN7h6l"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C7C4982ECD; Thu, 9 Sep 2021 10:30:50 +0200 (CEST) Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 68FF582EBB for ; Thu, 9 Sep 2021 10:30:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x62e.google.com with SMTP id j2so599958pll.1 for ; Thu, 09 Sep 2021 01:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=0wzaOqGaHhP0nMQ3VS7aSQUpZRFMYwxcwMexw4KIoxM=; b=CjsN7h6lmqU8/MQKAjgEhmIaYcA0/rF77L7NRM9vuF4NmYiyjdZghYNnsN6hbCgFHi aciM3r8levN5Buc0tBWzPLpZ8AYpdk1hc4NYcWhl//kUWpx9p3H1ba9B61g/vzS4ECtb HxXWOAt3lUYvwMwCyJcY1fqhH+887KszvBDCqmZ+aUttp+o22LCEGafOVsVebnZrMgxJ xPVXyJd2gR3NIfHdPf2WWcQeevhif6Hgwntd4HDABWmxCel03i/qiQEyqhr4a/3GC5KT hX3PR34TDLqf5s49AbWhJ8IUE4E91Evk+M3w+V/UcJAjotMl3PTS5LmqB530+56Jr5Oz e7dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=0wzaOqGaHhP0nMQ3VS7aSQUpZRFMYwxcwMexw4KIoxM=; b=mHwtqr1D/4e3ffjIwAoF15cNJ0mtUqcla1Ms4mRcxQhJVJSpwageNp0kPznXB6CEi7 Pwx1G/EbvDnWhkqqy+0HIXfn+t/Wq0RA+BfZX11ZKFgm7MPSXgt4yTcXML1dMfgTWo4d P2v3aqX9NKZGToIvAqDBF7ZlWxYWRX9U7FvnEsRfQyCSYwqkN8O96c2zCRb7Grdo+Xkv ecBxmHEK40dtpAw5wnMrTeg7pTXf/8e6e4OmA2Vp0i2xKOgqtRVz4+K67h22to6vnyrb as+w4qiwbdImtNfQYVgJG9kuLOa2235s+MalyrZRNCSDIWsvOAxECfR9lq189jm1/AFJ gdFw== X-Gm-Message-State: AOAM531sbFP6tYdTrYcdTEheVuYdCkHdTEgBbgHtFhS2IedV9H0ygHzV 6z069ifUddGMXIrGMCQN/NacIQ== X-Google-Smtp-Source: ABdhPJytHQk8DIJ8IXxC5pe6c7on2EdZy7oPVTBgVbQ6aQxojfHkr7ujPhK5yVBfhmGszwY9qTiQOg== X-Received: by 2002:a17:902:a982:b0:13a:8c8:8a30 with SMTP id bh2-20020a170902a98200b0013a08c88a30mr1833422plb.86.1631176241498; Thu, 09 Sep 2021 01:30:41 -0700 (PDT) Received: from laputa (p784a2304.tkyea130.ap.so-net.ne.jp. [120.74.35.4]) by smtp.gmail.com with ESMTPSA id 132sm1426535pfy.190.2021.09.09.01.30.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Sep 2021 01:30:40 -0700 (PDT) Date: Thu, 9 Sep 2021 17:30:36 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: Tom Rini , Simon Glass , Vagrant Cascadian , u-boot@lists.denx.de, Sughosh Ganu Subject: Re: [PATCH 1/1] configs: add mkeficapsule to tools-only_defconfig Message-ID: <20210909083036.GD56666@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , Tom Rini , Simon Glass , Vagrant Cascadian , u-boot@lists.denx.de, Sughosh Ganu References: <20210909052710.22015-1-xypron.glpk@gmx.de> <20210909060939.GC56666@laputa> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, Sep 09, 2021 at 09:27:50AM +0200, Heinrich Schuchardt wrote: > On 9/9/21 8:09 AM, AKASHI Takahiro wrote: > > On Thu, Sep 09, 2021 at 07:27:10AM +0200, Heinrich Schuchardt wrote: > > > mkeficapsule is used to create capsules for UEFI firmware update. > > > To ease inclusion into U-Boot tools packages of Linux distributions we > > > should add it to the tools-only_defconfig. > > > > > > Provide dummy values for CONFIG_AVB_BUF_ADDR, CONFIG_AVB_BUF_SIZE to > > > satisfy Kconfig. > > > > > > Suggested-by: Vagrant Cascadian > > > Signed-off-by: Heinrich Schuchardt > > > --- > > > configs/tools-only_defconfig | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig > > > index f54bc1802c..8a20d3fb05 100644 > > > --- a/configs/tools-only_defconfig > > > +++ b/configs/tools-only_defconfig > > > @@ -5,6 +5,8 @@ CONFIG_ANDROID_BOOT_IMAGE=y > > > CONFIG_FIT=y > > > CONFIG_FIT_SIGNATURE=y > > > CONFIG_MISC_INIT_F=y > > > +CONFIG_AVB_BUF_ADDR=0x0 > > > +CONFIG_AVB_BUF_SIZE=0x8192 > > > # CONFIG_CMD_BOOTD is not set > > > # CONFIG_CMD_BOOTM is not set > > > # CONFIG_CMD_ELF is not set > > > @@ -29,4 +31,7 @@ CONFIG_SYSRESET=y > > > # CONFIG_VIRTIO_MMIO is not set > > > # CONFIG_VIRTIO_PCI is not set > > > # CONFIG_VIRTIO_SANDBOX is not set > > > -# CONFIG_EFI_LOADER is not set > > > +CONFIG_EFI_CAPSULE_ON_DISK=y > > > +CONFIG_EFI_CAPSULE_FIRMWARE_FIT=y > > > +CONFIG_EFI_CAPSULE_FIRMWARE_RAW=y > > > +CONFIG_EFI_CAPSULE_AUTHENTICATE=y > > > > I think that we should use the way that I suggested in my patch[1]. > > > > -Takahiro Akashi > > > > [1] https://lists.denx.de/pipermail/u-boot/2021-August/459349.html > > Your patch [1] still requires some rework: > https://patchwork.ozlabs.org/project/uboot/patch/20210831024659.53464-2-takahiro.akashi@linaro.org/ > > [1] changes what mkeficapsule looks like and this patch makes it > available in tools-only_defconfig? > > Aren't these two patches complementary? With my patch applied, the only option we need to compile mkeficapsule is: CONFIG_TOOLS_MKEFICAPSULE (and optionally CONFIG_TOOLS_LIBCRYPTO) There is no target-config dependency as you have expected. -Takahiro Akashi > Where do you see the conflict? > > Best regards > > Heinrich > > > > > > -- > > > 2.30.2 > > > >