From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED218C433EF for ; Thu, 9 Sep 2021 11:46:36 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3825B61167 for ; Thu, 9 Sep 2021 11:46:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3825B61167 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id F213B832A1; Thu, 9 Sep 2021 13:46:32 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="EILj6gcQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1FEC781D1F; Thu, 9 Sep 2021 13:46:29 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EADE483335 for ; Thu, 9 Sep 2021 13:46:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id m21so1356569qkm.13 for ; Thu, 09 Sep 2021 04:46:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Yf2fmGpAGvIfDPySKNriWxQjsPbgZXWge1BBnVl0eJU=; b=EILj6gcQ6YxwsvysoB505QQy39n7xe2qBMc2SKmVLnC583+KGj6LKSVPUQ3H6A6k6V vOwLEwWiwgHGuazjh96Ld9r5ETrbHW1ez5f+F/Vd5iss7cdT+7h1hGVRosbUx6T9kxQp p62poK8hZuvkqfVJqgH609dTg8irL05qgMZbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Yf2fmGpAGvIfDPySKNriWxQjsPbgZXWge1BBnVl0eJU=; b=TQqp6YneFR2LTmU+MeSD4Z+7UKd4w8bL+XNvehKSe8fAOPKTtlk2NIEinNrYR0LrVD LXBqo2fSPsP9Z9EeTbmP2Iym0RKXdCxTasX8cbgQW1Tued8iFNsUWvHHCzP0RDdHwnaU TfLkQrK8IjgOo6ik7iNRGFoTWICum+FaxP728LSYkBfl618CaGD7ctcrJbFkFx+baSQ6 SSjQq/HKggSCUa3pqKLL8cZE8rHg6Zw6oIi2Shd03wheuaFn6UK7urXB7Lc7Isl9V2TR HJ20fbqSZmJqcsW+qytN1erRgTOct4IMb5FV9UPa/GmoA2nw1khCrjGRpFNxOEwKvP+D A/sg== X-Gm-Message-State: AOAM532Q5gpotipQi5tgno7b9xkTWrvbCmWASw5VseL9/ukT5dx6g6Du I+cyeLHxakVuB4J/mPop0imzWA== X-Google-Smtp-Source: ABdhPJwVw/FkWlztq62aBpRwLz1VLcQy+ZWBe/XZyNFnd5W+VCcywXGw5RAC8B2Mj/BlvAkVP4GPsg== X-Received: by 2002:a05:620a:bc5:: with SMTP id s5mr2216243qki.47.1631187977703; Thu, 09 Sep 2021 04:46:17 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f91e-f867-d1bc-397d.res6.spectrum.com. [2603:6081:7b01:cbda:f91e:f867:d1bc:397d]) by smtp.gmail.com with ESMTPSA id e22sm944858qtm.10.2021.09.09.04.46.16 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Sep 2021 04:46:17 -0700 (PDT) Date: Thu, 9 Sep 2021 07:46:15 -0400 From: Tom Rini To: AKASHI Takahiro , Heinrich Schuchardt , Simon Glass , Vagrant Cascadian , u-boot@lists.denx.de, Sughosh Ganu Subject: Re: [PATCH 1/1] configs: add mkeficapsule to tools-only_defconfig Message-ID: <20210909114615.GW12964@bill-the-cat> References: <20210909052710.22015-1-xypron.glpk@gmx.de> <20210909060939.GC56666@laputa> <20210909083036.GD56666@laputa> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="xHR3sS2kvo5MIJEm" Content-Disposition: inline In-Reply-To: <20210909083036.GD56666@laputa> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --xHR3sS2kvo5MIJEm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 09, 2021 at 05:30:36PM +0900, AKASHI Takahiro wrote: > On Thu, Sep 09, 2021 at 09:27:50AM +0200, Heinrich Schuchardt wrote: > > On 9/9/21 8:09 AM, AKASHI Takahiro wrote: > > > On Thu, Sep 09, 2021 at 07:27:10AM +0200, Heinrich Schuchardt wrote: > > > > mkeficapsule is used to create capsules for UEFI firmware update. > > > > To ease inclusion into U-Boot tools packages of Linux distributions= we > > > > should add it to the tools-only_defconfig. > > > >=20 > > > > Provide dummy values for CONFIG_AVB_BUF_ADDR, CONFIG_AVB_BUF_SIZE to > > > > satisfy Kconfig. > > > >=20 > > > > Suggested-by: Vagrant Cascadian > > > > Signed-off-by: Heinrich Schuchardt > > > > --- > > > > configs/tools-only_defconfig | 7 ++++++- > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > >=20 > > > > diff --git a/configs/tools-only_defconfig b/configs/tools-only_defc= onfig > > > > index f54bc1802c..8a20d3fb05 100644 > > > > --- a/configs/tools-only_defconfig > > > > +++ b/configs/tools-only_defconfig > > > > @@ -5,6 +5,8 @@ CONFIG_ANDROID_BOOT_IMAGE=3Dy > > > > CONFIG_FIT=3Dy > > > > CONFIG_FIT_SIGNATURE=3Dy > > > > CONFIG_MISC_INIT_F=3Dy > > > > +CONFIG_AVB_BUF_ADDR=3D0x0 > > > > +CONFIG_AVB_BUF_SIZE=3D0x8192 > > > > # CONFIG_CMD_BOOTD is not set > > > > # CONFIG_CMD_BOOTM is not set > > > > # CONFIG_CMD_ELF is not set > > > > @@ -29,4 +31,7 @@ CONFIG_SYSRESET=3Dy > > > > # CONFIG_VIRTIO_MMIO is not set > > > > # CONFIG_VIRTIO_PCI is not set > > > > # CONFIG_VIRTIO_SANDBOX is not set > > > > -# CONFIG_EFI_LOADER is not set > > > > +CONFIG_EFI_CAPSULE_ON_DISK=3Dy > > > > +CONFIG_EFI_CAPSULE_FIRMWARE_FIT=3Dy > > > > +CONFIG_EFI_CAPSULE_FIRMWARE_RAW=3Dy > > > > +CONFIG_EFI_CAPSULE_AUTHENTICATE=3Dy > > >=20 > > > I think that we should use the way that I suggested in my patch[1]. > > >=20 > > > -Takahiro Akashi > > >=20 > > > [1] https://lists.denx.de/pipermail/u-boot/2021-August/459349.html > >=20 > > Your patch [1] still requires some rework: > > https://patchwork.ozlabs.org/project/uboot/patch/20210831024659.53464-2= -takahiro.akashi@linaro.org/ > >=20 > > [1] changes what mkeficapsule looks like and this patch makes it > > available in tools-only_defconfig? > >=20 > > Aren't these two patches complementary? >=20 > With my patch applied, the only option we need to compile mkeficapsule is: > CONFIG_TOOLS_MKEFICAPSULE > (and optionally CONFIG_TOOLS_LIBCRYPTO) >=20 > There is no target-config dependency as you have expected. There's two issues. First, the general one is that when just building host tools (typically to package up in a distribution of some sort), it shouldn't depend on how "U-Boot" was configured (set aside the default environment problem). CONFIG_TOOLS_LIBCRYPTO is the exception here as it's how we make things reproducible at least, with respect to libcrypto related requirements. The second is that "tools-only_defconfig" is what's used when configuring U-Boot (as tools care about CONFIG_TOOLS_LIBCRYPTO but also LOCALVERSION). That said, I would like to know why AVB stuff comes in for building mkeficapsule. Is there shared code? If so, are these dummy variables OK and not going to cause a problem? --=20 Tom --xHR3sS2kvo5MIJEm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE58/wACgkQFHw5/5Y0 tyyTJAwAhmSxxd9DB7dkCpLdpkaEENIlcE+NAgmgU2pFoTtia1PSJqAcc4HYyvOa b3a4Y77sJVjTCpSDR+BkI+6jfLlw7NAFQi0XdlAwyfC8lN9MT53NawqHYygXUHAE tMzV+Wd2qZIa6Dcy5339WOHep+rPsk3b48VQwVRzRWOkNqJVumXDP00jQ6p4nptD rD63pZAqFYzPwhLpSQSU4u8o1gFRTqJn89PoKOBXkNF7xW4kvxNGmDzEnor+3UsF Ga2eCm/p853O3XgIFgk9GnktTF6s14lqL6QGSQ+QDFcXYKk1HGAVnHFXxUnrtbCj karLKtv5BrVBlS5EHKxramJ3pl5X6Gx7xhIEBnXfi+oJLA1aGdjDqNCF2LFRiaxv 0haHfWYs8bW7ubydruRtvPsXPDQUeAjKeDiDSfeozu6Ggx0Cr/iyHamX/c5Cj9Cb zUJHSUB87b84NeL6SV3JB4gqBMpZ4XBhVawAuJgvTRD+jFhT2j9GMYvWEnlCB5xV dSg/716o =ABJP -----END PGP SIGNATURE----- --xHR3sS2kvo5MIJEm--