From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE149C433F5 for ; Thu, 9 Sep 2021 12:15:55 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 299FB60FE3 for ; Thu, 9 Sep 2021 12:15:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 299FB60FE3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 725DB83358; Thu, 9 Sep 2021 14:15:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="KM4Tn+c0"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B848183358; Thu, 9 Sep 2021 14:15:51 +0200 (CEST) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F206C83353 for ; Thu, 9 Sep 2021 14:15:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id 22so1479776qkg.2 for ; Thu, 09 Sep 2021 05:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=B2ewQJMWl/8loR04/V1ZYRVIscknkKR2xpR8EJrBiTY=; b=KM4Tn+c0/xt8MhinTZ7WMWwiqvL5oAmBhKRpFsKA8FpwrAjOEx1uMfCojH8DZrYyDT Ll1teQkvv8tS33b884mztOLY2rYHznltFnCJv3uT6awAmWyciOWMkDYviOgs8+guiGX8 Y6IJwbb2V2ak66dX9BZWIDWM3zxrUNTgMPpb0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=B2ewQJMWl/8loR04/V1ZYRVIscknkKR2xpR8EJrBiTY=; b=iYitqGcSQA2Slw9wHgBaOsvUw6p4NaAgXO7lRXk4ibqkNM0SgK8qAvElFYzCJVH6TU 4GNjVtT7wyLy4+g1a3FWn0+8kFgijYjodeZ7UILLKkWf0mF+E33wVPgSwnT+OFg6gOVX e0c9HeV9B6vbaBgdE4Zj6RWI2Z54XuFgEtGERfMPHBjHCH9ouboVoT3+bO59TtV9Z2yl hrdV43CmEoonSCRyJr708r+4uAukZVX8BvQChbsU9as12wdFhwosZim5DhimXihCNIxZ nDHoeBn1JpBUsKIQmJtUt334gvhdaZKNbv2xhjAbdfLBuWffnr8+tuTuzNsB+LfygBH4 R0Ig== X-Gm-Message-State: AOAM530Pb2x/+hcV9sifJ9eXvpkU2h5f/Xp20t1ynZZ2i2t17dhtti+U f4d/bZWKyDupDXaj0BaO/WgVfg== X-Google-Smtp-Source: ABdhPJxsLjnNiSHyej+wcDiwzn6FLiu2/htv6BO/usTs1ja6+tB/mGcEPKgtBuRWrQiYUFLut/Vn8g== X-Received: by 2002:a05:620a:2185:: with SMTP id g5mr2435240qka.244.1631189746669; Thu, 09 Sep 2021 05:15:46 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f91e-f867-d1bc-397d.res6.spectrum.com. [2603:6081:7b01:cbda:f91e:f867:d1bc:397d]) by smtp.gmail.com with ESMTPSA id b15sm1136438qka.107.2021.09.09.05.15.45 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Sep 2021 05:15:45 -0700 (PDT) Date: Thu, 9 Sep 2021 08:15:43 -0400 From: Tom Rini To: AKASHI Takahiro , Heinrich Schuchardt , Simon Glass , Vagrant Cascadian , u-boot@lists.denx.de, Sughosh Ganu Subject: Re: [PATCH 1/1] configs: add mkeficapsule to tools-only_defconfig Message-ID: <20210909121543.GZ12964@bill-the-cat> References: <20210909052710.22015-1-xypron.glpk@gmx.de> <20210909060939.GC56666@laputa> <20210909083036.GD56666@laputa> <20210909114615.GW12964@bill-the-cat> <20210909121023.GE56666@laputa> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RvF2KG9p4DaV8yF8" Content-Disposition: inline In-Reply-To: <20210909121023.GE56666@laputa> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --RvF2KG9p4DaV8yF8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 09, 2021 at 09:10:23PM +0900, AKASHI Takahiro wrote: > Tom, >=20 > On Thu, Sep 09, 2021 at 07:46:15AM -0400, Tom Rini wrote: > > On Thu, Sep 09, 2021 at 05:30:36PM +0900, AKASHI Takahiro wrote: > > > On Thu, Sep 09, 2021 at 09:27:50AM +0200, Heinrich Schuchardt wrote: > > > > On 9/9/21 8:09 AM, AKASHI Takahiro wrote: > > > > > On Thu, Sep 09, 2021 at 07:27:10AM +0200, Heinrich Schuchardt wro= te: > > > > > > mkeficapsule is used to create capsules for UEFI firmware updat= e. > > > > > > To ease inclusion into U-Boot tools packages of Linux distribut= ions we > > > > > > should add it to the tools-only_defconfig. > > > > > >=20 > > > > > > Provide dummy values for CONFIG_AVB_BUF_ADDR, CONFIG_AVB_BUF_SI= ZE to > > > > > > satisfy Kconfig. > > > > > >=20 > > > > > > Suggested-by: Vagrant Cascadian > > > > > > Signed-off-by: Heinrich Schuchardt > > > > > > --- > > > > > > configs/tools-only_defconfig | 7 ++++++- > > > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > >=20 > > > > > > diff --git a/configs/tools-only_defconfig b/configs/tools-only_= defconfig > > > > > > index f54bc1802c..8a20d3fb05 100644 > > > > > > --- a/configs/tools-only_defconfig > > > > > > +++ b/configs/tools-only_defconfig > > > > > > @@ -5,6 +5,8 @@ CONFIG_ANDROID_BOOT_IMAGE=3Dy > > > > > > CONFIG_FIT=3Dy > > > > > > CONFIG_FIT_SIGNATURE=3Dy > > > > > > CONFIG_MISC_INIT_F=3Dy > > > > > > +CONFIG_AVB_BUF_ADDR=3D0x0 > > > > > > +CONFIG_AVB_BUF_SIZE=3D0x8192 > > > > > > # CONFIG_CMD_BOOTD is not set > > > > > > # CONFIG_CMD_BOOTM is not set > > > > > > # CONFIG_CMD_ELF is not set > > > > > > @@ -29,4 +31,7 @@ CONFIG_SYSRESET=3Dy > > > > > > # CONFIG_VIRTIO_MMIO is not set > > > > > > # CONFIG_VIRTIO_PCI is not set > > > > > > # CONFIG_VIRTIO_SANDBOX is not set > > > > > > -# CONFIG_EFI_LOADER is not set > > > > > > +CONFIG_EFI_CAPSULE_ON_DISK=3Dy > > > > > > +CONFIG_EFI_CAPSULE_FIRMWARE_FIT=3Dy > > > > > > +CONFIG_EFI_CAPSULE_FIRMWARE_RAW=3Dy > > > > > > +CONFIG_EFI_CAPSULE_AUTHENTICATE=3Dy > > > > >=20 > > > > > I think that we should use the way that I suggested in my patch[1= ]. > > > > >=20 > > > > > -Takahiro Akashi > > > > >=20 > > > > > [1] https://lists.denx.de/pipermail/u-boot/2021-August/459349.html > > > >=20 > > > > Your patch [1] still requires some rework: > > > > https://patchwork.ozlabs.org/project/uboot/patch/20210831024659.534= 64-2-takahiro.akashi@linaro.org/ > > > >=20 > > > > [1] changes what mkeficapsule looks like and this patch makes it > > > > available in tools-only_defconfig? > > > >=20 > > > > Aren't these two patches complementary? > > >=20 > > > With my patch applied, the only option we need to compile mkeficapsul= e is: > > > CONFIG_TOOLS_MKEFICAPSULE > > > (and optionally CONFIG_TOOLS_LIBCRYPTO) > > >=20 > > > There is no target-config dependency as you have expected. > >=20 > > There's two issues. First, the general one is that when just building > > host tools (typically to package up in a distribution of some sort), it > > shouldn't depend on how "U-Boot" was configured (set aside the default > > environment problem). >=20 > I don't get your point. CONFIG_TOOLS_MKEFICAPSULE is only for building > mkeficapsule. It has nothing to do with U-Boot itself. My point is that "make tools-only" must build all the tools that would be packaged up in a distribution or otherwise sent to end users. It must not depend on (with the exceptions above) how we configured the build. > > CONFIG_TOOLS_LIBCRYPTO is the exception here as > > it's how we make things reproducible at least, with respect to libcrypto > > related requirements. The second is that "tools-only_defconfig" is > > what's used when configuring U-Boot (as tools care about > > CONFIG_TOOLS_LIBCRYPTO but also LOCALVERSION). >=20 > Again, I don't get your point. > Do you mean that we don't need "make tools-only_defconfig" for > "make tools"? I mean that for all real configurations of U-Boot, "make tools" (or, "make tools-only") is expected to work. And also that "tools-only_defconfig" isn't a real U-Boot config, but a dummy config to support distributions being able to build and package the host tools, and use the "tools-only" build target. > > That said, I would like to know why AVB stuff comes in for building > > mkeficapsule. Is there shared code? If so, are these dummy variables > > OK and not going to cause a problem? >=20 > What does AVB mean? My question here was to Heinrich, as he's adding dummy values for AVB, which is Android Verified Boot, to the tools-only_defconfig and I want to know what's pulling that in, and it matters for the host tools themselves in some way. I hope not, in which case the dummy values are fine. --=20 Tom --RvF2KG9p4DaV8yF8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE5+u8ACgkQFHw5/5Y0 tyzbOwv/e+t57ewspLOyEbxfgkBQZHgDUFmxSMDX2bcGtV3YBShcqa0T2OsXFMwi 7N5saV1NWRxy3cJcesE+KiyWkj2ppS3J239kxmcY4mSX1zm/f3ryb+4qYqs2KF3J URrH2epb/jZvrbGSO4hWA9IHfFv1Lg6UBLNrJhPevdprBEjGxuUvtvJyU8ypYUn5 Pe+wCj1n0YgpP8a+e38X7NPJH+ZQzuNvo9dFINpMtkZmzuzGO9AI1yItpmEb9lFq s9r3tOvI+3Pg+sNqbponYyeYuZeKRetGVLlgOJS7KPXilZQbl0SEr7G6F/+tYfFF 5AbjhcnRi401yoCn4UND3Uglr67/A1RX+Twl+BRTXTZx00ivPD8rb0UjtQ1xTmOa amTv0p8zvyfZ/KPHzQvzLoL59Ff5JqD3lR+zRReFh0nZlxtWah6TdOoHCcHom+9x vCwxyV08veXb4SNMAPYBV7Cyf1aPX+kMv/PFemHrEjVYsxiXnJgyNdT+1n/wtwdY Bg9+s/FT =cRcg -----END PGP SIGNATURE----- --RvF2KG9p4DaV8yF8--