From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42C9BC4321E for ; Thu, 9 Sep 2021 13:02:39 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6911561051 for ; Thu, 9 Sep 2021 13:02:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6911561051 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CB5C7833ED; Thu, 9 Sep 2021 15:02:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="p8LgeHRa"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 54341833EF; Thu, 9 Sep 2021 15:02:34 +0200 (CEST) Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E7580833E3 for ; Thu, 9 Sep 2021 15:02:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x82e.google.com with SMTP id r21so1270060qtw.11 for ; Thu, 09 Sep 2021 06:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KyObzP0oAnghKt3OkGejg2b9rnToFmNhSqBs86yNNfE=; b=p8LgeHRa+qoGLJYMHa/3nxAtw2SMIr4eEBMrSrSme8cO4C+OG4UjUMyzp0Q74TAyC3 vK2s1OkJEWPSL4V8k/JyCVBBhY9FdrUtAO923FzrUSefFArIONfPDjLOJs8qPAFX/aCg TxXinP6hooW09iNmDAveVy7GdXPy9ECVaujqI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KyObzP0oAnghKt3OkGejg2b9rnToFmNhSqBs86yNNfE=; b=kq2E7GQWgvJuyDBfbyB1wtCdEcw5qpXE+XeSMLC2v8k662+Mh11lBRrb036Mu42Txt oJb2KS/q+d/lVto0i/n5LzQtHV1lFA5g2UQq1shas99907BITyx8Qq2I9qdNr1hVorhw 1oUKnzBpU3fE2UrK+q33LObxYRvpPHuL76k6yCF8xwdnWQqcENKQIsrMVNL+DGMqEj4I wvhAOu/x9kyftDeh0AoeYJsdrsAlMxiESbmhDZ3dT7vHqqCd92PjMRz776PfGsBrIu1R mqzwBbCtXcQjos7euDXGqU3mlL8qPKQLo5KH0/eLuUPBK9yzNUFUbAuI5F3jKdTQTfHT eblA== X-Gm-Message-State: AOAM5303yQTwSSHuaTb57cd5pQEWv+jM95ps3TVzqWlO3lKO6nH56KVu isfHNngZvlhtgiANtzHy/7ozSw== X-Google-Smtp-Source: ABdhPJwdcA7dcRwPKsKTKOMJHr14xo7ac2Jp5kOoCW5CTgaE8yJmU3A20PFLeNObDdbnDkV1L5I8wg== X-Received: by 2002:ac8:4d48:: with SMTP id x8mr2679720qtv.414.1631192545684; Thu, 09 Sep 2021 06:02:25 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f91e-f867-d1bc-397d.res6.spectrum.com. [2603:6081:7b01:cbda:f91e:f867:d1bc:397d]) by smtp.gmail.com with ESMTPSA id i27sm1224207qkl.111.2021.09.09.06.02.24 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 09 Sep 2021 06:02:25 -0700 (PDT) Date: Thu, 9 Sep 2021 09:02:23 -0400 From: Tom Rini To: AKASHI Takahiro , Heinrich Schuchardt , Simon Glass , Vagrant Cascadian , u-boot@lists.denx.de, Sughosh Ganu Subject: Re: [PATCH 1/1] configs: add mkeficapsule to tools-only_defconfig Message-ID: <20210909130223.GB12964@bill-the-cat> References: <20210909052710.22015-1-xypron.glpk@gmx.de> <20210909060939.GC56666@laputa> <20210909083036.GD56666@laputa> <20210909114615.GW12964@bill-the-cat> <20210909121023.GE56666@laputa> <20210909121543.GZ12964@bill-the-cat> <20210909124721.GF56666@laputa> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NgVbDbWK8YZhIM7w" Content-Disposition: inline In-Reply-To: <20210909124721.GF56666@laputa> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --NgVbDbWK8YZhIM7w Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 09, 2021 at 09:47:21PM +0900, AKASHI Takahiro wrote: > On Thu, Sep 09, 2021 at 08:15:43AM -0400, Tom Rini wrote: > > On Thu, Sep 09, 2021 at 09:10:23PM +0900, AKASHI Takahiro wrote: > > > Tom, > > >=20 > > > On Thu, Sep 09, 2021 at 07:46:15AM -0400, Tom Rini wrote: > > > > On Thu, Sep 09, 2021 at 05:30:36PM +0900, AKASHI Takahiro wrote: > > > > > On Thu, Sep 09, 2021 at 09:27:50AM +0200, Heinrich Schuchardt wro= te: > > > > > > On 9/9/21 8:09 AM, AKASHI Takahiro wrote: > > > > > > > On Thu, Sep 09, 2021 at 07:27:10AM +0200, Heinrich Schuchardt= wrote: > > > > > > > > mkeficapsule is used to create capsules for UEFI firmware u= pdate. > > > > > > > > To ease inclusion into U-Boot tools packages of Linux distr= ibutions we > > > > > > > > should add it to the tools-only_defconfig. > > > > > > > >=20 > > > > > > > > Provide dummy values for CONFIG_AVB_BUF_ADDR, CONFIG_AVB_BU= F_SIZE to > > > > > > > > satisfy Kconfig. > > > > > > > >=20 > > > > > > > > Suggested-by: Vagrant Cascadian > > > > > > > > Signed-off-by: Heinrich Schuchardt > > > > > > > > --- > > > > > > > > configs/tools-only_defconfig | 7 ++++++- > > > > > > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > > >=20 > > > > > > > > diff --git a/configs/tools-only_defconfig b/configs/tools-o= nly_defconfig > > > > > > > > index f54bc1802c..8a20d3fb05 100644 > > > > > > > > --- a/configs/tools-only_defconfig > > > > > > > > +++ b/configs/tools-only_defconfig > > > > > > > > @@ -5,6 +5,8 @@ CONFIG_ANDROID_BOOT_IMAGE=3Dy > > > > > > > > CONFIG_FIT=3Dy > > > > > > > > CONFIG_FIT_SIGNATURE=3Dy > > > > > > > > CONFIG_MISC_INIT_F=3Dy > > > > > > > > +CONFIG_AVB_BUF_ADDR=3D0x0 > > > > > > > > +CONFIG_AVB_BUF_SIZE=3D0x8192 > > > > > > > > # CONFIG_CMD_BOOTD is not set > > > > > > > > # CONFIG_CMD_BOOTM is not set > > > > > > > > # CONFIG_CMD_ELF is not set > > > > > > > > @@ -29,4 +31,7 @@ CONFIG_SYSRESET=3Dy > > > > > > > > # CONFIG_VIRTIO_MMIO is not set > > > > > > > > # CONFIG_VIRTIO_PCI is not set > > > > > > > > # CONFIG_VIRTIO_SANDBOX is not set > > > > > > > > -# CONFIG_EFI_LOADER is not set > > > > > > > > +CONFIG_EFI_CAPSULE_ON_DISK=3Dy > > > > > > > > +CONFIG_EFI_CAPSULE_FIRMWARE_FIT=3Dy > > > > > > > > +CONFIG_EFI_CAPSULE_FIRMWARE_RAW=3Dy > > > > > > > > +CONFIG_EFI_CAPSULE_AUTHENTICATE=3Dy > > > > > > >=20 > > > > > > > I think that we should use the way that I suggested in my pat= ch[1]. > > > > > > >=20 > > > > > > > -Takahiro Akashi > > > > > > >=20 > > > > > > > [1] https://lists.denx.de/pipermail/u-boot/2021-August/459349= =2Ehtml > > > > > >=20 > > > > > > Your patch [1] still requires some rework: > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20210831024659= =2E53464-2-takahiro.akashi@linaro.org/ > > > > > >=20 > > > > > > [1] changes what mkeficapsule looks like and this patch makes it > > > > > > available in tools-only_defconfig? > > > > > >=20 > > > > > > Aren't these two patches complementary? > > > > >=20 > > > > > With my patch applied, the only option we need to compile mkefica= psule is: > > > > > CONFIG_TOOLS_MKEFICAPSULE > > > > > (and optionally CONFIG_TOOLS_LIBCRYPTO) > > > > >=20 > > > > > There is no target-config dependency as you have expected. > > > >=20 > > > > There's two issues. First, the general one is that when just build= ing > > > > host tools (typically to package up in a distribution of some sort)= , it > > > > shouldn't depend on how "U-Boot" was configured (set aside the defa= ult > > > > environment problem). > > >=20 > > > I don't get your point. CONFIG_TOOLS_MKEFICAPSULE is only for building > > > mkeficapsule. It has nothing to do with U-Boot itself. > >=20 > > My point is that "make tools-only" must build all the tools that would > > be packaged up in a distribution or otherwise sent to end users. It > > must not depend on (with the exceptions above) how we configured the > > build. >=20 > I can see bunch of "hostprogs-$(CONFIG_...) +=3D ...", and > some of them are not always built. > So what do you mean by "all the tools"? Our emails crossed. Yes, I was slightly wrong above, and the comment at the top of tools/Makefile: # A couple of simple rules: # # 1) Do not use target CONFIG_* options to enable or disable features in # host # tools. Only use the configs from tools/Kconfig # 2) It's okay to use target configs to disable building specific tools. # That's as long as the features of those tools aren't modified. are correct. So it's OK that the tool today depends on CONFIG_EFI_HAVE_CAPSULE_SUPPORT. > Which tools be packed in is totally up to a distro, isn't it? That's the difference between building and packaging. The best general answer is to build everything and package individually, when fine grained control is desired. But no, making more work on each distribution to get all tools built makes things harder, not easier, is the feedback we've gotten (and with my OE guy hat on, agree with). --=20 Tom --NgVbDbWK8YZhIM7w Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGyBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE6BdQACgkQFHw5/5Y0 tywu5wv460EWsFPoDYJQpgIzAi6bySdtWwX4X2rBXsWh9CwQ/Q/B8+g+/BEuN/om mJ3BLJQCDeBRysoCjxxaV5Lbav+euVljrFZTgyJXU6nTNo11ymf4+kkxTu32tx60 eGM6BJoKrvRKkeMrCmnPj7v4qxOnHoR4652Ywn+h+zSJJSN8dLM72XA6zxh9Z1hD 9o62JLx8tPI1joVoLkc0k9ZOp+RZY/qwbXvPrRoNgxap5Gxl3pqxYANQxNZg+T9Q hmg1lLWA7Xvw+KUqLcM0vj4gL5ZsLgapwdpf/30uX0YXtjQMwrhU4L9rxxSnm5JX RA8pvnX90/9hc9tVNH+Dx1+34DiA6A37/ybe7UX1wYJ3p3ZavZXGaqHAgIsmwrUj uXSRKnAbiADWLXKwuNE7c9gJv1X/0gFMN80Ktpd/vL4saFO8ImMd+3BCORaywgt8 UtbgbtvuQ7ejSFs+y0DtmeJrmbK5asUBZB2gdFmqneYRHvtIiElAgGcu5v5CIk1P vTdEiQ0= =LT0p -----END PGP SIGNATURE----- --NgVbDbWK8YZhIM7w--