From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36E0FC433F5 for ; Mon, 13 Sep 2021 16:17:13 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EB6660F4C for ; Mon, 13 Sep 2021 16:17:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8EB6660F4C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 823A983ACA; Mon, 13 Sep 2021 18:17:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="TfnaAPxQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CC60E83AC3; Mon, 13 Sep 2021 18:17:05 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E79B833CB for ; Mon, 13 Sep 2021 18:17:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id c19so8568699qte.7 for ; Mon, 13 Sep 2021 09:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qlznUdRYm1tAVaVFOYj/vTnR0l0IzmXo4JbVlfl9C5w=; b=TfnaAPxQgLsQT8Nx/FixKakjgUEbV7zjBYctorArx1krfVoXin56EumXuBf5oHHhiz jGwo9ufn6ZFowwSITDvc1KXrIu1/uxfXamEv5ZHzzPdOzKY6e26DJPcIEzBiexLGKJ1J J4MKQjaqxlcvdYMOM8aj91U6cfdY32KSgHqrM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qlznUdRYm1tAVaVFOYj/vTnR0l0IzmXo4JbVlfl9C5w=; b=k5ce1mPIueo8Js22GdQKvPuMbR3gl6vuV1pbLzCnvOGO0dL4kM/zHi5gg1lQrPD6E0 5Kk5MfX9nr4U1WaUMG/gZpanOeBJQdbG1thXXUJN4sRJ/NquCuTKaJMn0NcKiIG4UnQ+ Gdn9A0u9yihqVC5aO2FSoXNW3+nBATUjJk7tLv6ak2Nq/zVH+ocFbGZYGRlFzcvwefDi uS2nDiQnQ3AoL+wV/v5CIeg8AXbm9ja6vNyUuLiJxgZUjDYF01+GoZdOsc4NbSMoGsP/ foF9T49uuYggoWQZdDQL6tfJDO3rQjXBOYnzAESRj5vhkerCq4UYldOOHEfgtrT+j+fw RChw== X-Gm-Message-State: AOAM532Ka3U29FP/w+HTpYZ0Hv89dzka+rqLb5NgwA+RB4AhVjuk8zfR 2fqfUXGPEu0Azidm5A95+n7DMw== X-Google-Smtp-Source: ABdhPJygZRYwlGvdGJAL0lWWwoI1gNQxPOGthXA5JCGR57D4nVBu7V+IvRPqEu1oziXpXKWdtMMOFQ== X-Received: by 2002:ac8:5947:: with SMTP id 7mr345442qtz.177.1631549819823; Mon, 13 Sep 2021 09:16:59 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-0166-c2e8-bb10-efce.res6.spectrum.com. [2603:6081:7b01:cbda:166:c2e8:bb10:efce]) by smtp.gmail.com with ESMTPSA id v24sm4304853qtq.17.2021.09.13.09.16.58 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 Sep 2021 09:16:59 -0700 (PDT) Date: Mon, 13 Sep 2021 12:16:56 -0400 From: Tom Rini To: =?iso-8859-1?Q?Fran=E7ois?= Ozog Cc: Jan Kiszka , Simon Glass , U-Boot Mailing List , Le Jin , Bao Cheng Su , Nian Gao , Chao Zeng , Lokesh Vutla Subject: Re: [PATCH v7 5/5] iot2050: Enable watchdog support, but do not auto-start it Message-ID: <20210913161656.GQ12964@bill-the-cat> References: <44b858e8826f4617439aec11ad850431e4bc1a21.1628000645.git.jan.kiszka@siemens.com> <20210911001003.GA2638@bill-the-cat> <0fd4c0d4-c42f-bb15-b68b-3ccf9a9037e0@siemens.com> <20210913123445.GB12964@bill-the-cat> <5d515165-6f39-285d-7bd1-a412ed468cf4@siemens.com> <20210913145609.GO12964@bill-the-cat> <54d40bce-3baf-e485-3467-863eca5bf296@siemens.com> <20210913153621.GP12964@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YtaS/7ZiU/hUUpeU" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --YtaS/7ZiU/hUUpeU Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 13, 2021 at 06:08:10PM +0200, Fran=E7ois Ozog wrote: > On Mon, 13 Sept 2021 at 17:36, Tom Rini wrote: >=20 > > On Mon, Sep 13, 2021 at 04:59:35PM +0200, Jan Kiszka wrote: > > > On 13.09.21 16:56, Tom Rini wrote: > > > > On Mon, Sep 13, 2021 at 04:31:37PM +0200, Jan Kiszka wrote: > > > >> On 13.09.21 14:34, Tom Rini wrote: > > > >>> On Mon, Sep 13, 2021 at 09:57:45AM +0200, Jan Kiszka wrote: > > > >>>> On 11.09.21 02:10, Tom Rini wrote: > > > >>>>> On Tue, Aug 03, 2021 at 04:24:05PM +0200, Jan Kiszka wrote: > > > >>>>> > > > >>>>>> From: Jan Kiszka > > > >>>>>> > > > >>>>>> This allows to use the watchdog in custom scripts but does not > > enforce > > > >>>>>> that the OS has to support it as well. > > > >>>>>> > > > >>>>>> Signed-off-by: Jan Kiszka > > > >>>>> > > > >>>>> Sorry for the late reply. This causes CI to fail: > > > >>>>> Building current source for 1 boards (1 thread, 16 jobs per thr= ead) > > > >>>>> aarch64: + iot2050 > > > >>>>> +(iot2050) WARNING ATF file bl31.bin NOT found, resulting binary > > is non-functional > > > >>>>> +(iot2050) WARNING OPTEE file bl32.bin NOT found, resulting mig= ht > > be non-functional > > > >>>>> +(iot2050) binman: Filename 'k3-rti-wdt.fw' not found in input > > path (.,/home/trini/work/u-boot/u-boot,board/siemens/iot2050,arch/arm/d= ts) > > (cwd=3D'/tmp/iot2050/.bm-work/iot2050') > > > >>>>> +(iot2050) make[1]: *** [all] Error 1 > > > >>>>> +(iot2050) make: *** [sub-make] Error 2 > > > >>>>> 0 0 1 /1 iot2050 > > > >>>>> > > > >>>>> And needs to be handled like ATF/OPTEE/etc where CI can build b= ut > > throw > > > >>>>> a "THIS WILL NOT RUN CORRECTLY" type warning to the user. > > > >>>>> > > > >>>> > > > >>>> I was about to sent an update anyway - time passed, and now we e= ven > > have > > > >>>> support for the next generation integrated from the beginning. B= ut > > > >>>> related upstream DT changes are not yet merged. > > > >>> > > > >>> OK. > > > >>> > > > >>>> But back to this issue: How can CI be fed with all those required > > > >>>> binaries? The build makes no sense in their absence. > > > >>> > > > >>> To be clearer, CI isn't fed all of the binaries, we just use > > /dev/null > > > >>> in that case and try and make it clear it won't boot. K3 isn't a > > good > > > >>> example here, but I think sunxi uses binman and handles this same > > class > > > >>> of problem? > > > >>> > > > >> > > > >> I'm seeing it additionally carrying a "missing-msg" property, but = that > > > >> alone (even with missing-blob-help updated) does not make the build > > > >> pass. It rather seems I'm missing some "allow_missing" property for > > that > > > >> image, but even reading the code gives no clue yet how to achieve > > that. > > > >> Yet another binman mystery. > > > > > > > > You might also need a new file in tools/binman/etype/ ? Also, it w= ill > > > > have a non-zero exit status still, but with a value of 101 which we > > > > check for and know that's "binary blob missing" and so OK to allow = CI > > to > > > > pass on. > > > > > > > > > > Err, that doesn't sound like binman is making my life easier. Why can= 't > > > a I simple do something like > > > > > > k3-rti-wdt-firmware { > > > type =3D "blob"; > > > load =3D <0x82000000>; > > > blob { > > > filename =3D CONFIG_WDT_K3_RTI_FW_FILE; > > > missing-msg =3D "k3-rti-wdt-firmware"; > > > allow_missing; > > > }; > > > }; > > > > > > and be done? > > > > Sounds like a good idea, and I'm not quite sure what's missing to go > > from where we are today to there. I might be missing something myself. > > >=20 > If that entry is located in a DT for U-Boot consumption why not, but in t= he > DT that is associated to a platform that is passed to the OS, that sounds > like a practice to avoid as this does not describe hardware. Thinking > compatibility, is the filename/filepath really OS independent ? So, here's one of those cases where we aren't really talking about the runtime device tree so much as how we configure the build. binman is how we assemble the assorted binaries in to a functional blob for a given platform without having to write a new tool for every SoC. --=20 Tom --YtaS/7ZiU/hUUpeU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmE/eXUACgkQFHw5/5Y0 tyw/7gv+KZgqqmKws1quD0c8YEYtH5+PMK9GwqTY1GuZojrSkdH4sG2XOWGxx2nD s8sqqqnC9WrPLCVoSf/FkxEblTX+DuQb0yFbKtbG/X7eQHzk3/hCvGL8hdRSfEbf F+dUmUWiKJ9yMxSv7qyhMF3kPIPUxVIh81rDzJRg8T3T26N13Hoe8CADtmJ35mFU 6wQlzpdPvj9gALB9Wr7ASw8VrgU6oqh6hsuvthorgKdDfIyzXWNuOWK7zkwNm27o 0TkMC8t/6EQV/ouCFdCSc9XCkjPVmjiCqXcYZcaA7HtXWLcnIl1Di23B/a9cJqxT nY6nDLfsP8Fbw67FQhpbkWd3ZyFwG814JwYwKrkhjfuxwRE5bHpG6XktF1o3bDBU o4APGA6ueO0GqoLHxOHE6ZeYi4TyHvLuNPzCZ5MWMubZqZEZdbdhN7H/r1kK5GP+ 2V2VC2KGzAw5zKKpiiRAyidJQEwuAWbQcAH4SVM/FhgrBW/CIfr6dp04qdQTdFYb bc6Llu5T =EZQD -----END PGP SIGNATURE----- --YtaS/7ZiU/hUUpeU--