From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB8CBC433EF for ; Tue, 14 Sep 2021 08:22:28 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD09D60E94 for ; Tue, 14 Sep 2021 08:22:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CD09D60E94 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BFB8883450; Tue, 14 Sep 2021 10:22:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id E2ABD83453; Tue, 14 Sep 2021 10:22:21 +0200 (CEST) Received: from ATCSQR.andestech.com (atcsqr.andestech.com [60.248.187.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2D4D78340C for ; Tue, 14 Sep 2021 10:22:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id 18E8Lxqb066372; Tue, 14 Sep 2021 16:21:59 +0800 (GMT-8) (envelope-from ycliang@andestech.com) Received: from atcsi01 (10.0.15.167) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Tue, 14 Sep 2021 16:22:00 +0800 Date: Tue, 14 Sep 2021 16:21:57 +0800 From: Leo Liang To: Bin Meng CC: Zong Li , Rick Chen , Subject: Re: [PATCH v2] board: sifive: Fix a potential build warning in board_fdt_blob_setup() Message-ID: <20210914082157.GA2180443@atcsi01> References: <20210911143123.10423-1-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20210911143123.10423-1-bmeng.cn@gmail.com> X-Originating-IP: [10.0.15.167] X-DNSRBL: X-MAIL: ATCSQR.andestech.com 18E8Lxqb066372 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, Sep 11, 2021 at 10:31:23PM +0800, Bin Meng wrote: > Commit 47d73ba4f4a4 ("board: sifive: overwrite board_fdt_blob_setup in u-= boot proper") > added a board-specific implementation of board_fdt_blob_setup() which > takes a pointer as the return value, but it does not return anything > if CONFIG_OF_SEPARATE is not enabled. This will cause a build warning > seen when testing booting S-mode U-Boot directly from QEMU, per the > instructions in [1]: > > board/sifive/unleashed/unleashed.c: In function =E2=80=98board_fdt_blob= _setup=E2=80=99: > board/sifive/unleashed/unleashed.c:125:1: warning: control reaches end = of non-void function [-Wreturn-type] > > Return &_end as the default case. > > [1] https://qemu.readthedocs.io/en/latest/system/riscv/sifive_u.html#runn= ing-u-boot > > Signed-off-by: Bin Meng Reviewed-by: Leo Yu-Chi Liang CONFIDENTIALITY NOTICE: This e-mail (and its attachments) may contain confidential and legally priv= ileged information or information protected from disclosure. If you are not= the intended recipient, you are hereby notified that any disclosure, copyi= ng, distribution, or use of the information contained herein is strictly pr= ohibited. In this case, please immediately notify the sender by return e-ma= il, delete the message (and any accompanying documents) and destroy all pri= nted hard copies. Thank you for your cooperation. Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.