From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FF54C4332F for ; Tue, 14 Sep 2021 08:40:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC73961159 for ; Tue, 14 Sep 2021 08:40:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BC73961159 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 575BC8346D; Tue, 14 Sep 2021 10:39:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 1945583458; Tue, 14 Sep 2021 10:39:56 +0200 (CEST) Received: from ATCSQR.andestech.com (atcsqr.andestech.com [60.248.187.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7506483458 for ; Tue, 14 Sep 2021 10:39:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id 18E8diEr070233; Tue, 14 Sep 2021 16:39:44 +0800 (GMT-8) (envelope-from ycliang@andestech.com) Received: from atcsi01 (10.0.15.167) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Tue, 14 Sep 2021 16:39:43 +0800 Date: Tue, 14 Sep 2021 16:39:40 +0800 From: Leo Liang To: Sean Anderson CC: Subject: Re: [PATCH v2 1/4] clk: k210: Fix checking if ulongs are less than 0 Message-ID: <20210914083940.GA3978668@atcsi01> References: <20210911172003.899301-1-seanga2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210911172003.899301-1-seanga2@gmail.com> X-Originating-IP: [10.0.15.167] Content-Transfer-Encoding: quoted-printable X-DNSRBL: X-MAIL: ATCSQR.andestech.com 18E8diEr070233 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, Sep 11, 2021 at 01:20:00PM -0400, Sean Anderson wrote: > The PLL functions take ulong arguments for rate, but still check if that > rate is negative (which is never true). The correct way to handle this is > to use IS_ERR_VALUE (like is already done in k210_clk_set_rate). While > we're at it, we can move the error checking up into the caller of the pll > set/get rate functions. This also protects our other calculations from > using bogus values for rate. > > Fixes: 609bd60b94 ("clk: k210: Rewrite to remove CCF") > Reported-by: Coverity Scan > Signed-off-by: Sean Anderson > --- > > Changes in v2: > - Reworked patch to use IS_ERR_VALUE instead of changing arguments to lon= g > > drivers/clk/clk_kendryte.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > Reviewed-by: Leo Yu-Chi Liang CONFIDENTIALITY NOTICE: This e-mail (and its attachments) may contain confidential and legally priv= ileged information or information protected from disclosure. If you are not= the intended recipient, you are hereby notified that any disclosure, copyi= ng, distribution, or use of the information contained herein is strictly pr= ohibited. In this case, please immediately notify the sender by return e-ma= il, delete the message (and any accompanying documents) and destroy all pri= nted hard copies. Thank you for your cooperation. Copyright ANDES TECHNOLOGY CORPORATION - All Rights Reserved.