From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A4CBC433EF for ; Tue, 14 Sep 2021 09:31:30 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4BF061056 for ; Tue, 14 Sep 2021 09:31:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E4BF061056 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4154483B0C; Tue, 14 Sep 2021 11:31:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1631611888; bh=RciuW7hJcM35khZ0sHhaXn2P6NpUq25mgq+bLjYsesQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OjglFZ6sd0p58un1J/MS2H2YdG4QUnHkpj0UVBKQTAMK3LprXbh6SSYQZPtAeyYoD M0+t0GZgzbwkKbYKoC3x2clzaZe+kO3HLu9PLLkwoC7Vo7yI0AUjWWa5YA03fx52Zv F2ZFEaTLLPx72fIgDsdYNpCKK2hOywxS1emYSvqHMQMKrEo0u6a0XB0A5SdkzCaF8Y yDy6/W+U7KIaCMbS94Xdx/PYk9NZ9/GI57RY4IZ0gtemF8YlOzB+uLAPF6MpnaN3/a KS9Wi5MvYZly26crYL+7C6Ok3GJP3zGlHD2w1iNiGY2ce50ZfT5aQKqV0//99sUW5L ce0NM224NW7bw== Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 093CD8344D; Tue, 14 Sep 2021 11:31:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1631611884; bh=RciuW7hJcM35khZ0sHhaXn2P6NpUq25mgq+bLjYsesQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iERey0HrhtkViwtolJrBjhtlz0sAI1mjpP3j6P2iyWT67WVGSWZCnCkzTSaVp9uNH IDbLfVM+jJfwpjMac7tpDHETHX8ky+JW+BeEDdRNSyYIYhHq1UXmEbBBqLvwlgrcyM It9Ag/OcfK6xXGFuwtWS5tB8sXbL85dWDTkZJyRASAkrBO1vB7FHeL6ng6VlTGVwuS vGAXc0Mi+FwTBZLm7ncB1rLY2IupFGLQI1Kvxkg3WkRUXEDe0wn3CaqLtd+faTlE44 ZcD3aXlZKgDlx0Ndy1nZ3z7OMnNZ5x65t+hMf0rP6XmoRz97IcMkAvhfQjTozKPfjC d1q6s4Ju8/vgA== Date: Tue, 14 Sep 2021 11:31:18 +0200 From: Lukasz Majewski To: Marek Vasut Cc: u-boot@lists.denx.de Subject: Re: [PATCH] dfu: dfu_sf: Read the SPI flash in 16 MiB chunks Message-ID: <20210914113118.2253842c@ktm> In-Reply-To: <20210914032651.273567-1-marex@denx.de> References: <20210914032651.273567-1-marex@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/dirIFE53iKZz6GV+gO2l8FE"; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Sig_/dirIFE53iKZz6GV+gO2l8FE Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 14 Sep 2021 05:26:51 +0200 Marek Vasut wrote: > Not all SPI flashes and controllers can do continuous transfer longer > than 16 MiB, so perform the DFU read in 16 MiB chunks. >=20 > Signed-off-by: Marek Vasut > Cc: Lukasz Majewski > --- > drivers/dfu/dfu_sf.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c > index 7e64ab772f0..b72493ced86 100644 > --- a/drivers/dfu/dfu_sf.c > +++ b/drivers/dfu/dfu_sf.c > @@ -24,8 +24,18 @@ static int dfu_get_medium_size_sf(struct > dfu_entity *dfu, u64 *size) static int dfu_read_medium_sf(struct > dfu_entity *dfu, u64 offset, void *buf, long *len) > { > - return spi_flash_read(dfu->data.sf.dev, dfu->data.sf.start + > offset, > - *len, buf); > + long seglen =3D *len; > + int ret; > + > + if (seglen > (16 << 20)) > + seglen =3D (16 << 20); > + > + ret =3D spi_flash_read(dfu->data.sf.dev, dfu->data.sf.start + > offset, > + seglen, buf); > + if (!ret) > + *len =3D seglen; > + > + return ret; > } > =20 > static u64 find_sector(struct dfu_entity *dfu, u64 start, u64 offset) Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/dirIFE53iKZz6GV+gO2l8FE Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmFAa+YACgkQAR8vZIA0 zr3mKggAikt9Q16rkqIFuMwpHdnO/Cf5ijt25o6j/2nszlkSDYl3LaDvEBAHajZk j05ZXmTjvF8TQ/QwpXoquOxT991e0/K75FOtKtdVAd4x1v4ar9DglP6dtdCEn+mf KJ+HcRoy1zJQf6QG7dbXP2Wy0jVeACMdz/+7KkQD19uWzvObfv0FvnNBg9ECjIDq 1biIp3vTjXUQsrQhykpypFBAqJCDDpuOsMPZ2TBTTEMsjUlg0d/VhBpmS5/dbCwa RnZY812laGycmSNFKuK/WtOZGPDwqOW5LPWBZ9tNlU9LJ5laRNNEPzhAWQ2zdKes ZSGjrBpPSCPJL48rSdMre/tc02UAGg== =yQUS -----END PGP SIGNATURE----- --Sig_/dirIFE53iKZz6GV+gO2l8FE--