From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC43BC433FE for ; Tue, 14 Sep 2021 09:31:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB3FA604AC for ; Tue, 14 Sep 2021 09:31:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EB3FA604AC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 358CE83B0E; Tue, 14 Sep 2021 11:31:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1631611911; bh=cBQlck4YnALL8piUM8ViWzxkhefcBSIDM6XNrl/rF50=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=bE4ZHWYEuxCWs9U/5BSMhjt9MJ7rek/Cx6AOXRgY7dcIGG5lRDXPnqlQZPe3rZS0O m32XEUUO0RrObjKVfNG53+OHrvtlPLTApm6Y3INjqzPY1o7hRyGtr/sBWzv0S/lYly ZxvuZQ8tkS3H35tjMUGZCcGrA7pgh4U+8e8TZz6HjH893vX44Ay5CRzOW8CDlWxVl0 7+/IOhT0vl6SsnXU+cyvQUwkmLNvyCeWTX8u/3j9YpgxyoOjYU73iPMpGJ2fVQ8tmt rVBZZFqf8ejjjSDjo7kq5FI/ODt3CnoOb8MNza3EZiFJvuAzffXkYs1oJtBUP38S7a Y0w5PaU5kpc8Q== Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 77B098344D; Tue, 14 Sep 2021 11:31:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1631611909; bh=cBQlck4YnALL8piUM8ViWzxkhefcBSIDM6XNrl/rF50=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sUkes9NI4FRFLmJG7na1FQW02kgKj195bZLJ9C1sU+wLr8CqJ7cfG/vOQ8dUWPbkP 9WUkhwIOESDh9y+AGimKdDEklZZU0dOQjBp3sFYLvJCoI2ZIAcfUSNr4p7OzaE8v1c hq9G5qun5z9LiEyXBMBJCNceI3R5oeCu0eB8I8TNCClt4R9jd8f3YXDekTdnyFCWF8 /gIuDeun6DQ6rDA0WslNMYsvEob0TCfJKTf8kX2CE6hZtFcNxIxoBnF31f1496ZHun ai8B6gAG6edBNK8O6g/K45H0krTV3MoaDboFuu5vCA0Fj9qEKt2hNON1YBITVuyier /4j/z1bb6Ykgw== Date: Tue, 14 Sep 2021 11:31:48 +0200 From: Lukasz Majewski To: Marek Vasut Cc: u-boot@lists.denx.de Subject: Re: [PATCH] dfu: dfu_sf: Add support for multiple flashes Message-ID: <20210914113148.467a774a@ktm> In-Reply-To: <20210914032751.273606-1-marex@denx.de> References: <20210914032751.273606-1-marex@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/+e1dn1GgEj13T.9EJ/EOjNf"; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Sig_/+e1dn1GgEj13T.9EJ/EOjNf Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 14 Sep 2021 05:27:51 +0200 Marek Vasut wrote: > Add dfu_alt_info option which allows specifying multiple SPI flashes > as an alt info. The syntax is as follows: >=20 > altname sf bus:cs[:speed[:mode]] >=20 > Example: > dfu_alt_info=3Dqspi0 sf 0:0;qspi1 sf 0:1 >=20 > Signed-off-by: Marek Vasut > Cc: Lukasz Majewski > --- > drivers/dfu/dfu_sf.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c > index b72493ced86..d246e1b21ff 100644 > --- a/drivers/dfu/dfu_sf.c > +++ b/drivers/dfu/dfu_sf.c > @@ -168,22 +168,31 @@ static struct spi_flash *parse_dev(char *devstr) > int dfu_fill_entity_sf(struct dfu_entity *dfu, char *devstr, char *s) > { > char *st; > - char *devstr_bkup =3D strdup(devstr); > - > - dfu->data.sf.dev =3D parse_dev(devstr_bkup); > - free(devstr_bkup); > - if (!dfu->data.sf.dev) > - return -ENODEV; > =20 > dfu->dev_type =3D DFU_DEV_SF; > dfu->max_buf_size =3D dfu->data.sf.dev->sector_size; > =20 > st =3D strsep(&s, " "); > if (!strcmp(st, "raw")) { > + char *devstr_bkup =3D strdup(devstr); > + dfu->data.sf.dev =3D parse_dev(devstr_bkup); > + free(devstr_bkup); > + if (!dfu->data.sf.dev) > + return -ENODEV; > + > dfu->layout =3D DFU_RAW_ADDR; > dfu->data.sf.start =3D hextoul(s, &s); > s++; > dfu->data.sf.size =3D hextoul(s, &s); > + } else if (!strcmp(st, "sf")) { > + st =3D strsep(&s, " "); > + dfu->data.sf.dev =3D parse_dev(st); > + if (!dfu->data.sf.dev) > + return -ENODEV; > + > + dfu->layout =3D DFU_RAW_ADDR; > + dfu->data.sf.start =3D 0; > + dfu->data.sf.size =3D dfu->data.sf.dev->size; > } else if (CONFIG_IS_ENABLED(DFU_SF_PART) && > (!strcmp(st, "part") || !strcmp(st, "partubi"))) { > char mtd_id[32]; Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/+e1dn1GgEj13T.9EJ/EOjNf Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmFAbAQACgkQAR8vZIA0 zr1SZAf+LdWlvGIguLLHBbpnGlnow9q0oEVIJQGHck/fz1r8KZx0v18fcMFgKrOn QF+apduewlszdTAedC8qmx3wjMMVDFU6jcCuuBJefHwNdgADa09HZVau0L4BdDi7 1BApEg8goI72H7QPyNV/SNOatnp+0RSCmf/6kCQmJi0Gr0TZoonWQUd8Q+zY6rEi Gcvsake8FmkyKYoJfzEtyov4zIp2L4zf32qwBUORt3p6/Bra1MjGe1OPpzDcZxa1 vJMChwK7lJ4xrNLQ+mhRvKsUSl4yDut13mkG9kMOBGRi9Au8Ju4/W3QHTyFQnGTn ZpWp848i3WcGfDaSEzMfcZIz/Yh9Fw== =TSAp -----END PGP SIGNATURE----- --Sig_/+e1dn1GgEj13T.9EJ/EOjNf--